[Bug 6906] New: show 'Borrower has previously issued $ITEM' alert on checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Bug #: 6906 Summary: show 'Borrower has previously issued $ITEM' alert on checkout Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: mtj@kohaaloha.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com A common request for some borrowers is to be alerted by library staff, when issuing items, to whether they have previously issued an item before this enhancement provides this feature, and allows the librarian to set the checkout alert, at a per-user level -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #1 from Mason James <mtj@kohaaloha.com> 2011-09-22 06:56:14 UTC --- oops, that should read... A common request for some borrowers is to be alerted by library staff, when issuing items, to whether they have previously issued *that* item before :) this enhancement provides this feature, and allows the librarian to set the checkout alert, at a per-user level -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #2 from Mason James <mtj@kohaaloha.com> 2011-09-22 07:03:02 UTC --- Created attachment 5531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5531 'reading-history' setting is enabled by librarian, for specific user -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #3 from Mason James <mtj@kohaaloha.com> 2011-09-22 07:05:42 UTC --- Created attachment 5532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5532 'reading-history' setting is now displayed in staff sidebar area -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #4 from Mason James <mtj@kohaaloha.com> 2011-09-22 07:10:41 UTC --- Created attachment 5533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5533 librarian attempts to issue a previously issued item... librarian attempts to issue a previously issued item, and a yes/no warning prompt is displayed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kyle.m.hall@gmail.com |mtj@kohaaloha.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nengard@gmail.com --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-09-29 15:50:44 UTC --- Grammar issue - 'has' isn't necessary in that warning box. Do you have a patch for this? Or are you just suggesting it? Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-09-29 15:51:55 UTC --- Oh and we might want to call it something other than 'reading history' since the reading history can be controlled by a system preference. Maybe 'reading history warning' would be more accurate. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #7 from Mason James <mtj@kohaaloha.com> 2011-10-13 17:29:27 UTC --- (In reply to comment #5)
Grammar issue - 'has' isn't necessary in that warning box. Do you have a patch for this? Or are you just suggesting it?
Nicole
heya, yeah - its an feature i did for Kapiti patch coming soon... :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, any update on this? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 10812 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.sassmannshausen@ptfs-e | |urope.com --- Comment #10 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Hello, In preparation of work on bug 5670, I have implemented the functionality discussed in this bug in a generic, granular fashion. I will shortly be uploading my patch for (hopefully) sign-off and qa. Let me know if you have any questions. Best wishes, Alex -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #11 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 27558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27558&action=edit Patch to implement described functionality New module: provide granular means to configure warnings about items that have been issued to a particular borrower before, according to their loan history. - Global syspref ('CheckPrevIssueByDefault'), set to 'No' by default, allows users to enable this feature library wide. - Per category pref allow libraries to create overrides per category, falling back on the global setting by default. - Per borrower pref allows switching the functionality on at the level of borrowers. Fall-back to category settings by default. * Koha/Borrowers/CheckPrevIssue.pm: new module. * C4/Circulation.pm (CanBookBeIssued): introduce CheckPrevIssue check. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add 'CHECKPREVISSUE' confirmation message. * installer/data/mysql/kohastructure.sql: modify structure of 'categories', 'borrowers'. * installer/data/mysql/sysprefs.sql: add 'CheckPrevIssueByDefault' (exposed in patrons.pref). * installer/data/mysql/updatedatabase.pl: provide upgrade path. * admin/categorie.pl: add 'checkprevissuebycategory' to sql queries; pass it to template. * .../admin/categorie.tt: .../members/memberentrygen.tt: .../members/moremember.tt: add content. * CheckPrevIssue.t: new file with unit tests. Test plan: - Apply patch. - Run db updateds from updatedatabase.pl manually (I have not updated the database version yet — not sure whether I should have done?) - Optionally, run Unit Tests (t/CheckPrevIssue.t) - Verify 'CheckPrevIssueByDefault' is visible in Patrons sysprefs and can be switched 'on' and 'off'. + Issue previously issued items to a borrower, checking the message appears as expected. - Verify 'Check previous loans' setting appears on the borrower category pages and can be modified per borrower category. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the default setting). - Verify 'Check previous loans' setting appears on individual borrower pages and can be modified. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the category setting and the default setting). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mtj@kohaaloha.com |alex.sassmannshausen@ptfs-e | |urope.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 27558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27558 Patch to implement described functionality Review of attachment 27558: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6906&attachment=27558) ----------------------------------------------------------------- Pretty happy with this in general. Just a few minor points regarding style.. but then, I could be missing something ;) ::: installer/data/mysql/kohastructure.sql @@ +265,4 @@
`altcontactphone` varchar(50) default NULL, -- the phone number for the alternate contact for the patron/borrower `smsalertnumber` varchar(50) default NULL, -- the mobile phone number where the patron/borrower would like to receive notices (if SNS turned on) `privacy` integer(11) DEFAULT '1' NOT NULL, -- patron/borrower's privacy settings related to their reading history + `checkprevissuebyborrower` varchar(7) NOT NULL default 'inherit', -- produce a warning for this borrower if this item has previously been issued to this borrower if 'yes', not if 'no', defer to category setting if 'inherit'.
I think I would lose the 'byborrower' part of 'checkprevissuebyborrower' here, I think 'checkprevissue' is descriptive enough, and we already know it's in the borrower context due to the table it's found in. @@ +466,5 @@
`issuelimit` smallint(6) default NULL, -- unused in Koha `reservefee` decimal(28,6) default NULL, -- cost to place holds `hidelostitems` tinyint(1) NOT NULL default '0', -- are lost items shown to this category (1 for yes, 0 for no) + `category_type` varchar(1) NOT NULL default 'A', -- type of Koha patron (Adult, Child, Professional, Organizational, Statistical, Staff), + `checkprevissuebycategory` varchar(7) NOT NULL default 'inherit', -- produce a warning for this borrower category if this item has previously been issued to this borrower if 'yes', not if 'no', defer to category setting if 'inherit'.
Do you mean "defer to 'syspref' setting if inherit." here? I think I would lose the 'bycategory' part of 'checkprevissuebycategory' here, I think 'checkprevissue' is descriptive enough, and we already know it's in the category context due to the table it's found in. ::: installer/data/mysql/updatedatabase.pl @@ +8202,4 @@
SetVersion($DBversion); }
+# FIXME: change $DBversion
The 'normal' way of doing this now is to put '$DBversion = "3.15.00.XXX";' These happen all the time, so the RM and QA people are used to these types of conflicts ;) ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref @@ +50,4 @@
class: multi - (separate multiple choices with |) - + - pref: CheckPrevIssueByDefault
As you can probably tell by now, I'm a fan of shorter, but still descriptive, names. Do we really need the 'ByDefault' here? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #13 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 27606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27606&action=edit Bug 6906 - show 'Borrower has previously... New module: provide granular means to configure warnings about items that have been issued to a particular borrower before, according to their loan history. - Global syspref ('CheckPrevIssue'), set to 'No' by default, allows - users to enable this feature library wide. - Per category pref allow libraries to create overrides per category, falling back on the global setting by default. - Per borrower pref allows switching the functionality on at the level of borrowers. Fall-back to category settings by default. * Koha/Borrowers/CheckPrevIssue.pm: new module. * C4/Circulation.pm (CanBookBeIssued): introduce CheckPrevIssue check. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add 'CHECKPREVISSUE' confirmation message. * installer/data/mysql/kohastructure.sql: modify structure of 'categories', 'borrowers'. * installer/data/mysql/sysprefs.sql: add 'CheckPrevIssue' (exposed in patrons.pref). * installer/data/mysql/updatedatabase.pl: provide upgrade path. * admin/categorie.pl: add 'checkprevissue' to sql queries; pass it to template. * .../admin/categorie.tt: .../members/memberentrygen.tt: .../members/moremember.tt: add content. * CheckPrevIssue.t: new file with unit tests. Test plan: - Apply patch. - Run db updates from updatedatabase.pl manually. - Verify 'CheckPrevIssue' is visible in Patrons sysprefs and can be switched 'on' and 'off'. + Issue previously issued items to a borrower, checking the message appears as expected. - Verify 'Check previous loans' setting appears on the borrower category pages and can be modified per borrower category. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the default setting). - Verify 'Check previous loans' setting appears on individual borrower pages and can be modified. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the category setting and the default setting). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27558|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nick@quecheelibrary.org --- Comment #14 from Nick Clemens <nick@quecheelibrary.org> --- Applying: Bug 6906 - show 'Borrower has previously... Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging admin/categorie.pl CONFLICT (content): Merge conflict in admin/categorie.pl Auto-merging C4/Circulation.pm Failed to merge in the changes. Patch failed at 0001 Bug 6906 - show 'Borrower has previously... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27606|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30680&action=edit Bug 6906 - show 'Borrower has previously... New module: provide granular means to configure warnings about items that have been issued to a particular borrower before, according to their loan history. - Global syspref ('CheckPrevIssue'), set to 'No' by default, allows - users to enable this feature library wide. - Per category pref allow libraries to create overrides per category, falling back on the global setting by default. - Per borrower pref allows switching the functionality on at the level of borrowers. Fall-back to category settings by default. * Koha/Borrowers/CheckPrevIssue.pm: new module. * C4/Circulation.pm (CanBookBeIssued): introduce CheckPrevIssue check. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add 'CHECKPREVISSUE' confirmation message. * installer/data/mysql/kohastructure.sql: modify structure of 'categories', 'borrowers'. * installer/data/mysql/sysprefs.sql: add 'CheckPrevIssue' (exposed in patrons.pref). * installer/data/mysql/updatedatabase.pl: provide upgrade path. * admin/categorie.pl: add 'checkprevissue' to sql queries; pass it to template. * .../admin/categorie.tt: .../members/memberentrygen.tt: .../members/moremember.tt: add content. * CheckPrevIssue.t: new file with unit tests. Test plan: - Apply patch. - Run db updates from updatedatabase.pl manually. - Verify 'CheckPrevIssue' is visible in Patrons sysprefs and can be switched 'on' and 'off'. + Issue previously issued items to a borrower, checking the message appears as expected. - Verify 'Check previous loans' setting appears on the borrower category pages and can be modified per borrower category. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the default setting). - Verify 'Check previous loans' setting appears on individual borrower pages and can be modified. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the category setting and the default setting). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Re-based against current master. Would be awesome if you could take another look Nick :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #17 from Marc Véron <veron@veron.ch> --- Created attachment 30681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30681&action=edit [Signded-off] Bug 6906 - show 'Borrower has previously... New module: provide granular means to configure warnings about items that have been issued to a particular borrower before, according to their loan history. - Global syspref ('CheckPrevIssue'), set to 'No' by default, allows - users to enable this feature library wide. - Per category pref allow libraries to create overrides per category, falling back on the global setting by default. - Per borrower pref allows switching the functionality on at the level of borrowers. Fall-back to category settings by default. * Koha/Borrowers/CheckPrevIssue.pm: new module. * C4/Circulation.pm (CanBookBeIssued): introduce CheckPrevIssue check. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add 'CHECKPREVISSUE' confirmation message. * installer/data/mysql/kohastructure.sql: modify structure of 'categories', 'borrowers'. * installer/data/mysql/sysprefs.sql: add 'CheckPrevIssue' (exposed in patrons.pref). * installer/data/mysql/updatedatabase.pl: provide upgrade path. * admin/categorie.pl: add 'checkprevissue' to sql queries; pass it to template. * .../admin/categorie.tt: .../members/memberentrygen.tt: .../members/moremember.tt: add content. * CheckPrevIssue.t: new file with unit tests. Test plan: - Apply patch. - Run db updates from updatedatabase.pl manually. - Verify 'CheckPrevIssue' is visible in Patrons sysprefs and can be switched 'on' and 'off'. + Issue previously issued items to a borrower, checking the message appears as expected. - Verify 'Check previous loans' setting appears on the borrower category pages and can be modified per borrower category. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the default setting). - Verify 'Check previous loans' setting appears on individual borrower pages and can be modified. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the category setting and the default setting). Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30680|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 30681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30681 [Signded-off] Bug 6906 - show 'Borrower has previously... Review of attachment 30681: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6906&attachment=30681) ----------------------------------------------------------------- ::: Koha/Borrower/CheckPrevIssue.pm @@ +29,5 @@
+); + +=head1 Koha::Borrower::CheckPrevIssue + +Koha::Borrower::Debarments - Manage Previous Issue preferences & searches.
(trivial) Should be Koha::Borrower::CheckPrevIssue :) @@ +65,5 @@
+sub _WantsCheckPrevIssueByCat { + my ( $borrowernumber ) = @_; + my $dbh = C4::Context->dbh; + my $query = ' +SELECT categories.checkprevissue
(not a blocker) Could be rewritten in a follow-up to use DBIC. ::: installer/data/mysql/kohastructure.sql @@ +265,4 @@
`altcontactphone` varchar(50) default NULL, -- the phone number for the alternate contact for the patron/borrower `smsalertnumber` varchar(50) default NULL, -- the mobile phone number where the patron/borrower would like to receive notices (if SNS turned on) `privacy` integer(11) DEFAULT '1' NOT NULL, -- patron/borrower's privacy settings related to their reading history + `checkprevissue` varchar(7) NOT NULL default 'inherit', -- produce a warning for this borrower if this item has previously been issued to this borrower if 'yes', not if 'no', defer to category setting if 'inherit'.
(normal) This needs to be added to deletedborrowers as well as both tables need to be kept in sync. ::: installer/data/mysql/updatedatabase.pl @@ +8606,5 @@
+$DBversion = "3.17.00.XXX"; +if ( CheckVersion($DBversion) ) { + $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('CheckPrevIssue','0','','By default, for every item issued, should we warn if the patron has borrowed that item in the past?','YesNo')"); + $dbh->do("ALTER TABLE categories ADD (`checkprevissue` varchar(7) NOT NULL default 'inherit')"); + $dbh->do("ALTER TABLE borrowers ADD (`checkprevissue` varchar(7) NOT NULL default 'inherit')");
(normal) deletedborrowers need to be added here as well. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some additions from further testing: (trivial) Test file All tests pass :) I think the file name would be a bit better including Koha_Borrowers.* in front like the other test files. There is also a Koha directory it could fit into. (trivial) Database update When adding new columns to the tables it's best practice to use AFTER or BEFORE making sure they go in the same spot for new and updated installations. Otherwise looking good so far. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org