[Bug 34826] New: Circulation rules edit row select elements don't always update when selecting new row for editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34826 Bug ID: 34826 Summary: Circulation rules edit row select elements don't always update when selecting new row for editing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: mikko.liimatainen@turku.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When editing circulation and fine rules selecting another row for editing without saving first can cause an issue where select elements on edit row don't update properly. This seems to be caused by adding additional selected values for select options each time different line is selected for editing. For example if you select each item type rule for editing you can have all item types selected on edit row select element after which that element doesn't update at all anymore when selecting new row for editing. I think clearing selected values from these select options each time when selecting new row for editing before adding selected value for the right option should fix the issue. At least there would no longer be conflict on which option value is actually selected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34826 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's not intended that you can add multiple rules without saving, you have to edit one after the other. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34826 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you maybe add a step by step? I don't fully understand the problem from your description I think. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34826 --- Comment #3 from Mikko Liimatainen <mikko.liimatainen@turku.fi> --- It is not my intention to edit multiple rows. I just want to be able to switch edit rows without issues. Step by step based on sandbox patron categories and itemtypes: 1. Create rules for all itemtypes and patron category all. 2. Create rules for all itemtypes and patron category patron. 3. Select rule for patron category and itemtype books (patron_books) for editing. 4. Select rule all_music for editing. Notice that on the edit row patron category stays as patron. 5. Select rule all_maps for editing. Notice that on the edit row patron category stays as patron. 6. Select rule all_music for editing. Notice that on the edit row patron category stays as patron and item type stays as maps. 7. Select rule patron_books for editing. Notice that on the edit row patron category stays as patron and item type stays as maps. 8. Check edit row item type column select element options with browser inspect. Notice that multiple option values have selected attribute. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34826 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34826 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- I believe this is a same problem which was discovered in bug 34585. I wrote second patch "Bug 34585: Fix behaviour of select dropdowns when editing circulation rules" to fix this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34826 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34585 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34826 --- Comment #5 from Mikko Liimatainen <mikko.liimatainen@turku.fi> --- (In reply to Emmi Takkinen from comment #4)
I believe this is a same problem which was discovered in bug 34585. I wrote second patch "Bug 34585: Fix behaviour of select dropdowns when editing circulation rules" to fix this.
Yes this is about those persisting selected attributes and that patch seems to correct the issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org