[Bug 41113] New: Missing doc-head-close and cssinclude in sci-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 Bug ID: 41113 Summary: Missing doc-head-close and cssinclude in sci-main.tt Initiative type: --- Sponsorship Sponsored status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: aleisha@catalyst.net.nz, alexbuckley@catalyst.net.nz, dcook@prosentient.com.au, hammat.wele@inlibro.com, lucas@bywatersolutions.com, testopia@bugs.koha-community.org +++ This bug was initially created as a clone of Bug #21266 +++ Many of the some changes should be made to the self checkin templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |minor Depends on| |41144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 [Bug 41144] Fix markup errors in self checkout and self checkin templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188669&action=edit Bug 41113: Missing doc-head-close and cssinclude in sci-main.tt This patch makes changes to the self checkin template in order to replace inline markup with doc-head-close.inc. A cssinclude BLOCK is added for the inclusion of SelfCheckInUserCSS. To test you must have the SelfCheckInModule system preference enabled. - In the staff client, add a link to a custom stylesheet in the OpacAdditionalStylesheet system preference. For example: https://static.myacpl.org/public/css/test.css - Go to the self-checkin page and confirm that the page background is now blue. - Empty the OpacAdditionalStylesheet preference and add custom CSS to the SelfCheckInUserCSS preference. - Reload the self checkin page to confirm that your CSS has been applied. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I had a go at testing, but I couldn't get it to work for me: 1. For step 3, I emptied OpacAdditionalStylesheet and reloaded the page - it turned back to normal (without the light blue background). 2. I added the same CSS to SelfCheckInUserCSS, and refreshed the page (I also deleted the cache and restarted everything) - the background remained normal, not the light blue. 3. The CSS is the page source (I added a comment just to make sure): <!-- SelfCheckInUserCSS --> <style>/* This is a comment */ body { background-color: #7bbbff; } </style> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 Bug 41113 depends on bug 41144, which changed state. Bug 41144 Summary: Fix markup errors in self checkout and self checkin templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21266 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|41144 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 [Bug 41144] Fix markup errors in self checkout and self checkin templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188669|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 206601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206601&action=edit Bug 41113: Missing doc-head-close and cssinclude in sci-main.tt This patch makes changes to the self checkin template in order to replace inline markup with doc-head-close.inc. A cssinclude BLOCK is added for the inclusion of SelfCheckInUserCSS. The patches also make some corrections to markup for validity. To test you must have the SelfCheckInModule system preference enabled. - In the staff client, add a link to a custom stylesheet in the OpacAdditionalStylesheet system preference. For example: https://static.myacpl.org/public/css/test.css - Go to the self-checkin page and confirm that the page background is now blue. - Empty the OpacAdditionalStylesheet preference and add custom CSS to the SelfCheckInUserCSS preference. - Reload the self checkin page to confirm that your CSS has been applied. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206601|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 206946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206946&action=edit Bug 41113: Missing doc-head-close and cssinclude in sci-main.tt This patch makes changes to the self checkin template in order to replace inline markup with doc-head-close.inc. A cssinclude BLOCK is added for the inclusion of SelfCheckInUserCSS. The patches also make some corrections to markup for validity. To test you must have the SelfCheckInModule system preference enabled. - In the staff client, add a link to a custom stylesheet in the OpacAdditionalStylesheet system preference. For example: https://static.myacpl.org/public/css/test.css - Go to the self-checkin page and confirm that the page background is now blue. - Empty the OpacAdditionalStylesheet preference and add custom CSS to the SelfCheckInUserCSS preference. - Reload the self checkin page to confirm that your CSS has been applied. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Go to the self-checkin page/reload page (otherwise custom CSS doesn't show): log in as koha koha 2. Custom CSS for SelfCheckInUserCSS: body { background-color: #ff0000; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org