[Bug 23787] New: AUTO_RENEWALS is not in sample_notices.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Bug ID: 23787 Summary: AUTO_RENEWALS is not in sample_notices.sql Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org I wanted to translate the AUTO_RENEWALS notice, but it's not in the sample_notices.sql. It is only in the updatedatabase.pl Martin confirmed on IRC that it should be in both. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AUTO_RENEWALS is not in |Add AUTO_RENEWALS in |sample_notices.sql |sample_notices.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 93937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93937&action=edit Bug 23787: Add AUTO_RENEWALS in sample_notices.sql This patch adds the AUTO_RENEWALS notice SQL insert query that was only available in the updatedatabase script into all the language-specific sample_notices.sql files in the installer (de-DE, en, es-ES, fr-CA, fr-FR, nb-NO, pl-PL, ru-RU, uk-UA). To test, make a fresh install in a language listed above, do NOT run updatedatabase, make sure the AUTO_RENEWALS is in the available notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I simply copied the INSERT query into all the files. I hope that's okay. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23789 [Bug 23789] fr-CA translation of AUTO_RENEWALS notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 [Bug 18532] AUTO_RENEWALS should be a patron messaging preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io --- Comment #3 from Agustín Moyano <agustinmoyano@theke.io> --- Hello Caroline, I believe you should add a script in atomicupdate that inserts this notice in letter table. AUTO_RENEWALS in updatedatabase.pl is inserted in version $DBversion = '16.12.00.035', so if someone has a version after that, they won't have that notice in the database. There you should make an "insert ignore" just in case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 2 things: When you run xt/sample_noticed.t you can see that it-IT is missing. I am adding it in a follow up. But another thing: The notice states twice... "The following item...", but there is no item information in the sample text. Should we add something? Also I'd like to make the subject a bit more patron friendly, maybe "Automatic renewals on your account" or similar? And "notification" would be nicer as "Notification". I can help with the updatedatabase if necessary! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94968&action=edit Bug 23787: Add AUTO_RENEWALS to it-IT installer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24378 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm editing the wording of this notice in updatedatabse over in Bug 24378. The English version has some grammatical errors and other issues. We should make sure those changes get reflected in both places. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|caroline.cyr-la-rose@inlibr |andrew@bywatersolutions.com |o.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93937|0 |1 is obsolete| | Attachment #94968|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100418&action=edit Bug 23787: Add AUTO_RENEWALS in sample_notices.sql This patch adds the AUTO_RENEWALS notice SQL insert query that was only available in the updatedatabase script into all the language-specific sample_notices.sql files in the installer (de-DE, en, es-ES, fr-CA, fr-FR, it-IT, nb-NO, pl-PL, ru-RU, uk-UA). To test, make a fresh install in a language listed above, do NOT run updatedatabase, make sure the AUTO_RENEWALS is in the available notices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Updated Caroline's work to reflect wording changes I made over in bug 24378, folded it-IT and atomicupdate all into one patch. Fingers crossed I didn't mess it up! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- Patch doesn't apply: Applying: Bug 23787: Add AUTO_RENEWALS in sample_notices.sql Using index info to reconstruct a base tree... A installer/data/mysql/en/mandatory/sample_notices.sql Falling back to patching base and 3-way merge... CONFLICT (modify/delete): installer/data/mysql/en/mandatory/sample_notices.sql deleted in HEAD and modified in Bug 23787: Add AUTO_RENEWALS in sample_notices.sql. Version Bug 23787: Add AUTO_RENEWALS in sample_notices.sql of installer/data/mysql/en/mandatory/sample_notices.sql left in tree. error: Failed to merge in the changes. Patch failed at 0001 Bug 23787: Add AUTO_RENEWALS in sample_notices.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Learned an important lesson about grabbing the latest version of master before writing a patch. Will try to get back to this today. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100418|0 |1 is obsolete| | --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100486&action=edit Bug 23787: add AUTO_RENEWALS to sample_notices To test: - create a new install - confirm presence of auto renewal notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Adapted to new yaml format. It's my understanding that means one need not copy the notice into all the separate languages, so I only put it in the one yaml file. Please let me know if I'm mistaken in that. Thaanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100486|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 100526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100526&action=edit Bug 23787: Add AUTO_RENEWALS to sample_notices To test: - create a new install - confirm presence of auto renewal notice Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- You should insert the template notice for existing installs only if it does not exist yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #14)
You should insert the template notice for existing installs only if it does not exist yet.
I would recommend against adding the notice to existing installations. If you are using auto renewals they will be activated immediately. It might come as an unwanted surprise to libraries that have deleted it on purpose as they don't want to use it. (it seems we added it before, but might still want to handle this differently here?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100526|0 |1 is obsolete| | --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102731&action=edit Bug 23787: add AUTO_RENEWALS to sample_notices Removed the atomicupdate so we're not adding this to existing installs. To test: - create a new install - confirm presence of auto renewal notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24378 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 [Bug 24378] Change wording on AUTO_RENEWALS notice in updatedatabase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102829&action=edit Bug 23787: Add AUTO_RENEWALS to sample_notices To test: - create a new English (en) install - confirm presence of auto renewal notice Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102830&action=edit Bug 23787: Add sample AUTO_RENEWALS notice to translatd installers This adds the default auto renewal notice to the translated installers. Translating will be handled by maintainers of the installers, but this way we don't end up with installations having a different set of notices than others. To test: - Verify the sample_notices.sql files load correctly or - Run the web installer for each of those languages and verify sample_notices loads correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102831&action=edit Bug 23787: Add AUTO_RENEALS sample notice to es-ES installer Keeping this one separate as there is another bug to move es-ES to use the new .yml based tanslation process. This way this patch could be dropped easily if the other bug makes it in first. Test plan of second patch applies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102731|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, Signed off on your patch and made follow-ups for the translated installers. Could you maybe sign-off on those? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102830|0 |1 is obsolete| | --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102868&action=edit Bug 23787: Add sample AUTO_RENEWALS notice to translatd installers This adds the default auto renewal notice to the translated installers. Translating will be handled by maintainers of the installers, but this way we don't end up with installations having a different set of notices than others. To test: - Verify the sample_notices.sql files load correctly or - Run the web installer for each of those languages and verify sample_notices loads correctly. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102831|0 |1 is obsolete| | --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102869&action=edit Bug 23787: Add AUTO_RENEALS sample notice to es-ES installer Keeping this one separate as there is another bug to move es-ES to use the new .yml based tanslation process. This way this patch could be dropped easily if the other bug makes it in first. Test plan of second patch applies. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Signed off. Thanks, Katrin! Learned some stuff about making different languages go in Koha :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please double check, using 'en', I see \' when editing the letter: It\'s too late to renew this item. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102829|0 |1 is obsolete| | --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 103763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103763&action=edit Bug 23787: Add AUTO_RENEWALS to sample_notices Removed "\" from "It\'s too late..." -- apparently that doesn't need to get escaped in YAML To test: - create a new English (en) install - confirm presence of auto renewal notice Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Don't we want the date to be formatted as a due date? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102869|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wanted to fix this, but I can't get the AUTO_RENEWAL notice to generate :( I was not sure if it was enough to add: ... | $KohaDates as_due_date => 1 %] or if it would also need: [%- USE KohaDates -%] I our sample notices library we have both versions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It works for me The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due | $KohaDates as_due_date => 1 %] You don't need the USE KohaDates (it's included by default). However, I am wondering: it is not possible to have the time part after a renewal, 23:59 is always set. That sounds like a bug, right? - due date is yesterday at 12:34, renew it, it become another day at 23:59 (with or without auto renewal). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure it's a bug - it would probably require that you define your circ rules in hours instead of days - but not sure if we support "hourly renewal" at all yet. What did you set up to get the notice? I had: - Set up the notice - Checked out several items with different due dates today and in the past - Put a hold on one (to prevent auto_renewal) - Ran the job... no notice, but renewals took place for some of my items as expected Patron had an email address. Are any of the messaging settings involved? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Did you pass --send-notices to the script? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #30)
Did you pass --send-notices to the script?
Nope! I'll try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104385&action=edit Bug 23787: (follow-up) Format due date as due date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102868|0 |1 is obsolete| | Attachment #103763|0 |1 is obsolete| | Attachment #104385|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104675&action=edit Bug 23787: Add sample AUTO_RENEWALS notice to translatd installers This adds the default auto renewal notice to the translated installers. Translating will be handled by maintainers of the installers, but this way we don't end up with installations having a different set of notices than others. To test: - Verify the sample_notices.sql files load correctly or - Run the web installer for each of those languages and verify sample_notices loads correctly. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104676&action=edit Bug 23787: Add AUTO_RENEWALS to sample_notices Removed "\" from "It\'s too late..." -- apparently that doesn't need to get escaped in YAML To test: - create a new English (en) install - confirm presence of auto renewal notice Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104677&action=edit Bug 23787: (follow-up) Format due date as due date Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #37 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x ...because yaml. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org