https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 --- Comment #1 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 99429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99429&action=edit Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be detected and highlighted (green). To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the delimiter the space and delimiter should be highlighted green. - Remove the extra space and confirm that the highlight disappears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I totally agree with the idea of this, I am just wondering if the green highlighting works in terms of usability (easy to understand, what the problem is as green is usually a 'good thing') I wonder if some red underlining would work better, thinking about how text processors like Word inform you of things to fix. Adding Owen for an additional opinion. (Don't be scared by status change, I will come back to this!) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com --- Comment #6 from Lisette Scheer <lisetteslatah@gmail.com> --- I agree with Katrin that green so often means good that it would be confusing. I checked in word and libreoffice and they both did blue underline for grammar errors. Maybe a blue highlight or underline would work here as well? Lisette -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 --- Comment #8 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 100080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100080&action=edit Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be detected and highlighted (green). To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the delimiter the space and delimiter should be highlighted green. - Remove the extra space and confirm that the highlight disappears. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99444|0 |1 is obsolete| | --- Comment #9 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 100081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100081&action=edit Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be detected and highlighted (green). To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the delimiter the space and delimiter should be highlighted green. - Remove the extra space and confirm that the highlight disappears. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100081|0 |1 is obsolete| | --- Comment #11 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 100082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100082&action=edit Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be surrounded by a red dotted border. To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the **delimiter the space and delimiter should be surrounded by a red dotted border. - Remove the extra space and confirm that the red dotted border is removed **To create a delimiter in the advanced editor, go to a non-control field (after 010) and hit the control button with the letter "d" then enter any letter or single digit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100082|0 |1 is obsolete| | --- Comment #13 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 114079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114079&action=edit Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be surrounded by an orange dotted border. To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the **delimiter the space and delimiter should be surrounded by a red dotted border. - Remove the extra space and confirm that the red dotted border is removed **To create a delimiter in the advanced editor, go to a non-control field (after 010) and hit the control button with the letter "d" then enter any letter or single digit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114080|1 |0 is patch| | Attachment #114080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #16 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- My test produced the orange dotted border for some subfields but not all of them. For instance, it did not work for the subfield 'a' of a 100 or 245 tag. Also, it did not work when a tag had only one subfield and it was not subfield 'a'. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.