[Bug 30114] New: Koha offline circulation will always cancel the next hold when issuing item to a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Bug ID: 30114 Summary: Koha offline circulation will always cancel the next hold when issuing item to a patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If a record has holds on it, and, using offline circulation, an item on that is checked out to a patron that did not have a hold on the record, the next hold that would have trapped that item will be canceled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 130631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130631&action=edit Bug 30114: Koha offline circulation will always cancel the next hold when issuing item to a patron If a record has holds on it, and, using offline circulation, an item on that is checked out to a patron that did not have a hold on the record, the next hold that would have trapped that item will be canceled. 1) Place two bib level holds on an item for two patrons 2) Find a third patron, note his or her cardnumber 3) Create the file test.koc by copying and pasting the following into a text editor Version=1.0 Generator=kocTest GeneratorVersion=0.7 2008-06-11 12:24:11 547 issue PATRONCARDNUMBER ITEMBARCODE note the fields are tab delemited, ensure the tabs do not get lost when copying and pasting! 4) Upload the offline circ action, and commit the action 5) Note the item was checked out to the third patron 6) Note one of the other patron's holds were canceled 7) Reset your database 8) Apply this patch 9) Test again, no hold should be canceled! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130631|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130669&action=edit Bug 30114: Koha offline circulation will always cancel the next hold when issuing item to a patron If a record has holds on it, and, using offline circulation, an item on that is checked out to a patron that did not have a hold on the record, the next hold that would have trapped that item will be canceled. 1) Place two bib level holds on an item for two patrons 2) Find a third patron, note his or her cardnumber 3) Create the file test.koc by copying and pasting the following into a text editor Version=1.0 Generator=kocTest GeneratorVersion=0.7 2008-06-11 12:24:11 547 issue PATRONCARDNUMBER ITEMBARCODE note the fields are tab delemited, ensure the tabs do not get lost when copying and pasting! 4) Upload the offline circ action, and commit the action 5) Note the item was checked out to the third patron 6) Note one of the other patron's holds were canceled 7) Reset your database 8) Apply this patch 9) Test again, no hold should be canceled! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130669|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131033&action=edit Bug 30114: Koha offline circulation will always cancel the next hold when issuing item to a patron If a record has holds on it, and, using offline circulation, an item on that is checked out to a patron that did not have a hold on the record, the next hold that would have trapped that item will be canceled. 1) Place two bib level holds on an item for two patrons 2) Find a third patron, note his or her cardnumber 3) Create the file test.koc by copying and pasting the following into a text editor Version=1.0 Generator=kocTest GeneratorVersion=0.7 2008-06-11 12:24:11 547 issue PATRONCARDNUMBER ITEMBARCODE note the fields are tab delemited, ensure the tabs do not get lost when copying and pasting! 4) Upload the offline circ action, and commit the action 5) Note the item was checked out to the third patron 6) Note one of the other patron's holds were canceled 7) Reset your database 8) Apply this patch 9) Test again, no hold should be canceled! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I would love to see a unit test for this.. but it appears we don't have any unit tests at all for the Offline methods (other than payment). Any chance of adding a simple test for this Kyle? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131033|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 131440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131440&action=edit Bug 30114: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 131441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131441&action=edit Bug 30114: Koha offline circulation will always cancel the next hold when issuing item to a patron If a record has holds on it, and, using offline circulation, an item on that is checked out to a patron that did not have a hold on the record, the next hold that would have trapped that item will be canceled. 1) Place two bib level holds on an item for two patrons 2) Find a third patron, note his or her cardnumber 3) Create the file test.koc by copying and pasting the following into a text editor Version=1.0 Generator=kocTest GeneratorVersion=0.7 2008-06-11 12:24:11 547 issue PATRONCARDNUMBER ITEMBARCODE note the fields are tab delemited, ensure the tabs do not get lost when copying and pasting! 4) Upload the offline circ action, and commit the action 5) Note the item was checked out to the third patron 6) Note one of the other patron's holds were canceled 7) Reset your database 8) Apply this patch 9) Test again, no hold should be canceled! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131440|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132190&action=edit Bug 30114: Add Unit Tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131441|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132191&action=edit Bug 30114: Koha offline circulation will always cancel the next hold when issuing item to a patron If a record has holds on it, and, using offline circulation, an item on that is checked out to a patron that did not have a hold on the record, the next hold that would have trapped that item will be canceled. 1) Place two bib level holds on an item for two patrons 2) Find a third patron, note his or her cardnumber 3) Create the file test.koc by copying and pasting the following into a text editor Version=1.0 Generator=kocTest GeneratorVersion=0.7 2008-06-11 12:24:11 547 issue PATRONCARDNUMBER ITEMBARCODE note the fields are tab delemited, ensure the tabs do not get lost when copying and pasting! 4) Upload the offline circ action, and commit the action 5) Note the item was checked out to the third patron 6) Note one of the other patron's holds were canceled 7) Reset your database 8) Apply this patch 9) Test again, no hold should be canceled! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ooops, I forgot to revisit this. Awesome.. you added a unit test! PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.05 released in| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org