http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10871 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10871 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This doesn't work for me, and I think we've seen this before. If you have the _() function inside an onclick attribute it doesn't work. One solution is to define a variable to pass to the function. Example in virtualshelves/shelves.tt (line 618): <input type="submit" class="deleteshelf" onclick="return confirmDelete(MSG_CONFIRM_DELETE_LIST);" value="Delete" /> The other solution would be to move everything into a <script> block and define the onsubmit behavior there. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10871 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- My fault, sorry Owen! I will try to fix. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10871 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20971|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20997&action=edit Bug 10871: Make confirmation message for deleting news translatable To test: - Create a news entry in tools > news - Delete the news entry or multiple entries by selecting them using the checkboxes to the left and the delete button at the bottom of the page. Verify confirmation message shows up correctly with patch applied. Bonus: - Update one of the po files and make sure the new strings shows up there. Thx Owen! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10871 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20997|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 21126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21126&action=edit [SIGNED-OFF] Bug 10871: Make confirmation message for deleting news translatable To test: - Create a news entry in tools > news - Delete the news entry or multiple entries by selecting them using the checkboxes to the left and the delete button at the bottom of the page. Verify confirmation message shows up correctly with patch applied. Bonus: - Update one of the po files and make sure the new strings shows up there. Thx Owen! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10871 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21126|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21228&action=edit Bug 10871: Make confirmation message for deleting news translatable To test: - Create a news entry in tools > news - Delete the news entry or multiple entries by selecting them using the checkboxes to the left and the delete button at the bottom of the page. Verify confirmation message shows up correctly with patch applied. Bonus: - Update one of the po files and make sure the new strings shows up there. Thx Owen! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10871 --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Er, rather, thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.