https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49661&action=edit Bug 16162: Making dictionary 'Delete' a button To test: 1) Go to Reports -> View dictionary 2) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button. 3) Confirm that the button does not wrap on narrower browsers. 4) Confirm that column heading is now 'Action'. 5) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Failed QA --- Comment #2 from Marc Véron <veron@veron.ch> --- QA tools complain: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt FAIL forbidden patterns forbidden pattern: tab char (line 82) forbidden pattern: tab char (line 71) forbidden pattern: tab char (line 79) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49661|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49713&action=edit Bug 16162: Making dictionary 'Delete' a button EDIT: This patch should have gotten rid of those tabs To test: 1) Go to Reports -> View dictionary 2) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button. 3) Confirm that the button does not wrap on narrower browsers. 4) Confirm that column heading is now 'Action'. 5) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16161 [Bug 16161] Add confirm message when deleting dictionary definition -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49715|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49748&action=edit Bug 16162: Making dictionary 'Delete' a button EDIT: This patch should have gotten rid of those tabs EDIT2: Will now apply with patch on Bug 16161 To test: 1) Apply Bug 16161 first 2) Go to Reports -> View dictionary 3) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button. 4) Confirm that the button does not wrap on narrower browsers. 5) Confirm that column heading is now 'Action'. 6) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.) Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49816|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49819&action=edit [PASSED QA] Bug 16162: Making dictionary 'Delete' a button EDIT: This patch should have gotten rid of those tabs EDIT2: Will now apply with patch on Bug 16161 To test: 1) Apply Bug 16161 first 2) Go to Reports -> View dictionary 3) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button. 4) Confirm that the button does not wrap on narrower browsers. 5) Confirm that column heading is now 'Action'. 6) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.) Sponsored-by: Catalyst IT Tested on top of Bug 16161 Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.