[Bug 18122] New: Audio alerts: Add hint on where to enable sounds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Bug ID: 18122 Summary: Audio alerts: Add hint on where to enable sounds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Add a hint to page Home > Administration > Audio alerts about where to enable the sound system (syspref 'AudioAlerts'). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Tools |System Administration CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 60246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60246&action=edit Bug 18122 - Audio alerts: Add hint on where to enable sounds This patch adds a hint to page Home > Administration > Audio alerts and related help page about where to enable the sound system (syspref 'AudioAlerts'). To test: - Apply patch - Disable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Note hint below title 'Audio alerts' - Enable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Hint is no longer visible (since audios are enabled) - Open Help page (top right) - Verify that hint on help page makes sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I think the hint on the audio alerts page should be in a <div class="dialog alert"></div> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60246|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 60536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60536&action=edit Bug 18122 - Audio alerts: Add hint on where to enable sounds This patch adds a hint to page Home > Administration > Audio alerts and related help page about where to enable the sound system (syspref 'AudioAlerts'). To test: - Apply patch - Disable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Note hint below title 'Audio alerts' - Enable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Hint is no longer visible (since audios are enabled) - Open Help page (top right) - Verify that hint on help page makes sense. Amended to add alert class as requested by comment #2 2017-02-21 mv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Wow! This is going to save some poor tired soul a lot of headaches. Good job. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60536|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 60571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60571&action=edit Bug 18122 - Audio alerts: Add hint on where to enable sounds This patch adds a hint to page Home > Administration > Audio alerts and related help page about where to enable the sound system (syspref 'AudioAlerts'). To test: - Apply patch - Disable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Note hint below title 'Audio alerts' - Enable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Hint is no longer visible (since audios are enabled) - Open Help page (top right) - Verify that hint on help page makes sense. Amended to add alert class as requested by comment #2 2017-02-21 mv Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60571|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60640&action=edit Bug 18122 - Audio alerts: Add hint on where to enable sounds This patch adds a hint to page Home > Administration > Audio alerts and related help page about where to enable the sound system (syspref 'AudioAlerts'). To test: - Apply patch - Disable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Note hint below title 'Audio alerts' - Enable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Hint is no longer visible (since audios are enabled) - Open Help page (top right) - Verify that hint on help page makes sense. Amended to add alert class as requested by comment #2 2017-02-21 mv Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Helpful string change - decided to push this although it's marked as enhancement. This patch has been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.11 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org