[Bug 40345] New: Missing Cypress tests for checkout history - OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Bug ID: 40345 Summary: Missing Cypress tests for checkout history - OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Change from bug 38102 must be covered by tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38102 Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38102 [Bug 38102] Checkout history in OPAC displaying more than 50 items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40346 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40346 [Bug 40346] Allow Cypress to test OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183974&action=edit Bug 40345: Pass a patron to insertSampleCheckout So we won't generate a new patron per checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183975&action=edit Bug 40345: Add insertSamplePatron So it's easier to build and insert a new patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183976&action=edit Bug 40345: Force checkout Pass the confirmation token to force the checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183977&action=edit Bug 40345: Add tests for bug 38102 Test plan: yarn cypress run --spec t/cypress/integration/KohaTable/OPACCirculationHistory_spec.ts must return green Revert commits from bug 38102 Run again the Cypress tests => They fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40301 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40301 [Bug 40301] Missing Cypress tests for 'Type' column visibility -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183979&action=edit Bug 40345: Properly cleanup old checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183974|0 |1 is obsolete| | Attachment #183975|0 |1 is obsolete| | Attachment #183976|0 |1 is obsolete| | Attachment #183977|0 |1 is obsolete| | Attachment #183979|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183983&action=edit Bug 40345: Pass a patron to insertSampleCheckout So we won't generate a new patron per checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183984&action=edit Bug 40345: Add insertSamplePatron So it's easier to build and insert a new patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183985&action=edit Bug 40345: Force checkout Pass the confirmation token to force the checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183986&action=edit Bug 40345: Add tests for bug 38102 Test plan: yarn cypress run --spec t/cypress/integration/KohaTable/OPACCirculationHistory_spec.ts must return green Revert commits from bug 38102 Run again the Cypress tests => They fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183987&action=edit Bug 40345: Properly cleanup old checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183988&action=edit Bug 40345: Use then to prevent async issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40430 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 [Bug 40430] Toolbar_spec.ts is failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183983|0 |1 is obsolete| | Attachment #183984|0 |1 is obsolete| | Attachment #183985|0 |1 is obsolete| | Attachment #183986|0 |1 is obsolete| | Attachment #183987|0 |1 is obsolete| | Attachment #183988|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184230&action=edit Bug 40345: Pass a patron to insertSampleCheckout So we won't generate a new patron per checkout Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184231&action=edit Bug 40345: Add insertSamplePatron So it's easier to build and insert a new patron Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184232&action=edit Bug 40345: Force checkout Pass the confirmation token to force the checkout Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184233&action=edit Bug 40345: Add tests for bug 38102 Test plan: yarn cypress run --spec t/cypress/integration/KohaTable/OPACCirculationHistory_spec.ts must return green Revert commits from bug 38102 Run again the Cypress tests => They fail Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184234&action=edit Bug 40345: Properly cleanup old checkouts Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184235&action=edit Bug 40345: Use then to prevent async issues Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184230|0 |1 is obsolete| | Attachment #184231|0 |1 is obsolete| | Attachment #184232|0 |1 is obsolete| | Attachment #184233|0 |1 is obsolete| | Attachment #184234|0 |1 is obsolete| | Attachment #184235|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184343&action=edit Bug 40345: Pass a patron to insertSampleCheckout So we won't generate a new patron per checkout Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184344&action=edit Bug 40345: Add insertSamplePatron So it's easier to build and insert a new patron Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184345&action=edit Bug 40345: Force checkout Pass the confirmation token to force the checkout Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184346&action=edit Bug 40345: Add tests for bug 38102 Test plan: yarn cypress run --spec t/cypress/integration/KohaTable/OPACCirculationHistory_spec.ts must return green Revert commits from bug 38102 Run again the Cypress tests => They fail Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184347&action=edit Bug 40345: Properly cleanup old checkouts Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184348&action=edit Bug 40345: Use then to prevent async issues Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 --- Comment #25 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- Dependencies not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Bug 40345 depends on bug 40301, which changed state. Bug 40301 Summary: Missing Cypress tests for 'Type' column visibility https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40301 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #27 from David Nind <david@davidnind.com> --- Test suite related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 Bug 40345 depends on bug 40346, which changed state. Bug 40346 Summary: Allow Cypress to test OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40346 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org