[Bug 13461] New: Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Bug ID: 13461 Summary: Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If RentalFeesCheckoutConfirmation system preference is activated, Koha will ask for confirmation for every checkout, even if there is no rental fine defined for the itemtype. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34383&action=edit Bug 13461 - Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used To test: - Check RentalFeesCheckoutConfirmation is activated - Try to check out an item without rental fine - Verify confirmation message without explanation is shown - Apply patch - Verify confirmation message is no longer shown - Configure itemtype to have rental fee - Veirfy now the confirmation message appears as it should -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34383|0 |1 is obsolete| | --- Comment #2 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34415&action=edit Bug 13461 - Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used I've applied the patch against 3.19.00.000 Everything is OK as required. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34415|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 34450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34450&action=edit [PASSED QA] Bug 13461 - Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used To test: - Check RentalFeesCheckoutConfirmation is activated - Try to check out an item without rental fine - Verify confirmation message without explanation is shown - Apply patch - Verify confirmation message is no longer shown - Configure itemtype to have rental fee - Veirfy now the confirmation message appears as it should Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, super trivial but super needed patch.. Passing QA Thanks Katrin :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pätch pushed to master. Gracias Katrina! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x, will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- (In reply to Chris Cormack from comment #6)
Pushed to 3.18.x, will be in 3.18.2
skipping patch for 3.16.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org