[Bug 40903] New: OPAC advanced search applies a location limit of the logged-in library by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Bug ID: 40903 Summary: OPAC advanced search applies a location limit of the logged-in library by default Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org This is caused by Bug 36742. It exists in main but starts in 24.11. The OPAC advanced search now automatically applies a limit to the 'Location and availability' section using the patron's logged in library, even if there are multiple libraries in the system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36742 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36742 [Bug 36742] Improve OPAC behavior for instances with only one library, including libraries page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- I confirm, will try to patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ohhh there is the arg "do_not_select_my_library => 1" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 188467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188467&action=edit Bug 40903: OPAC advanced search should not apply a limit of the logged-in library by default This is caused by Bug 36742. It exists in main but starts in 24.11. The OPAC advanced search now automatically applies a limit to the 'Location and availability' section using the patron's logged in library, even if there are multiple libraries in the system. 1) Go to OPAC 2) Authenticate with a user 3) Go to advanced search 4) Check there is no library selected in 'Location and availability' 5) Select a library and submit 6) Clik on 'Return to the last advanced search' 7) Check the library is selected in 'Location and availability' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- I'm a bit confused... This behaviour does not seem related to bug 36742. Rather, it's been a standard part of Koha for a very long time? Like the code has been part of Koha/Template/Plugin/Branches.pm for about 10 years and before that I think it was in C4/Branches.pm? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- A library was upgraded from 22.11 to 24.11 so they complained about this change. I'v checked 22.11 and 23.11, I see there is no default library limit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ahhh the code before 24.11 was calling : [% FOREACH BranchesLoo IN Branches.all( selected => opac_name ) %] 'opac_name' comming from C4::Auth and depending on system preference 'SearchMyLibraryFirst'. So we must use the same 'selected' I bet. And add system preference 'SearchMyLibraryFirst' to the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188467|0 |1 is obsolete| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 188501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188501&action=edit Bug 40903: Fix OPAC advanced search applies a limit of the logged-in library by default This is caused by Bug 36742. It exists in main but starts in 24.11. The OPAC advanced search now automatically applies a limit to the 'Location and availability' section using the patron's logged in library, even if there are multiple libraries in the system. This feature must be depending on system preference 'SearchMyLibraryFirst'. 1) Set system preference 'SearchMyLibraryFirst' to 'Don't limit' 2) Go to OPAC 3) Authenticate with a user 4) Go to advanced search 5) Check there is no library selected in 'Location and availability' 6) Select a library and submit 7) Clik on 'Return to the last advanced search' 8) Check the library is selected in 'Location and availability' 9) Set system preference 'SearchMyLibraryFirst' to 'Limit' 10) Go to OPAC 11) Authenticate with a user 12) Go to advanced search 13) Check library of patron selected in 'Location and availability' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188501|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 188527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188527&action=edit Bug 40903: Fix OPAC advanced search applies a limit of the logged-in library by default This is caused by Bug 36742. It exists in main but starts in 24.11. The OPAC advanced search now automatically applies a limit to the 'Location and availability' section using the patron's logged in library, even if there are multiple libraries in the system. This feature must be depending on system preference 'SearchMyLibraryFirst'. 1) Set system preference 'SearchMyLibraryFirst' to 'Don't limit' 2) Go to OPAC 3) Authenticate with a user 4) Go to advanced search 5) Check there is no library selected in 'Location and availability' 6) Select a library and submit 7) Clik on 'Return to the last advanced search' 8) Check the library is selected in 'Location and availability' 9) Set system preference 'SearchMyLibraryFirst' to 'Limit' 10) Go to OPAC 11) Authenticate with a user 12) Go to advanced search 13) Check library of patron selected in 'Location and availability' Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #6)
Ahhh the code before 24.11 was calling : [% FOREACH BranchesLoo IN Branches.all( selected => opac_name ) %] 'opac_name' comming from C4::Auth and depending on system preference 'SearchMyLibraryFirst'.
So we must use the same 'selected' I bet. And add system preference 'SearchMyLibraryFirst' to the test plan.
Ahh interesting. The older libraries I checked appear to be using SearchMyLibraryFirst, which is why it seemed like older versions worked the same way. Nice one, Frido! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Cook from comment #4)
I'm a bit confused...
This behaviour does not seem related to bug 36742.
For what it's worth, I had done a git cherry-pick which narrowed this behaviour down to the patch from Bug 36742! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Aleisha Amohia from comment #10)
(In reply to David Cook from comment #4)
I'm a bit confused...
This behaviour does not seem related to bug 36742.
For what it's worth, I had done a git cherry-pick which narrowed this behaviour down to the patch from Bug 36742!
My bad! I think I must've misread bug 36742 as well, as I think it ends up doing the thing is says it doesn't want to do in the description. Oh well... I'll have a crack at QAing this shortly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188527|0 |1 is obsolete| | --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Created attachment 188536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188536&action=edit Bug 40903: Fix OPAC advanced search applies a limit of the logged-in library by default This is caused by Bug 36742. It exists in main but starts in 24.11. The OPAC advanced search now automatically applies a limit to the 'Location and availability' section using the patron's logged in library, even if there are multiple libraries in the system. This feature must be depending on system preference 'SearchMyLibraryFirst'. 1) Set system preference 'SearchMyLibraryFirst' to 'Don't limit' 2) Go to OPAC 3) Authenticate with a user 4) Go to advanced search 5) Check there is no library selected in 'Location and availability' 6) Select a library and submit 7) Clik on 'Return to the last advanced search' 8) Check the library is selected in 'Location and availability' 9) Set system preference 'SearchMyLibraryFirst' to 'Limit' 10) Go to OPAC 11) Authenticate with a user 12) Go to advanced search 13) Check library of patron selected in 'Location and availability' Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.06 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.06 |25.11.00,25.05.06,24.11.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40903 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org