[Bug 10994] New: Email sending is not working in claim notice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Bug ID: 10994 Summary: Email sending is not working in claim notice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: amitddng135@gmail.com QA Contact: testopia@bugs.koha-community.org
From address is null acquisitions claim and serial notice.
my $userenv = C4::Context->userenv; $userenv->{emailaddress} -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |amitddng135@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 --- Comment #1 from Amit <amitddng135@gmail.com> --- (In reply to Amit from comment #0)
From address is null acquisitions claim and serial notice.
my $userenv = C4::Context->userenv; $userenv->{emailaddress}
From address contain null value in acquisitions claim and serial notice. my $userenv = C4::Context->userenv; $userenv->{emailaddress}
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It has worked nicely for me in the past - does your staff user have an email address? I agree that it's unusual for Koha to use the staff patron's email address, so maybe this should only be an option and not the default. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 --- Comment #3 from Amit <amitddng135@gmail.com> --- Hi Katrin, Yes if staff have an email address claim notice is working fine. But this is not a correct behavior. If we modify the code then it will not check whether staff have email address or not. my $email_address = $userenv->{'branchemail'} || C4::Context->preference('KohaAdminEmailAddress'); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com --- Comment #4 from Amit <amitddng135@gmail.com> --- Created attachment 21841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21841&action=edit Email sending is not working in claim notice Email sending is not working in claim notice. This patch will not check whether staff patron's email address or not for sending claim notices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-10-28 last check this| | --- Comment #5 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21841|0 |1 is patch| | Attachment #21841|application/mbox |text/plain mime type| | CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- This is changing existing behaviour, with no warning, and no option to keep existing behaviour. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|In Discussion |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Amit, do you plan to work again on this one? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 --- Comment #8 from Amit <amitddng135@gmail.com> --- Hi Jonathan Druart, Yes i have plan will recreate and submit the patch again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Email sending is not |Allow use of |working in claim notice |branch/kohaAdmin e-mail | |address for sending claim | |notices --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As Chris pointed out, we can't change behaviour without warning - best would be to make this optional. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 --- Comment #10 from Amit <amitddng135@gmail.com> --- Thanks Chris & Katrin for suggestion. I will rework & create this feature as a system preference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5770 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org