[Bug 33437] New: Use template wrapper for breadcrumbs: Reports part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Bug ID: 33437 Summary: Use template wrapper for breadcrumbs: Reports part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more reports templates so that they use the new template wrapper for breadcrumbs. - reports/cat_issues_top.tt - reports/catalogue_out.tt - reports/catalogue_stats.tt - reports/dictionary.tt - reports/guided_reports_start.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 149764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149764&action=edit Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Most circulated items - Report results - Items with no checkouts - Report results - Catalog statistics wizard - Report results - View dictionary - New definition (steps 1-5) - Saved reports - View report - New report - Edit report - Guided reports - Build a report - Steps 1 through 6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrew.auld@ptfs-europe.com --- Comment #2 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Hi Owen, I have found a couple of issues with this patch. Firstly, I can't test the 'Items with no checkouts' results page as I am getting an error on the sandbox when I hit 'Submit': CGI::Compile::ROOT::kohadevbox_koha_reports_catalogue_out_2epl::calculate(): DBI Exception: DBD::mysql::st execute failed: 'koha_bugs.items.barcode' isn't in GROUP BY at /kohadevbox/koha/reports/catalogue_out.pl line 51 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Secondly, under saved reports and in the guided reports wizard area, there are a number of pages where the breadcrumb doesn't show as it should I don't think. I have attached a number of screenshots to show what I mean. Steps 1 through 6 of the wizard are all fine. I think it is the 'edit report' screen, the 'run report' screen and the 'view report' screen that are not quite right. All other parts of the test plan work fine. I hope this is helpful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #3 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Created attachment 149809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149809&action=edit Edit report breadcrumb error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #4 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Created attachment 149810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149810&action=edit Run report breadcrumb error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #5 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Created attachment 149811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149811&action=edit View report breadcrumb error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149764|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 149867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149867&action=edit Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Most circulated items - Report results - Items with no checkouts - Report results - Catalog statistics wizard - Report results - View dictionary - New definition (steps 1-5) - Saved reports - View report - New report - Edit report - Guided reports - Build a report - Steps 1 through 6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #7 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Hi Owen, I have tested the guided reports screens and the breadcrumbs now look and behave as they should. Thank you. I still can't run the 'Items with no checkouts' report to get to the results page. This may well be user error rather than anything to do with your patch. But it does mean I haven't been able to test the Report results page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Andrew Auld from comment #7)
I still can't run the 'Items with no checkouts' report to get to the results page.
Ah right, sorry I didn't comment on that issue. That seems to be a bug related to strict_sql_modes and can't be worked around unless you have access to koha-conf.xml -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149867|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 150171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150171&action=edit Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Most circulated items - Report results - Items with no checkouts - Report results - Catalog statistics wizard - Report results - View dictionary - New definition (steps 1-5) - Saved reports - View report - New report - Edit report - Guided reports - Build a report - Steps 1 through 6 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #10 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. To turn off the strict database mode: - Edit /etc/koha/sites/kohadev/koha-conf.xml - Change strict_sql_modes from 1 to 0 (is right near the end of the file): <strict_sql_modes>0</strict_sql_modes> - flush_memcached and restart_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150171|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150423&action=edit Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Most circulated items - Report results - Items with no checkouts - Report results - Catalog statistics wizard - Report results - View dictionary - New definition (steps 1-5) - Saved reports - View report - New report - Edit report - Guided reports - Build a report - Steps 1 through 6 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org