[Bug 18036] New: Improve test coverage for themelanguage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Bug ID: 18036 Summary: Improve test coverage for themelanguage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: m.de.rooy@rijksmuseum.nl QA Contact: gmcharlt@gmail.com See bug 17982 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 [Bug 17982] Fix the use of uniq in sub themelanguage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59767&action=edit Bug 18036: Improve test coverage for themelanguage This test triggers the three cases that were modified. prove -v t/db_dependent/Templates.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Saved a kitten for you, Mark. But still needs some polishing.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Marcel de Rooy from comment #2)
Saved a kitten for you, Mark. But still needs some polishing..
Thanks, I'll wait for bug 17982 to get pushed, then rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59818&action=edit Bug 18036: Perlcritic improve t/db_dependent/Templates.t TEST PLAN --------- 1) apply 17982 2) perlcritic -3 t/db_dependent/Templates.t -- messages 3) apply this patch 4) perlcritic -3 t/db_dependent/Templates.t -- OK 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59767|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59819&action=edit Bug 18036: All 4 cases tested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59820&action=edit Proof that all 4 cases are triggered. Do not push! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Thanks for the rescue, Marcel, but I was so focused on non-en, that I forgot I was just trying to trigger the first case. Why complicate things, when simple works? DO NOT PUSH the proof patch. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Why not leave this test: cmp_deeply( ( C4::Templates::themelanguage( C4::Context->config('intrahtdocs'), 'about.tt' , 'intranet', 'fake_cgi' ) )[2], [ 'prog' ], 'We only expect one prog here' ); The other tests do not touch the returned themes,, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Marcel de Rooy from comment #8)
Why not leave this test: cmp_deeply( ( C4::Templates::themelanguage( C4::Context->config('intrahtdocs'), 'about.tt' , 'intranet', 'fake_cgi' ) )[2], [ 'prog' ], 'We only expect one prog here' );
The other tests do not touch the returned themes,,
Oops... Good point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59821&action=edit Bug 18036: Replace accidentally deleted test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59822&action=edit Bug 18036: Full complement of testing Added theme, lang, and availablethemes tests for all 4 cases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59819|0 |1 is obsolete| | Attachment #59821|0 |1 is obsolete| | Attachment #59822|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59823&action=edit Bug 18036: All 4 cases tested Added theme, lang, and availablethemes tests for all 4 cases. Previously just availablethemes was tested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59820|0 |1 is obsolete| | --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59824&action=edit Proof that all 4 cases are triggered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59825&action=edit Bug 18036: Followup If you have the proof applied, do not apply this. If you do not have the proof applied, apply this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59823|0 |1 is obsolete| | Attachment #59825|0 |1 is obsolete| | --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59838&action=edit Bug 18036: All 4 cases tested Added theme, lang, and availablethemes tests for all 4 cases. Previously just availablethemes was tested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59824|0 |1 is obsolete| | --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59839&action=edit [DO NOT PUSH] Proof that all 4 cases are triggered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59839|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 59839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59839 [DO NOT PUSH] Proof that all 4 cases are triggered. Worked fine. Obsoleting it now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59818|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59843&action=edit Bug 18036: Perlcritic improve t/db_dependent/Templates.t TEST PLAN --------- 1) apply 17982 2) perlcritic -3 t/db_dependent/Templates.t -- messages 3) apply this patch 4) perlcritic -3 t/db_dependent/Templates.t -- OK 5) run koha qa test tools Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59838|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59844&action=edit Bug 18036: All 4 cases tested Added theme, lang, and availablethemes tests for all 4 cases. Previously just availablethemes was tested. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> The warns from Mark's additional patch showed all four cases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59845&action=edit Bug 18036: [QA Follow-up] Descriptions and mock_preference Adjusted a few test descriptions. The test depends on template being set to prog. Made that explicit by adding a mock_preference. If you change the mock to bootstrap, this test will fail. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Bug 18036 depends on bug 17982, which changed state. Bug 17982 Summary: Fix the use of uniq in sub themelanguage https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt@gmail.com | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59843|0 |1 is obsolete| | Attachment #59844|0 |1 is obsolete| | Attachment #59845|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60351&action=edit Bug 18036: Perlcritic improve t/db_dependent/Templates.t TEST PLAN --------- 1) apply 17982 2) perlcritic -3 t/db_dependent/Templates.t -- messages 3) apply this patch 4) perlcritic -3 t/db_dependent/Templates.t -- OK 5) run koha qa test tools Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60352&action=edit Bug 18036: All 4 cases tested Added theme, lang, and availablethemes tests for all 4 cases. Previously just availablethemes was tested. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> The warns from Mark's additional patch showed all four cases. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60353&action=edit Bug 18036: [QA Follow-up] Descriptions and mock_preference Adjusted a few test descriptions. The test depends on template being set to prog. Made that explicit by adding a mock_preference. If you change the mock to bootstrap, this test will fail. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Mark, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Marked as enh, but more tests... I was tempted, but this doesn't apply cleanly on 16.11.x for some reason. This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #26 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #25)
Marked as enh, but more tests... I was tempted, but this doesn't apply cleanly on 16.11.x for some reason.
Depends on 17892. I could rework for 16.11.x if you really want it. :)
This won't get ported back to 16.11.x as it is an enhancement.
But you are right this is an enhancement ... of tests. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's ok to leave out, but thx Mark. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org