[Bug 7997] New: can create a notice with the same code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Priority: P5 - low Change sponsored?: --- Bug ID: 7997 Assignee: henridamien@koha-fr.org Summary: can create a notice with the same code QA Contact: koha.sekjal@gmail.com Severity: major Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Notices Product: Koha When creating a new notice you can use a code that's in use already and when you save you overwrite the original notice. There is no warning there or block to stop you from doing this. If this is the intended behavior then we need a warning that says saving this will overwrite the original notice with this code - or we need a way to prevent creation of notices with the same code. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- I tried t reproduce the behaviour with Version 3.08.00.000 I tested with following steps: - Create 1st notice with code DOUBLETEST, insert some text, save - Create 2nd notice, use same code DOUBLETEST, insert other text, save In my case, the 2nd notice was silently discarded, the 1st notice was unchanged. This is consistent with the database: mysql> describe letter; +------------+--------------+------+-----+---------+-------+ | Field | Type | Null | Key | Default | Extra | +------------+--------------+------+-----+---------+-------+ | module | varchar(20) | NO | PRI | | | | code | varchar(20) | NO | PRI | | | | branchcode | varchar(10) | NO | PRI | | | | name | varchar(100) | NO | | | | | is_html | tinyint(1) | YES | | 0 | | | title | varchar(200) | NO | | | | | content | text | YES | | NULL | | +------------+--------------+------+-----+---------+-------+ To prevent frustrations, it would really be nice to have - at least a warning that the 2nd notice was not saved (and why) - or better have a mechanisme to pre-test or warn before saving (and go back to the form). Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- I tested on 3.8 by adding a new notice with ODUE as the code and the default ODUE notice was overwritten ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 --- Comment #3 from Marc Véron <veron@veron.ch> --- It seems to behave arbitrary. Testing: -------- I have: (All libraries) circulation ODUE Mahnung 11 I make a copy of ODUE for 'Centerville'. I give it the the values Centerville circulation ODUE Mahnung 11 Then Dropdown "Select a library"->Centerville. Then I create a "New Notice" with the values: Centerville circulation ODUE Mahnung 12 -> Both ODUE for '(All Libraries)' and for 'Centerville' are unchanged. Now I go back to the List "Centerville" I do "Copy" to Centerville and give the value Centerville circulation ODUE Copy from Centerville to Centreville -> Now the slip for 'Centerville' is silently overwritten. I choose "All libraries" Do "New Notice" with (All libraries) circulation ODUE Mahnung 13 ...and ODUE for All Libraries is silently ovewritten I do "New Notice" with values Centerville circulation ODUE Mahnung 13 Centerville circulation is still Centerville circulation ODUE Copy from Centerville to Centreville Fazit: ------ Sometimes it overwrites silently and sometimes it discards silently. Additional glitch: ------------------ With the form "Add Notice" I had the following strange behavior: - Select Dropdown "Centerville" - Do "New Notice" Form displays: Library: Centerville Koha module: Catalog -Now click in "Koha module" and choose "Circulation". Entry changes to "Circulation". - Now click in field "Code" and then on field "Name" Result: Entry of "Library" switches from "Centerville" to "All libraries" (!) (If you then change it to "Centerfield" again, it seems to be stable, the switch seems to be related to a newly opened form). If you are not aware that the value for "Libray" has changed and save, the Entry of "All libraries" is silently overwritten (as expected from behaviour above). Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- I think the solution is that regardless of branch the notice/slip code must be unique. That will prevent this kind of problem in all cases ... won't it? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 --- Comment #5 from Marc Véron <veron@veron.ch> --- Agree... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think that's not so easy to do as some letter codes are hardcoded. A combined primary key of branch and letter code might be easier here with proper checks in the template? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- Well I'd think that codes shouldn't be hardcoded ... instead a primary key should be used. But I'm up for anything that prevents this kind of thing from happening. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I did think that too a while back, but how would the system know which letter to use for a specific action? It would require something like a unique module for each... a module for holds, module for suggestions accepted... etc. I really think it's more a problem of how the form works here and that we need to check and warn. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- I agree, the form should check and warn, leaving it up to the db to catch the error, is the wrong solution -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 --- Comment #10 from Nicole C. Engard <nengard@gmail.com> --- Oh I agree with that 100% - the form should warn and check - but the DB should also have unique values that it uses. This would be another issue, but maybe a triggers type tool for all notices instead of just the overdues - that way the codes don't need to be hardcoded anymore. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 --- Comment #11 from Nicole C. Engard <nengard@gmail.com> --- Just want to nudge this - this is still happening in 3.8.2 - the notices are silently being deleted/failing to be added. This is pretty annoying. Any ideas on how to fix this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8259 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #12 from Nicole C. Engard <nengard@gmail.com> --- The way I understand it, the way things are now you can't have different notices for different branches ... this is a critical issue. Either the ability to create notices for different branches needs to be removed or the code fixed to look at the code/branch combo as a key, or make each notice have a unique key. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8258 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Derryn <derrynj@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |derrynj@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 --- Comment #13 from Marc Véron <veron@veron.ch> --- Still valid with 3.15.00.028 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 11931 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12741 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|can create a notice with |Can't create a notice with |the same code |the same code --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Updating the bug description a bit: The problem now is that we DON'T allow for duplicate letter codes and a check has been added in the template (bug 11742). But I think we forgot about the existence of the hardcoded letter codes - some of those are: - ACCTDETAULS - HOLD - Slip templates... So... I think we need to find a way to allow duplicates? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this needs to be fixed prior to release - sorry for missing the problem in testing earlier :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13215 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The problem has been fixed with bug 13215. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org