[Bug 10605] New: Problems with translated cart email sent from OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Bug ID: 10605 Summary: Problems with translated cart email sent from OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org I spotted some problems with sending cart emails from the OPAC: There is a problem with encoding, as the umlauts in the translated German message are broken. The first paragraph is repeated and the list of items is completely missing. I have seen this happening on 3.12.1 - would be glad if someone could test and confirm on their installation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 bondiurbano <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com --- Comment #1 from bondiurbano <costalc@gmail.com> --- Encoding problem also in 3.12.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 21428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21428&action=edit Proposed patch Suppress a double-encoding -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still seeing this in 3.12.6 - missed checking this bug again :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I haven't figured out why yet, but with the patch applied, my links from the cart email to the records in the OPAC are missing the biblionumber. On master it seems ok. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Frederic, could you take a look at the links? I am a bit puzzled why your patch would make a difference there. Example: In online catalog: http://localhost/cgi-bin/koha/opac-detail.pl?biblionumber= -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it might be the combination of = and a number that is doing it. I remember seeing problems with that somewhere else, but I can't find it now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Found this: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=696fc0ff22fac839... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Katrin: which email client are you using? For me, it works with Thunderbird and Gmail. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am using Thunderbird -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It could be something in the settings of course, but I think I am using pretty much the standard there. I noticed that I had to manually switch to utf-8 to make the umlauts show correctly as the automatic detection didn't seem to work - might be my settings or some deeper issue? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #11 from Frédéric Demians <frederic@tamil.fr> ---
It could be something in the settings of course, but I think I am using pretty much the standard there. I noticed that I had to manually switch to utf-8 to make the umlauts show correctly as the automatic detection didn't seem to work - might be my settings or some deeper issue?
You server mailer could be the culprit. Which SMTP server are you using? I conduct my tests on a Koha server that runs Exim4. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have to admit that I am not sure and can't check right now - someone else set up mailing for me on my laptop and I was happy to never have to touch it since. Maybe we can get some others testing this and compare results? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- My tests: Without the patch (on the master branch): Hum... the received mail is really weird: Bonjour, JOUBU vous a envoyé un panier de références extraites de notre catalogue. Notez que le fichier attaché est un fichier MARC, qui peut être importé dans un logiciel de gestion de bibliographie tel que EndNote, Reference Manager ou ProCite. --------------------------------------------------------------------- Bonjour, JOUBU vous a envoyé un panier de références extraites de notre catalogue. Notez que le fichier attaché est un fichier MARC, qui peut être importé dans un logiciel de gestion de bibliographie tel que EndNote, Reference Manager ou ProCite. --------------------------------------------------------------------- With the patch: Bonjour, JOUBU vous a envoyé un panier de références extraites de notre catalogue. Notez que le fichier attaché est un fichier MARC, qui peut être importé dans un logiciel de gestion de bibliographie tel que EndNote, Reference Manager ou ProCite. --------------------------------------------------------------------- un message personnalisé pour toi --------------------------------------------------------------------- 1. I love english junior Auteur(s) : Bruno FRAPPAT ; Frappat --Bruno -- Directeur de la pub Publié par : Bayard-presse , 57 Dans le catalogue : http://opac.koha_coderun.localhost/cgi-bin/koha/opac-detail.pl?biblionumber9 Exemplaires : * Le Cannet Documentaires adulte 00519000164128 All looks good, except the link url. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|frederic@tamil.fr |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Problems with translated |Problems with translated |cart email sent from OPAC |cart email sent -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21428|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22925&action=edit Bug 10605: Encoding issue on sending a basket (OPAC) There is an encoding issue on the received mail. Here, we have to keep the encode_qp in order not to break links (= is a special char for email https://en.wikipedia.org/wiki/MIME#Encoded-Word). I don't understand why I have to decode the string before the call to encode_qp but it is the only way not to have encoding issue... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22926&action=edit Bug 10605: Encoding issue on sending a basket (INTRANET) Same fix for the staff interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- With the last patch, I get: Bonjour, JOUBU vous a envoyé un panier de références extraites de notre catalogue. Notez que le fichier attaché est un fichier MARC, qui peut être importé dans un logiciel de gestion de bibliographie tel que EndNote, Reference Manager ou ProCite. --------------------------------------------------------------------- opac testé --------------------------------------------------------------------- 1. Pays de Provence Côte d'Azur Auteur(s) : Richard Clavaud ; Clavaud --Richard -- Directeur de la pub Publié par : Milan presse , 57 Dans le catalogue : http://opac.koha_coderun.localhost/cgi-bin/koha/opac-detail.pl?biblionumber=... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 Severity|enhancement |major --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- This is a major bug, it should be in 3.14. Please test! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11248 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but this is still giving me trouble. For the intranet: Software error: Undefined subroutine &main::decode called at /home/katrin/kohaclone/basket/sendbasket.pl line 136. For help, please send mail to the webmaster (webmaster@bumblebee), giving this error message and the time and date of the error. And in OPAC: In the received email, the introduction text has broken umlauts, but the title information is ok (tested in Thunderbird). When I switch the encoding to utf-8, the introduction text is ok, but the umlauts in the title information are broken. It looks to me, like we have a mix now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22926|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22996&action=edit Bug 10605: Encoding issue on sending a basket (INTRANET) Same fix for the staff interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #18)
I am sorry, but this is still giving me trouble.
For the intranet: Software error:
Last patch fixes this error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22925|0 |1 is obsolete| | Attachment #22996|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22998&action=edit Bug 10605: Encoding issue on sending a basket (OPAC) There is an encoding issue on the received mail. Here, we have to keep the encode_qp in order not to break links (= is a special char for email https://en.wikipedia.org/wiki/MIME#Encoded-Word). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22999&action=edit Bug 10605: Encoding issue on sending a basket (INTRANET) Same fix for the staff interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #18)
And in OPAC: In the received email, the introduction text has broken umlauts, but the title information is ok (tested in Thunderbird). When I switch the encoding to utf-8, the introduction text is ok, but the umlauts in the title information are broken. It looks to me, like we have a mix now.
Reproduced using icedove (~ Thunderbird). I don't occurs encoding issue with the 2 last patches. Could you retest please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 bondiurbano <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|costalc@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22998|0 |1 is obsolete| | Attachment #22999|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23018&action=edit [SIGNED OFF] Bug 10605: Encoding issue on sending a basket (OPAC) There is an encoding issue on the received mail. Here, we have to keep the encode_qp in order not to break links (= is a special char for email https://en.wikipedia.org/wiki/MIME#Encoded-Word). Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23019&action=edit [SIGNED OFF] Bug 10605: Encoding issue on sending a basket (INTRANET) Same fix for the staff interface. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Both patches tested with English and German, diacritics now appear correctly if UTF-8 is selected as encoding. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- NOTE: The staff cart email is missing the links back to the OPAC - but that is on master and with the patches, so another bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23018|0 |1 is obsolete| | --- Comment #27 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 23044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23044&action=edit [PASSED-QA] Bug 10605: Encoding issue on sending a basket (OPAC) There is an encoding issue on the received mail. Here, we have to keep the encode_qp in order not to break links (= is a special char for email https://en.wikipedia.org/wiki/MIME#Encoded-Word). Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #28 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 23045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23045&action=edit Bug 10605: Encoding issue on sending a basket (OPAC) There is an encoding issue on the received mail. Here, we have to keep the encode_qp in order not to break links (= is a special char for email https://en.wikipedia.org/wiki/MIME#Encoded-Word). Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23019|0 |1 is obsolete| | --- Comment #29 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 23046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23046&action=edit [PASSED-QA] Bug 10605: Encoding issue on sending a basket (INTRANET) Same fix for the staff interface. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Both patches tested with English and German, diacritics now appear correctly if UTF-8 is selected as encoding. Passes all tests and QA script. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23045|0 |1 is obsolete| | CC| |brendan@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #30 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #31 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patches pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #32 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- NB : looking at opac-sendbasket.pl and sendbasket.pl, I noticed that nearly all code is identical. This should be moved in a module. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11443 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 --- Comment #33 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Fridolin SOMERS from comment #32)
NB : looking at opac-sendbasket.pl and sendbasket.pl, I noticed that nearly all code is identical. This should be moved in a module.
Indeed: see bug 11443. Thks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org