http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8938 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30676&action=edit Bug 8938: Transport cost matrix script and template contain untranslatable strings This patch fixes the problem reported. To test: 1) Apply the patch 2) Update translations for your preffered language, xx-YY 3) Check new entries egrep -Rn "Cost must be expressed as a decimal number|Invalid value for" misc/translator/xx-YY* 4) Check no regression on alert, go to Administration > Transport cost matrix Edit some value and put a negative value & save, alert must show up 5) On errors, part of the error string is now on TT file, no regressions expected here -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8938 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8938 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 30686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30686&action=edit [Signed-off] Bug 8938: Transport cost matrix script and template contain untranslatable strings This patch fixes the problem reported. To test: 1) Apply the patch 2) Update translations for your preffered language, xx-YY 3) Check new entries egrep -Rn "Cost must be expressed as a decimal number|Invalid value for" misc/translator/xx-YY* 4) Check no regression on alert, go to Administration > Transport cost matrix Edit some value and put a negative value & save, alert must show up 5) On errors, part of the error string is now on TT file, no regressions expected here Verified that changes appear in translated language (de-CH) as appropriate. No regressions found by testing en en de-CH. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8938 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30803&action=edit [PASSED QA] Bug 8938: Transport cost matrix script and template contain untranslatable strings This patch fixes the problem reported. To test: 1) Apply the patch 2) Update translations for your preffered language, xx-YY 3) Check new entries egrep -Rn "Cost must be expressed as a decimal number|Invalid value for" misc/translator/xx-YY* 4) Check no regression on alert, go to Administration > Transport cost matrix Edit some value and put a negative value & save, alert must show up 5) On errors, part of the error string is now on TT file, no regressions expected here Verified that changes appear in translated language (de-CH) as appropriate. No regressions found by testing en en de-CH. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested both, entering a numeric value < 0 and non-numeric values, no regressions found. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8938 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.