[Bug 17405] New: The creation of the url on cat-toolbar.inc is using obsolete current_framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Bug ID: 17405 Summary: The creation of the url on cat-toolbar.inc is using obsolete current_framework Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: rsantellan@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 56058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56058&action=edit Remove current_framework. When viewing a biblio the url generated for editing generated is with the parameters: current_framework that is not initialized anywhere. I remove it from the call edit record and Edit as new (duplicate). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Rodrigo Santellan <rsantellan@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |rsantellan@gmail.com Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 56083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56083&action=edit Bug 17405 - The creation of the url on cat-toolbar.inc is using obsolete current_framework When viewing a biblio the url generated for editing generated is with the parameters: current_framework that is not initialized anywhere. This patch removes the parameter because it is not necessary To test, apply the patch and view the detail page for a bibliographic record which uses a framework other than the default. Test that the "Edit" and "Edit as new (duplicate)" loads the MARC editor using the correct framework. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56058|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Rodrigo, I took the attachment you posted and formatted it as a patch. There is information on the wiki about how to create patches: https://wiki.koha-community.org/wiki/Version_Control_Using_Git#Doing_work_on... Take a look and feel free to ask questions if you need help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 56234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56234&action=edit Bug 17405 Edit record uses Default framework In detail view (catalogue/detail.pl), when clicking on Edit > Edit record button, the record editor should be opened with the biblio record framework. It isn't the case. The Default framework is used. Same issue with Edit > Edit as new (duplicate). TO TEST: 1. Find a biblio record using a framework which is not the Default one. 2. See the biblio record in detail view (catalogue/detail.pl). 3. Click on Edit > Edit record. 4. Click on Settings => you can see 'Default' as selected framework. 5. Apply the patch. 6. Repeat step 3-4. => the biblio record framework is selected. 7. Repeat 3-4 using Edit > Edit as new (duplicate). Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Added a test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The creation of the url on |Edit record uses Default |cat-toolbar.inc is using |framework |obsolete current_framework | CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56083|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56234|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 56564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56564&action=edit [SIGNED-OFF]Bug 17405 Edit record uses Default framework In detail view (catalogue/detail.pl), when clicking on Edit > Edit record button, the record editor should be opened with the biblio record framework. It isn't the case. The Default framework is used. Same issue with Edit > Edit as new (duplicate). TO TEST: 1. Find a biblio record using a framework which is not the Default one. 2. See the biblio record in detail view (catalogue/detail.pl). 3. Click on Edit > Edit record. 4. Click on Settings => you can see 'Default' as selected framework. 5. Apply the patch. 6. Repeat step 3-4. => the biblio record framework is selected. 7. Repeat 3-4 using Edit > Edit as new (duplicate). Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Added a test plan Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Fix the issue, no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56564|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56626&action=edit Bug 17405 Edit record uses Default framework In detail view (catalogue/detail.pl), when clicking on Edit > Edit record button, the record editor should be opened with the biblio record framework. It isn't the case. The Default framework is used. Same issue with Edit > Edit as new (duplicate). TO TEST: 1. Find a biblio record using a framework which is not the Default one. 2. See the biblio record in detail view (catalogue/detail.pl). 3. Click on Edit > Edit record. 4. Click on Settings => you can see 'Default' as selected framework. 5. Apply the patch. 6. Repeat step 3-4. => the biblio record framework is selected. 7. Repeat 3-4 using Edit > Edit as new (duplicate). Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Added a test plan Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Fix the issue, no errors. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Rodrigo! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed in 3.22.x, will be in 3.22.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org