[Bug 6825] New: OpacNav menu hide user menu on opac-user.pl page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Bug #: 6825 Summary: OpacNav menu hide user menu on opac-user.pl page Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: frederic@tamil.fr QAContact: koha-bugs@lists.koha-community.org On OPAC, when a user is logged, he can see/modify his/her personal information. A menu on the left, give him access to his fines, personal details, etc. But if OpacNav is defined and contain a certain amount of links, this user menu is pushed down, and scrolling down the page is required to see it. A enhancement should inverse displaying OpacNav menu and user menu. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |frederic@tamil.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> 2011-08-31 10:05:59 UTC --- Created attachment 5236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5236 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5236|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> 2011-08-31 10:14:56 UTC --- Created attachment 5238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5238 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com --- Comment #3 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-09-02 08:29:49 UTC --- taking that -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 --- Comment #4 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-09-02 09:05:17 UTC --- GBSD#4 ok fine -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-09-08 14:10:39 UTC --- I'm wondering if this patch is the kind of thing that all libraries will want - many people have worked their design around the navigation being as it is - I hate to say it but this might be a system preference type thing so that it doesn't mess things up for libraries who have been using Koha for a long time and have users used to the menus being where they are. Changes to navigation shouldn't be made lightly when they cause usability issues for the patrons. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Failed QA --- Comment #6 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-08 14:39:36 UTC --- This is neither a bug nor an enhancement, but rather a matter of preference. For some libraries, the OpacNav content is best displayed above the opac-user menu (as it is now). For others, it's best below. The simplest solution for this is to include a system preference. A better, but much more difficult, solution would be to provide some kind of interface for users to be able to place content blocks on the various OPAC pages. While this bug is in itself sound, I think the change being made is not to the benefit of all libraries. Please reimplement with some kind of mechanism for the library to choose the order of this content. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 --- Comment #7 from Frédéric Demians <frederic@tamil.fr> 2011-09-10 11:36:11 UTC ---
This is neither a bug nor an enhancement, but rather a matter of preference. For some libraries, the OpacNav content is best displayed above the opac-user menu (as it is now). For others, it's best below.
I've never seen a library using OpacNav and not complaining about patron pages account links being pushed down by OpacNav... but I agree that some libraries may have tweaked their OPAC design to cope with that.
The simplest solution for this is to include a system preference. A better, but much more difficult, solution would be to provide some kind of interface for users to be able to place content blocks on the various OPAC pages.
What you think of an OpacNavBottom syspref which would be placed on all pages after OpacNav? on Patron pages, there will be: OpacNav Patron links OpacNavBottom OpacNavBottom syspref description could be: Show the following HTML on the left hand column of the main page and patron account on the OPAC, after OpacNav, and before patron account links if available. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-09-10 13:15:18 UTC --- Works for me, but wouldn't it be easier to have a pref for OpacNacLocation and say - "show opacnav above/below patron links" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 --- Comment #9 from Frédéric Demians <frederic@tamil.fr> 2011-09-10 16:40:39 UTC --- (In reply to comment #8)
Works for me, but wouldn't it be easier to have a pref for OpacNacLocation and say - "show opacnav above/below patron links"
Your solution is better from an user point of view: easier to understand. My solution would allow to keep on Patron page few links above Patron links: Library Home page link for example. I can't decide. Please choose for me one solution or the other. Thanks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 --- Comment #10 from Nicole C. Engard <nengard@gmail.com> 2011-09-10 21:33:11 UTC --- If you're willing to do the work then I choose your way :) It allows for more customization in the end. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5238|0 |1 is obsolete| | --- Comment #11 from Frédéric Demians <frederic@tamil.fr> 2011-09-11 09:26:24 UTC --- Created attachment 5395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5395 Revised patch This patch add a new syspref OpacNavBottom which is placed on all pages after OpacNav. On Patron pages, specif patron links are placed between OpacNav and OpacNavBottom, like this: OpacNav Patron links OpacNavBottom To test: 1 Apply this patch 2 For RM, modify kohaversion.pl and updatedatabase.pl appropriately 3 Test that OPAC pages are displayed as before, OpacNav on the left 4 Test OPAC patron pages: OpacNav is as before displayed after patron links 5 Split OpacNav between itself and OpacNavBottom 6 Patron pages display patron links between OpacNav and OpacNavBottom -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5395|0 |1 is obsolete| | --- Comment #12 from Nicole C. Engard <nengard@gmail.com> 2011-09-11 15:11:25 UTC --- Created attachment 5396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5396 [SIGNED-OFF] Bug 6825 OpacNav menu hide user menu on opac-user.pl page This patch add a new syspref OpacNavBottom which is placed on all pages after OpacNav. On Patron pages, specif patron links are placed between OpacNav and OpacNavBottom, like this: OpacNav Patron links OpacNavBottom To test: 1 Apply this patch 2 For RM, modify kohaversion.pl and updatedatabase.pl appropriately 3 Test that OPAC pages are displayed as before, OpacNav on the left 4 Test OPAC patron pages: OpacNav is as before displayed after patron links 5 Split OpacNav between itself and OpacNavBottom 6 Patron pages display patron links between OpacNav and OpacNavBottom Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #13 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-13 17:25:57 UTC --- Adds a new system preference that gives libraries the choice of how they want their content to display in user pages. Very cleanly done, and doesn't introduce new strings. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-13 22:31:50 UTC --- I agree with Ian, pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6825 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Seems to work fine. Closing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org