[Bug 38718] New: main container wrapper
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Bug ID: 38718 Summary: main container wrapper Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org On bug 38664 we are going to tidy the template file and so indent them properly. Most of our templates have the following structure: <div class="main container-fluid"> <div class="row"> <div class="col-md-10 order-md-2 order-sm-1"> <main> [% INCLUDE 'messages.inc' %] <!-- The content --> </main> </div> <div class="col-md-2 order-sm-2 order-md-1"> <aside> </aside> </div> </div> </div> It would be useful to have a WRAPPER to avoid: * errors (sometimes we see the two divs with the same order: sm-2) * inconsistencies * 4 indentation blocks (will be replaced with a single one) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38714 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714 [Bug 38714] [OMNIBUS] Adjust templates for prettier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38664 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- This is how it would look like: https://gitlab.com/joubu/Koha/-/commit/086d8b126b918fe558699a2297514ea8ecb6a... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- This is how it would look like: https://gitlab.com/joubu/Koha/-/commit/360a3811f3194b762028c3a927c81f14322d6... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- This is ready for testing, use the commits from the branch of bug 38664. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177403&action=edit Bug 38718: (follow-up) Wrap both search form and search results in wrapper Also pass "wide_full" parameter to main-container.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177404&action=edit Bug 38718: (follow-up) Use main-container.inc on ILL requests page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177405&action=edit Bug 38718: (follow-up) Restore sidebar menu to point of sale page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177406&action=edit Bug 38718: (follow-up) Correct aside parameter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177407&action=edit Bug 38718: (follow-up) Use container wrapper on tags page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177403|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177404|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177405|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177406|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177407|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Patches cherry-pick on bug_38664 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Signed-off-by: Owen Leonard <oleonard@myacpl.org> Added to the bug_38664 remote branch f5f2eeff9aa Bug 38718: (follow-up) Use container wrapper on tags page 4aaf897e847 Bug 38718: (follow-up) Correct aside parameter f659d3d995e Bug 38718: (follow-up) Restore sidebar menu to point of sale page bfc1a61e260 Bug 38718: (follow-up) Use main-container.inc on ILL requests page 9bdcc80dc2c Bug 38718: (follow-up) Wrap both search form and search results in wrapper 34337e73de5 Bug 38718: (follow-up) Fix a few minor errors dc7e4d057b9 Bug 38718: Preferences pages should use prefs-menu.inc, not admin-menu.inc 0a958696b40 Bug 38718: Main container - Virtual shelves 5a40cd03020 Bug 38718: Main container - Tools 2679ab4f1ae Bug 38718: Main container - Serials fd208977cd5 Bug 38718: Main container - Rotating collections 8f279d434ba Bug 38718: Main container - Reviews 8f931abffa8 Bug 38718: Main container - Reserves 07ebed37b20 Bug 38718: Main container - Reports c9c6a436531 Bug 38718: Main container - POS 6c359c8a85e Bug 38718: Main container - Patron lists eb284a2634e Bug 38718: Main container - Recalls 47ee7dd0d25 Bug 38718: Main container - Patron cards 5e2a6b13fb0 Bug 38718: Main container - Offline circ 01dbe1da2d5 Bug 38718: Main container - Members 09e10442c7e Bug 38718: Main container - Labels 2b8c93a35ef Bug 38718: Main container - Errors 19a31cd554e Bug 38718: Main container - Course reserves ca751c33770 Bug 38718: Main container - Clubs f2c04e7e433 Bug 38718: Main container - Circ 1e91cfb0743 Bug 38718: Main container - Cataloguing 1ea2aedc50b Bug 38718: Main container - Catalogue 2c1c7a6184f Bug 38718: Main container - Bookings 1272d7d442a Bug 38718: Main container - Basket be6ce4b32bf Bug 38718: Main container - Authorities d6f23ebdf9c Bug 38718: Main container - Administration d22684b16d0 Bug 38718: Main container - Acquisition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178320&action=edit ILL form It appears this commit: https://github.com/Koha-Community/Koha/commit/8bc6839#diff-ea700ef00f2961c96... Is restoring the bug fixed by bug 38359 (form too close to the left side of the page). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178321&action=edit Previously (left) and now (right) (In reply to Pedro Amorim from comment #12)
Is restoring the bug fixed by bug 38359 (form too close to the left side of the page).
If I'm seeing the right before and after, the form is now centered on the page rather than aligned to the right. It's different but it looks correct to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Owen Leonard from comment #13)
Created attachment 178321 [details] Previously (left) and now (right)
(In reply to Pedro Amorim from comment #12)
Is restoring the bug fixed by bug 38359 (form too close to the left side of the page).
If I'm seeing the right before and after, the form is now centered on the page rather than aligned to the right. It's different but it looks correct to me.
The before is how it was before the bootstrap 5 upgrade. The bootstrap 5 upgrade unintentionally (I believe) changed it. Bug 38359 then fixed what the bootstrap 5 unintentionally changed. This is now causing it to become how it was after the unintentional bootstrap 5 change again. The above is how I understand this but you are right, the whole form was aligned to the right before, and it now looks aligned correctly. Problem is that the inputs were more centered before (because the whole form was aligned to the right) and they're too pushed to the left now. Most forms have a left sidebar but that doesn't happen here. So I think the "right alignment" of the form was there to compensate for that and display the form inputs a bit more "centered" as if a siderbar existed, compeare with ERM agreements form or the patron edit form for example to see what I mean. Anyway, I don't know what the fix (if any) is here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Pedro Amorim from comment #14)
compeare with ERM agreements form or the patron edit form for example to see what I mean.
ERM agreements always show the sidebar, so I don't think that's a good comparison. Comparing with the patron edit form I think it matches how the ILL form currently looks, which is why I consider it to be correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39357 [Bug 39357] Wrong sidebar menu on batch checkout page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38718 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #17 from David Cook <dcook@prosentient.com.au> --- Just learning about this now but this seems great -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org