http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13297 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13297 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13297 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33678|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33745&action=edit [SIGNED-OFF] Bug 13297 - Shelving location PROC does not work according to manual According to the manual, "Items will stay in the PROC location until they are checked in". This is not the actual behavior. Right now items will only change from PROC to CART, and that is only if InProcessingToShelvingCart is enabled. Some libraries want to use the PROC to permanent location feature, without using the CART. Additionally, the location is only removed if using returns.pl, but that is not what the manual says either. What if the library uses SIP2 devices for handling returns? This should be taken into account. Test Plan: 1) Apply this patch 2) Set an item's current location to PROC, and it's permananet location to a different location. 3) Check the item in any way you wish 4) Note the shelving location is updated to the permanent location 5) prove t/db_dependent/Circulation/Returns.t Signed-off-by: Owen Leonard <oleonard@myacpl.org> I tested this with items which had items.location set to 'PROC' and items.permanent_location set to NULL, '', and a real value, and it worked correctly in all cases. I tested with check-ins from returns.pl and from the table of checkouts in circulation and the PROC location was correctly removed in both cases. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13297 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Note that because of Bug 13311 you can't test this patch properly if you are adding items but you're not selecting an existing shelving location. If you leave it blank you'll trigger Bug 13311. Test by choosing an existing shelving location or by manually updating the item record in MySQL to set a NULL or blank value. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13297 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33745|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33767&action=edit [PASSED QA] Bug 13297 - Shelving location PROC does not work according to manual According to the manual, "Items will stay in the PROC location until they are checked in". This is not the actual behavior. Right now items will only change from PROC to CART, and that is only if InProcessingToShelvingCart is enabled. Some libraries want to use the PROC to permanent location feature, without using the CART. Additionally, the location is only removed if using returns.pl, but that is not what the manual says either. What if the library uses SIP2 devices for handling returns? This should be taken into account. Test Plan: 1) Apply this patch 2) Set an item's current location to PROC, and it's permananet location to a different location. 3) Check the item in any way you wish 4) Note the shelving location is updated to the permanent location 5) prove t/db_dependent/Circulation/Returns.t Signed-off-by: Owen Leonard <oleonard@myacpl.org> I tested this with items which had items.location set to 'PROC' and items.permanent_location set to NULL, '', and a real value, and it worked correctly in all cases. I tested with check-ins from returns.pl and from the table of checkouts in circulation and the PROC location was correctly removed in both cases. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.