https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28901 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901 [Bug 28901] showCart incorrectly calculates position if content above navbar -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124987&action=edit Bug 28910: Correct eslint errors in OPAC basket.js This patch corrects eslint errors in the OPAC copy of basket.js: Indentation inconsistencies, undeclared variables, unused functions, etc. To test, apply the patch and test the "Cart" functionality in the OPAC: - In the OPAC, add an item to the cart. - A popup message should appear telling you the item has been added. - The "Add to cart" link should update to read "In your cart." - The count if cart items in the header should be updated. - The "In your cart (remove)" link should work correctly. - Test this process from both the search results and detail pages. - Open the cart. - The cart should open correctly. - In the cart, test all the controls: - More details - Send - Download - Empty and close - Hide window - Print - Select all / clear all - With checked items: - Remove - Add to list - Place hold - Tag The following unused functions were removed: readCookieValue, AllAreChecked, SelectAll, and quit. A search of the Koha codebase should return no results from the opac-tmpl directory. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124987|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 126813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126813&action=edit Bug 28910: Correct eslint errors in OPAC basket.js This patch corrects eslint errors in the OPAC copy of basket.js: Indentation inconsistencies, undeclared variables, unused functions, etc. To test, apply the patch and test the "Cart" functionality in the OPAC: - In the OPAC, add an item to the cart. - A popup message should appear telling you the item has been added. - The "Add to cart" link should update to read "In your cart." - The count if cart items in the header should be updated. - The "In your cart (remove)" link should work correctly. - Test this process from both the search results and detail pages. - Open the cart. - The cart should open correctly. - In the cart, test all the controls: - More details - Send - Download - Empty and close - Hide window - Print - Select all / clear all - With checked items: - Remove - Add to list - Place hold - Tag The following unused functions were removed: readCookieValue, AllAreChecked, SelectAll, and quit. A search of the Koha codebase should return no results from the opac-tmpl directory. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126813|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127121&action=edit Bug 28910: Correct eslint errors in OPAC basket.js This patch corrects eslint errors in the OPAC copy of basket.js: Indentation inconsistencies, undeclared variables, unused functions, etc. To test, apply the patch and test the "Cart" functionality in the OPAC: - In the OPAC, add an item to the cart. - A popup message should appear telling you the item has been added. - The "Add to cart" link should update to read "In your cart." - The count if cart items in the header should be updated. - The "In your cart (remove)" link should work correctly. - Test this process from both the search results and detail pages. - Open the cart. - The cart should open correctly. - In the cart, test all the controls: - More details - Send - Download - Empty and close - Hide window - Print - Select all / clear all - With checked items: - Remove - Add to list - Place hold - Tag The following unused functions were removed: readCookieValue, AllAreChecked, SelectAll, and quit. A search of the Koha codebase should return no results from the opac-tmpl directory. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Removes some methods, I prefer not to push in 20.11.x -- You are receiving this mail because: You are watching all bug changes.