[Bug 28847] New: Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Bug ID: 28847 Summary: Branch limits while searching should be expanded in query building and not in CGI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Bug 21249 introduced the SearchLimitLibrary system preference and added logic to the search scripts to account for it. Moving the code to modules allows us to cover the settings with tests. Additionally we should only expand the query passed to the search engine, the CGI param should remain brief -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28845, 21249 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123807&action=edit Bug 28847: Move SearchLimitLibrary code to QueryBuilder Modules This patch removes the code from the search scripts into QueryBuilder modules. To test: 1 - Have a library group defined as a search group for both staff and opac 2 - Search on staff client and opac with that group limit and a single branch limit 3 - Note your results/counts 4 - Note the visuals of the search description 5 - Apply patch 6 - Repeat searches 7 - All should work as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123808&action=edit Bug 28847: Unit tests Note: tests are very similar between ES and Zebra, however, ES requires the uppercase OR and doesn't use '=' in the same way. I feel having test coverage in each module is fair and more future proof in case of changes to search engine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123809&action=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 [Bug 22605] Adding the option to modify/edit searches on the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrew@bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I stumbled into a problem: - create a library group for use for OPAC searching BUT NOT staff searching - go to advanced search in the intranet - confirm you can select an individual library but no groups are shown - apply patch - reload adv search on the intranet - individual library selector is disabled (incorrect), groups selector doesn't show (correct) - edit your group, make it usable on the intranet - reload adv search - the group picker is now showing and the libraries picker is enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123809|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123830&action=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123830|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123832&action=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123832|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123833&action=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123807|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 123835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123835&action=edit Bug 28847: Move SearchLimitLibrary code to QueryBuilder Modules This patch removes the code from the search scripts into QueryBuilder modules. To test: 1 - Have a library group defined as a search group for both staff and opac 2 - Search on staff client and opac with that group limit and a single branch limit 3 - Note your results/counts 4 - Note the visuals of the search description 5 - Apply patch 6 - Repeat searches 7 - All should work as before Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123808|0 |1 is obsolete| | --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 123836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123836&action=edit Bug 28847: Unit tests Note: tests are very similar between ES and Zebra, however, ES requires the uppercase OR and doesn't use '=' in the same way. I feel having test coverage in each module is fair and more future proof in case of changes to search engine Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123833|0 |1 is obsolete| | --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 123837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123837&action=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Sorry, just noticed the same issue exists on the OPAC. If there is no search group in place for use on the OPAC, the Libraries dropdown is erroneously disabled. Kicking back to FQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123841&action=edit Bug 28847: Only apply JS to branch/multibranch selection if there are search groups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (confirmed library limits are showing up properly on the OPAC now) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 28295 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123835|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124574&action=edit Bug 28847: Move SearchLimitLibrary code to QueryBuilder Modules This patch removes the code from the search scripts into QueryBuilder modules. To test: 1 - Have a library group defined as a search group for both staff and opac 2 - Search on staff client and opac with that group limit and a single branch limit 3 - Note your results/counts 4 - Note the visuals of the search description 5 - Apply patch 6 - Repeat searches 7 - All should work as before Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123836|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124575&action=edit Bug 28847: Unit tests Note: tests are very similar between ES and Zebra, however, ES requires the uppercase OR and doesn't use '=' in the same way. I feel having test coverage in each module is fair and more future proof in case of changes to search engine Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123837|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124576&action=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123841|0 |1 is obsolete| | --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124577&action=edit Bug 28847: Only apply JS to branch/multibranch selection if there are search groups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |joonas.kylmala@iki.fi --- Comment #19 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- This breaks the existing links in the format: localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=&branch_group_limit=multibranchlimit-1&weight_search=1 i.e. where branch_group_limit is used. Let's not break the links suddenly as they might be someone's bookmarks or shared online. So please fix the code in opac/opac-search.pl to not produce multibranch query params from branch_group_limit param and leave a note that branch_group_limit is deprecated and should not be used. The code I'm talking about is in the following if block:
my $branch_group_limit = $cgi->param("branch_group_limit"); if ( $branch_group_limit ) {
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124797&action=edit Bug 28847: (follow-up) Handle branch_group_limit To test: 1 - Create a library group as an OPAC search group 2 - Enable OpacAddMastheadLibraryPulldown 3 - Browse to: http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=t&branch_group_limit=multibranchlimit-1&weight_search=1 4 - Confirm search works and returns correct results 5 - Confirm dropdown is correctly populated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Sorry for not doing very good job the first time reviewing, I found now additional issue: The buildQuery function in C4/Search.pm is modified by "Bug 28847: Move SearchLimitLibrary code to QueryBuilder Modules", it however leaves dead code in the else section "if ($this_limit =~ /^branch:(.+)/) {". That should be completely removed, and also we can see from that that the new regex condition added doesn't match as carefully the limit parameter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124831&action=edit Bug 28847: Remove dead code and make regex consistent This updates the regex code to match throughout the routine and removes code that would no longer be reached. Note that the code to update library name in the query descruiption was broken before this patch, so removal does not change behaviour -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124574|0 |1 is obsolete| | Attachment #124575|0 |1 is obsolete| | Attachment #124576|0 |1 is obsolete| | Attachment #124577|0 |1 is obsolete| | Attachment #124797|0 |1 is obsolete| | Attachment #124831|0 |1 is obsolete| | --- Comment #23 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125017&action=edit Bug 28847: Move SearchLimitLibrary code to QueryBuilder Modules This patch removes the code from the search scripts into QueryBuilder modules. To test: 1 - Have a library group defined as a search group for both staff and opac 2 - Search on staff client and opac with that group limit and a single branch limit 3 - Note your results/counts 4 - Note the visuals of the search description 5 - Apply patch 6 - Repeat searches 7 - All should work as before Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #24 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125018&action=edit Bug 28847: Unit tests Note: tests are very similar between ES and Zebra, however, ES requires the uppercase OR and doesn't use '=' in the same way. I feel having test coverage in each module is fair and more future proof in case of changes to search engine Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #25 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125019&action=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #26 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125020&action=edit Bug 28847: Only apply JS to branch/multibranch selection if there are search groups Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #27 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125021&action=edit Bug 28847: (follow-up) Handle branch_group_limit To test: 1 - Create a library group as an OPAC search group 2 - Enable OpacAddMastheadLibraryPulldown 3 - Browse to: http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=t&branch_group_limit=multibranchlimit-1&weight_search=1 4 - Confirm search works and returns correct results 5 - Confirm dropdown is correctly populated Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #28 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125022&action=edit Bug 28847: Remove dead code and make regex consistent This updates the regex code to match throughout the routine and removes code that would no longer be reached. Note that the code to update library name in the query descruiption was broken before this patch, so removal does not change behaviour Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126827&action=edit Bug 28847: Remove diag statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #30)
Created attachment 126827 [details] [review] Bug 28847: Remove diag statements
Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- This should be backported to 21.05 - it fixes a bug introduced by 21249 The code in the scripts joins the branches by 'or' - for ES this must be 'OR' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #34 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on bug 21249 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org