[Bug 36330] New: Fix typo: reseve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 Bug ID: 36330 Summary: Fix typo: reseve Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org $ grep -rn "reseves" * installer/data/mysql/updatedatabase.pl:4907: print "Upgrade to $DBversion done (Added system preference ExpireReservesMaxPickUpDelay, system preference ExpireReservesMaxPickUpDelayCharge, add reseves.charge_if_expired)\n"; misc/cronjobs/holds/cancel_expired_holds.pl:37:This script calls C4::Reserves::CancelExpiredReserves which will find and cancel all expired reseves in the system. magnus@bilbo ~/code/kohaclone (master)$ grep -rn "reseve" * installer/data/mysql/kohastructure.sql:2233: `location` varchar(80) DEFAULT NULL COMMENT 'new shelving location for the item to have while on reseve (optional)', installer/data/mysql/kohastructure.sql:2236: `enabled` enum('yes','no') NOT NULL DEFAULT 'no' COMMENT 'if at least one enabled course has this item on reseve, this field will be ''yes'', otherwise it will be ''no''', installer/data/mysql/updatedatabase.pl:4907: print "Upgrade to $DBversion done (Added system preference ExpireReservesMaxPickUpDelay, system preference ExpireReservesMaxPickUpDelayCharge, add reseves.charge_if_expired)\n"; Koha/Schema/Result/CourseItem.pm:155:new shelving location for the item to have while on reseve (optional) Koha/Schema/Result/CourseItem.pm:180:if at least one enabled course has this item on reseve, this field will be 'yes', otherwise it will be 'no' misc/cronjobs/holds/cancel_expired_holds.pl:37:This script calls C4::Reserves::CancelExpiredReserves which will find and cancel all expired reseves in the system. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 163655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163655&action=edit Bug 36330: Change 'reseve' to 'reserve' Test plan: 1. git grep 'reseve'. Notice there are instances of 'reseve' 2. Apply patch 3. Repeat step 1, there should be no instances of 'reseve' Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | Status|NEW |Needs Signoff CC| |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163655|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 163656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163656&action=edit Bug 36330: Change 'reseve' to 'reserve' Test plan: 1. git grep 'reseve'. Notice there are instances of 'reseve' 2. Apply patch 3. Repeat step 1, there should be no instances of 'reseve' Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163656|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 163718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163718&action=edit Bug 36330: Change 'reseve' to 'reserve' Test plan: 1. git grep 'reseve'. Notice there are instances of 'reseve' 2. Apply patch 3. Repeat step 1, there should be no instances of 'reseve' Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- diff --git a/Koha/Schema/Result/CourseItem.pm b/Koha/Schema/Result/CourseItem.pm index 53a62686e4..435c2db64e 100644 --- a/Koha/Schema/Result/CourseItem.pm +++ b/Koha/Schema/Result/CourseItem.pm @@ -152,7 +152,7 @@ a place to store the holdingbranch when item is on course reserve is_nullable: 1 size: 80 -new shelving location for the item to have while on reseve (optional) +new shelving location for the item to have while on reserve (optional) This is not allowed. You should provide a dbrev to update the tables for the adjusted comments in kohastructure. After that provide a DBIx schema update patch or leave it to the RM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Created attachment 167543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167543&action=edit Bug 36330: Follow up, change comments in the DB This patch updates the comments of course_items.location and course_items.enabled to say "reserve" instead of "reseve". To test in ktd: - sudo koha-mysql kohadev - Run: "SHOW CREATE TABLE course_items;" - Verify the comments of "location" and "enabled" contains "reseve" instead of "reserve" - Make a note of the definitions of these two columns - Run the atomicupdate: "sudo koha-upgrade-schema kohadev" - Log into the database again and run the same command as above - Verify the comments now say "reserve" instead of "reseve" - Make sure the column definitions are otherwise identical to the ones you saw before the upgrade. Only the spelling of "reserve" in the comment should be changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- First patch is signed off, I have provided a followup that updates the comments in the database. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167543|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 167591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167591&action=edit Bug 36330: Follow up, change comments in the DB This patch updates the comments of course_items.location and course_items.enabled to say "reserve" instead of "reseve". To test in ktd: - sudo koha-mysql kohadev - Run: "SHOW CREATE TABLE course_items;" - Verify the comments of "location" and "enabled" contains "reseve" instead of "reserve" - Make a note of the definitions of these two columns - Run the atomicupdate: "sudo koha-upgrade-schema kohadev" - Log into the database again and run the same command as above - Verify the comments now say "reserve" instead of "reseve" - Make sure the column definitions are otherwise identical to the ones you saw before the upgrade. Only the spelling of "reserve" in the comment should be changed. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- (In reply to Magnus Enger from comment #6)
First patch is signed off, I have provided a followup that updates the comments in the database.
Now signed off. I did notice an extra line with "0E0" for the database update - not sure if this is an issue or not: updatedatabase DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug36330-fix-typo-reseve.pl [23:38:45]: Bug 36330 - Fix typo 'reseve' in COMMENTs for table course_items 0E0 Comment for course_items.location was updated. Comment for course_items.enabled was updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167591|0 |1 is obsolete| | --- Comment #9 from Magnus Enger <magnus@libriotech.no> --- Created attachment 167600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167600&action=edit Bug 36330: Follow up, change comments in the DB This patch updates the comments of course_items.location and course_items.enabled to say "reserve" instead of "reseve". To test in ktd: - sudo koha-mysql kohadev - Run: "SHOW CREATE TABLE course_items;" - Verify the comments of "location" and "enabled" contains "reseve" instead of "reserve" - Make a note of the definitions of these two columns - Run the atomicupdate: "sudo koha-upgrade-schema kohadev" - Log into the database again and run the same command as above - Verify the comments now say "reserve" instead of "reseve" - Make sure the column definitions are otherwise identical to the ones you saw before the upgrade. Only the spelling of "reserve" in the comment should be changed. Signed-off-by: David Nind <david@davidnind.com> Removed unnecessary line of debug output. 2024-06-10 Magnus Enger -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 --- Comment #10 from Magnus Enger <magnus@libriotech.no> --- (In reply to David Nind from comment #8)
(In reply to Magnus Enger from comment #6)
First patch is signed off, I have provided a followup that updates the comments in the database.
Now signed off.
I did notice an extra line with "0E0" for the database update - not sure if this is an issue or not:
updatedatabase DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug36330-fix-typo-reseve. pl [23:38:45]: Bug 36330 - Fix typo 'reseve' in COMMENTs for table course_items 0E0 Comment for course_items.location was updated. Comment for course_items.enabled was updated.
That line was left over from testing, sorry about that. I have updated the signed off patch and removed that line. Hope that is OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 --- Comment #11 from David Nind <david@davidnind.com> --- Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163718|0 |1 is obsolete| | --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167663&action=edit Bug 36330: Change 'reseve' to 'reserve' Test plan: 1. git grep 'reseve'. Notice there are instances of 'reseve' 2. Apply patch 3. Repeat step 1, there should be no instances of 'reseve' Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167600|0 |1 is obsolete| | --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167664&action=edit Bug 36330: Follow up, change comments in the DB This patch updates the comments of course_items.location and course_items.enabled to say "reserve" instead of "reseve". To test in ktd: - sudo koha-mysql kohadev - Run: "SHOW CREATE TABLE course_items;" - Verify the comments of "location" and "enabled" contains "reseve" instead of "reserve" - Make a note of the definitions of these two columns - Run the atomicupdate: "sudo koha-upgrade-schema kohadev" - Log into the database again and run the same command as above - Verify the comments now say "reserve" instead of "reseve" - Make sure the column definitions are otherwise identical to the ones you saw before the upgrade. Only the spelling of "reserve" in the comment should be changed. Signed-off-by: David Nind <david@davidnind.com> Removed unnecessary line of debug output. 2024-06-10 Magnus Enger Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the spelling of release notes| |"reserve" in Koha source | |code comments (was spelled | |incorrectly as "reseve"). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org