[Bug 13766] New: biblioitems.ean field is too short
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Bug ID: 13766 Summary: biblioitems.ean field is too short Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Database Assignee: gmcharlt@gmail.com Reporter: frederic@tamil.fr QA Contact: testopia@bugs.koha-community.org biblioitems.ean field is too short. It's a VARCHAR(13) type. EAN can be longer, especially if it's repeated in the biblio record. When biblio records are imported, and 073 (Unimarc) or 024 (MARC21) field is repeated, their content can't be stored in biblioitems.ean field : it stopped the biblio record import. This field should be aligned to biblioitems.isbn type: MEDIUMTEXT. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 36233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36233&action=edit Bug 13766 Set biblioitems.ean type to MEDIUMTEXT biblioitems.ean field is too short. It's a VARCHAR(13) type. EAN can be longer, especially if it's repeated in the biblio record. When biblio records are imported, and 073 (Unimarc) or 024 (MARC21) field is repeated, their content can't be stored in biblioitems.ean field: it stops the biblio record import. This field should be aligned to biblioitems.isbn type: MEDIUMTEXT. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 36251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36251&action=edit [Signed-off] Bug 13766 Set biblioitems.ean type to MEDIUMTEXT biblioitems.ean field is too short. It's a VARCHAR(13) type. EAN can be longer, especially if it's repeated in the biblio record. When biblio records are imported, and 073 (Unimarc) or 024 (MARC21) field is repeated, their content can't be stored in biblioitems.ean field: it stops the biblio record import. This field should be aligned to biblioitems.isbn type: MEDIUMTEXT. Verified that tables biblioitems and deletedbiblioitems are changed. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36233|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Frédéric, I got an error on executing the updatedb entry: DBD::mysql::db do failed: BLOB/TEXT column 'ean' used in key specification without a key length at installer/data/mysql/updatedatabase.pl line 9798. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Jonathan Druart from comment #3)
Frédéric, I got an error on executing the updatedb entry:
DBD::mysql::db do failed: BLOB/TEXT column 'ean' used in key specification without a key length at installer/data/mysql/updatedatabase.pl line 9798.
Thanks testing. I also can get this error. I don't have it on recent DB. I get it on older. In updatedatebase.pl, line 5323: $dbh->do("CREATE INDEX `ean` ON biblioitems (`ean`) "); So a DB which was on Koha 3.8, and earlier, has an index on biblioitems.ean. A fresh DB, hasn't such an index. kohastructre.sql, line 186 and after, there are index defined for isbn but not for ean. Do you think that an index is required on ean field? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5337 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Frédéric Demians from comment #4)
Do you think that an index is required on ean field?
It has been added by bug 5337, but the patch does not update the kohastructure.sql file. I think it's an oversight and should exist. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org