https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 --- Comment #2 from Claudio Costales <costalc@gmail.com> --- (In reply to Claudio Costales from comment #1)

Dame problema in 22.11.08

Same problem in 22.11.08 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 Jimmy <azmikhalib@utm.my> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #4 from Jimmy <azmikhalib@utm.my> --- (In reply to Nick Clemens from comment #3)

Created attachment 154834 [details] [review] Bug 34552: Don't exclude payments with no status

Bug 29664 removed payments with a void status, however, the query also removed any payments with no status set

Test Plan: 1 - Set up your cash registers and enable POS and add a debit type that is able to be sold 2 - Take 2 payments via POS 3 - Void one payment 4 - Go to Reports->Statistics wizards->Cash register 4) Verify neither shows for the "All payments to the library" and "Payment" transaction type filters 5) Apply this patch 6) Restart all the things! 7) Verify the non-voided fee shows for the "All payments to the library" and "Payment" transaction type filters and the voided fee does not

#### I already tested but it did not work..... The same issues still occur, with no result when filtering "All payments to the library" and "Payment" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 Jimmy <azmikhalib@utm.my> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No Results in filtering |No Results when filtering |"All payments to the |"All payments to the |library" or "payment" in |library" or "payment" in |Statistics wizards : Cash |Statistics wizards : Cash |register |register -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 --- Comment #5 from Claudio Costales <costalc@gmail.com> --- Agree with Jimmy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't use 'in discussion' unless there is one, if something doesn't work, pleaes use FQA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 --- Comment #8 from Claudio Costales <costalc@gmail.com> --- (In reply to Katrin Fischer from comment #7)

Claudio and Jimmy, how did you test?

In a local installation, Katrin -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 --- Comment #10 from Claudio Costales <costalc@gmail.com> --- (In reply to Katrin Fischer from comment #9)

(In reply to Claudio Costales from comment #8)

...

(In reply to Katrin Fischer from comment #7)

...

Claudio and Jimmy, how did you test?

In a local installation, Katrin

Package installation or development/git installation? Asking because the patch itself makes sense to me and I wonder if maybe a missing Plack restart or similar could have been the culprit.

Package installation. Katrin, I followed your suggestion and it works (Restarted memcached and plack). Thanks for your patience. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154834|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 155625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155625&action=edit Bug 34552: Don't exclude payments with no status Bug 29664 removed payments with a void status, however, the query also removed any payments with no status set Test Plan: 1 - Set up your cash registers and enable POS and add a debit type that is able to be sold 2 - Take 2 payments via POS 3 - Void one payment 4 - Go to Reports->Statistics wizards->Cash register 4) Verify neither shows for the "All payments to the library" and "Payment" transaction type filters 5) Apply this patch 6) Restart all the things! 7) Verify the non-voided fee shows for the "All payments to the library" and "Payment" transaction type filters and the voided fee does not Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155625|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155756&action=edit Bug 34552: Don't exclude payments with no status Bug 29664 removed payments with a void status, however, the query also removed any payments with no status set Test Plan: 1 - Set up your cash registers and enable POS and add a debit type that is able to be sold 2 - Take 2 payments via POS 3 - Void one payment 4 - Go to Reports->Statistics wizards->Cash register 4) Verify neither shows for the "All payments to the library" and "Payment" transaction type filters 5) Apply this patch 6) Restart all the things! 7) Verify the non-voided fee shows for the "All payments to the library" and "Payment" transaction type filters and the voided fee does not Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 --- Comment #18 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Laura O'Neil from comment #17)

Is there any chance this can be backported into 22.11, please?

+1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 --- Comment #20 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.