http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12198 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12198 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27989&action=edit Bug 12198 - Remove unused variables, tidy code -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12198 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27988|0 |1 is obsolete| | Attachment #27989|0 |1 is obsolete| | --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 27996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27996&action=edit Bug 12198: remove unnecessary call to GetMemberIssuesAndFines from guarantor search The script members/guarantor_search.pl made the following call: my ($od,$issue,$fines)=GetMemberIssuesAndFines($results->[$i]{'borrowerid'}); Not only does this call always fail because borrowerid is not a valid key, but the results are never even used in the template! Test Plan: 1) Apply this patch 2) Verify the gurantor search works as before, No changes in behavior should be noted Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12198 --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 27998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27998&action=edit Bug 12198: (follow-up) fix warning when opening guarantor search form To test: [1] Verify that act of running a guarantor search does not result in the following warning message in the Apache log: "guarantor_search.pl: Use of uninitialized value $member in string ne at guarantor_search.pl line 63" Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12198 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27996|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28108&action=edit Bug 12198: remove unnecessary call to GetMemberIssuesAndFines from guarantor search The script members/guarantor_search.pl made the following call: my ($od,$issue,$fines)=GetMemberIssuesAndFines($results->[$i]{'borrowerid'}); Not only does this call always fail because borrowerid is not a valid key, but the results are never even used in the template! Test Plan: 1) Apply this patch 2) Verify the gurantor search works as before, No changes in behavior should be noted Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12198 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27998|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28110&action=edit Bug 12198: (follow-up) fix warning when opening guarantor search form To test: [1] Verify that act of running a guarantor search does not result in the following warning message in the Apache log: "guarantor_search.pl: Use of uninitialized value $member in string ne at guarantor_search.pl line 63" Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.