[Bug 20733] New: Delete api key or add a deleted flag?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20733 Bug ID: 20733 Summary: Delete api key or add a deleted flag? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org
From bug 20612 comment 23.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20733 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20612 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 [Bug 20612] Make OAuth2 use patron's client_id/secret pairs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20733 Bug 20733 depends on bug 20612, which changed state. Bug 20612 Summary: Make OAuth2 use patron's client_id/secret pairs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20733 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Delete api key or add a |Delete API key or add a |deleted flag? |deleted flag? --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #23)
(In reply to Jonathan Druart from comment #22)
Should we really remove a deleted key from the DB table? I would flag it as inactive instead, it would permit to keep track of the different requests and associate it to a user. Disclaimer: This may be a very stupid idea.
I thought about it too. That would mean an extra column: deleted TINYINT (1), and it makes sense.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org