https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- +1, I love this idea -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #0)

Should not we replace C4::Debug (and all "$debug && warn" statements) with Koha::Logger->debug?

+1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28591, 28570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 [Bug 28570] bor_issues_top.pl using a /tmp file to log debug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28591 [Bug 28591] debug pass to get_template_and_user but not used -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122118&action=edit Bug 28572: Remove C4::Debug We are using Koha::Logger when it makes sense to keep the info, otherwise we simply remove it -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122118|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122147&action=edit Bug 28572: Remove C4::Debug We are using Koha::Logger when it makes sense to keep the info, otherwise we simply remove it Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- No regressions found.. I went through the patches inspecting what had been removed/replaced and I agree with all the decisions Jonathan made.. be great to get a second opinion from QA, but I don't think there's anything controversial here.. it'll be great to see this go and hopefully it'll encourage a little more use of Koha::Logger by hiding dropping this alternative.. would be great to see more of the bare warns updated too at some point. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- sub get_shelves_userenv { my $active; unless ($active = $context->{userenv}->{$context->{activeuser}}) { $debug and warn "get_shelves_userenv cannot retrieve context->{userenv}->{context->{activeuser}}"; return; -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- More cases of the former too -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- git grep "C4::Debug" misc/admin/koha-preferences:use C4::Debug; misc/admin/koha-preferences: print STDERR $message . "\n" if ( $C4::Debug::debug ); -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28590 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #9)

Just mentioning one compile error:

perl -c tools/viewlog.pl

Oops, there was a missing dependency on bug 28590. (In reply to Marcel de Rooy from comment #11)

- $debug and warn "Error ExportFramework $@\n"; + Koha::Logger->get->warn("Error ExportFramework $@");

Warn instead of debug ?

Yes, those are warnings (export errors). We can lower them later if it's too noisy. (In reply to Marcel de Rooy from comment #13)

-BEGIN { - $DEBUG = ($ENV{DEBUG}) ? 1 : 0; -}

We still have other cases of using $ENV{DEBUG} ? What about them?

This report was about C4::Debug only, we could extend it to DEBUG. (In reply to Marcel de Rooy from comment #14)

git grep "C4::Debug" misc/admin/koha-preferences:use C4::Debug; misc/admin/koha-preferences: print STDERR $message . "\n" if ( $C4::Debug::debug );

Oops, my 'git grep' alias is not picking files without extension it seems! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 [Bug 28590] get_shelves_userenv and set_shelves_userenv not used -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #15)

(In reply to Marcel de Rooy from comment #9)

...

-BEGIN { - $DEBUG = ($ENV{DEBUG}) ? 1 : 0; -}

We still have other cases of using $ENV{DEBUG} ? What about them?

This report was about C4::Debug only, we could extend it to DEBUG.

Pfiou, that's painful. I would prefer to do that on a separate bug report, unless someone else is volunteering. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122216|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122218&action=edit Bug 28572: Replace missing occurrence in misc/admin/koha-preferences Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #20 from David Cook <dcook@prosentient.com.au> --- Awesome. I don't think C4::Debug even works that well with Plack? Looking forward to seeing this one in action.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122290&action=edit Bug 28572: Fix misc/admin/koha-preferences -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate |additional_work_needed --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #24)

Created attachment 122291 [details] [review] Bug 28572: Fix Search.t

This does not work, "Can't open /var/log/z3950-error.log (Permission denied)" We need to mock the log4perl configuration for tests or we are going to face a lot of issues. Any good ideas? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, Search.t got too noisy. It is because of undefined stuffs. It can be trivially fixed, but I also noticed that some warns that got replaced by calls to the logger, got the if $DEBUG; removed. Is that intended? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 122304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122304&action=edit Bug 28572: Avoid useless warnings There are too many warnings about uninitialized variables in Search.pm. This patch deals with that, the same way it is dealt accross the file: by setting an empty string when things are not defined. To test: 1. Run: $ kshell k$ prove t/db_dependent/Search.t => FAIL: Wow, too many warnings. Some related to this bug, some not. 2. Apply this patch 3. Repeat 1 => SUCCESS: No more warnings! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122304|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Comment on attachment 122304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122304 Bug 28572: Avoid useless warnings Patch moved to bug 28483 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Bug 28572 depends on bug 28590, which changed state. Bug 28590 Summary: get_shelves_userenv and set_shelves_userenv not used https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Enhancement not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.