[Bug 16167] New: Authorised value images may be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Bug ID: 16167 Summary: Authorised value images may be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 16041 The feature to attach an image to an authorised value does not seem to work perfectly and it's possible that nobody uses it. I'd suggest to discuss about that removal on this bug report. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16041 [Bug 16041] StaffAuthorisedValueImages & AuthorisedValueImages preferences - impact on search performace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> ---
From bug 16041: There are 2 prefs to drive this feature: StaffAuthorisedValueImages and AuthorisedValueImages. AuthorisedValueImages is not added by sysprefs.sql and does not appear in updatedatabase.pl, we could easily imagine that nobody uses it. With XSLT enabled, the feature is only visible on a record detail page at the OPAC, if AuthorisedValueImages is set. Otherwise you need to turn the XSLT off. In this case you will see the images on the result list (OPAC+Staff interfaces) and OPAC detail page, but not the Staff detail page.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49673&action=edit Bug 16167: Remove Authorised value images There are 2 prefs to drive this feature: StaffAuthorisedValueImages and AuthorisedValueImages. AuthorisedValueImages is not added by sysprefs.sql and does not appear in updatedatabase.pl, we could easily imagine that nobody uses it. With XSLT enabled, the feature is only visible on a record detail page at the OPAC, if AuthorisedValueImages is set. Otherwise you need to turn the XSLT off. In this case you will see the images on the result list (OPAC+Staff interfaces) and OPAC detail page, but not the Staff detail page. This patch suggests to remove completely this feature as it does not work correctly. Test plan: Confirm that the authorised value images are no longer visible at the opac and the staff interfaces. The prefs should have been removed too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7706 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49838&action=edit Bug 16167: Atomic update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I think we should retain the ability to associate an image with an authorized value because libraries like having an image associated with a collection code or shelving location on the advanced search page (like you can with item types). I think the StaffAuthorisedValueImages and AuthorisedValueImages preferences should be removed because they don't really do anything, but keep the image-handling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #4)
I think we should retain the ability to associate an image with an authorized value because libraries like having an image associated with a collection code or shelving location on the advanced search page (like you can with item types).
I think the StaffAuthorisedValueImages and AuthorisedValueImages preferences should be removed because they don't really do anything, but keep the image-handling.
We need to keep the pref to avoid the useless processing done at different places. I have not found any uses of the images anywhere unless non-XSLT views. If you find a place where it is used, please let me know. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think what Owen was trying to say is that the feature for linking icons with authorised valued should be kept. Because this is currently in use on the advanced search page (and maybe in other spots). But the expectation for icons to show up on the result list and the detail page is wrong at the moment for XSLT and that we should remove the prefs saying so and also the code related to that and possibly the normal views as they are deprecated. It would be a first as we haven't actively removed non-XSLT features so far, although the views have been deprecated for a while now. So if we do it - we should make sure it's noted clearly somewhere in the Release notes I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49673|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50262&action=edit Bug 16167: Remove Authorised value images prefs There are 2 prefs to drive this feature: StaffAuthorisedValueImages and AuthorisedValueImages. AuthorisedValueImages is not added by sysprefs.sql and does not appear in updatedatabase.pl, we could easily imagine that nobody uses it. With XSLT enabled, the feature is only visible on a record detail page at the OPAC, if AuthorisedValueImages is set. Otherwise you need to turn the XSLT off. In this case you will see the images on the result list (OPAC+Staff interfaces) and OPAC detail page, but not the Staff detail page. This patch suggests to remove completely this feature as it does not work correctly. The ability to assign an image to an authorised value is now always displayed, but the image will only be displayed on the advanced search if defined. Test plan: Confirm that the authorised value images are no longer visible at the opac and the staff interfaces. The prefs should have been removed too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #6)
I think what Owen was trying to say is that the feature for linking icons with authorised valued should be kept. Because this is currently in use on the advanced search page (and maybe in other spots).
But the expectation for icons to show up on the result list and the detail page is wrong at the moment for XSLT and that we should remove the prefs saying so and also the code related to that and possibly the normal views as they are deprecated.
It would be a first as we haven't actively removed non-XSLT features so far, although the views have been deprecated for a while now. So if we do it - we should make sure it's noted clearly somewhere in the Release notes I think.
With this last patch the prefs are removed but the ability to choose an icon for a AV is still possible. If defined, the icon will be displayed to the adv search form. Note that if the prefs were off but an image defined, before this patch the image was not displayed, now it will. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Authorised value images may |Remove prefs to drive |be removed |authorised value images -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49838|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50276&action=edit [SIGNED-OFF] Bug 16167: Atomic update Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50262|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50277&action=edit [SIGNED-OFF] Bug 16167: Remove Authorised value images prefs There are 2 prefs to drive this feature: StaffAuthorisedValueImages and AuthorisedValueImages. AuthorisedValueImages is not added by sysprefs.sql and does not appear in updatedatabase.pl, we could easily imagine that nobody uses it. With XSLT enabled, the feature is only visible on a record detail page at the OPAC, if AuthorisedValueImages is set. Otherwise you need to turn the XSLT off. In this case you will see the images on the result list (OPAC+Staff interfaces) and OPAC detail page, but not the Staff detail page. This patch suggests to remove completely this feature as it does not work correctly. The ability to assign an image to an authorised value is now always displayed, but the image will only be displayed on the advanced search if defined. Test plan: Confirm that the authorised value images are no longer visible at the opac and the staff interfaces. The prefs should have been removed too. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Note: the detail pages in OPAC don't work for me with and without this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50276|0 |1 is obsolete| | Attachment #50277|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50631&action=edit [PASSED QA] Bug 16167: Atomic update Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50632&action=edit [PASSED QA] Bug 16167: Remove Authorised value images prefs There are 2 prefs to drive this feature: StaffAuthorisedValueImages and AuthorisedValueImages. AuthorisedValueImages is not added by sysprefs.sql and does not appear in updatedatabase.pl, we could easily imagine that nobody uses it. With XSLT enabled, the feature is only visible on a record detail page at the OPAC, if AuthorisedValueImages is set. Otherwise you need to turn the XSLT off. In this case you will see the images on the result list (OPAC+Staff interfaces) and OPAC detail page, but not the Staff detail page. This patch suggests to remove completely this feature as it does not work correctly. The ability to assign an image to an authorised value is now always displayed, but the image will only be displayed on the advanced search if defined. Test plan: Confirm that the authorised value images are no longer visible at the opac and the staff interfaces. The prefs should have been removed too. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for the 16.05 release. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16408 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16408 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16408 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16408 [Bug 16408] Fix UsageStats.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Doug Dearden <dearden@sarsf.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dearden@sarsf.org --- Comment #15 from Doug Dearden <dearden@sarsf.org> --- I did an upgrade to 16.05.05.000 and got these errors that seem to be related (maybe only the second one): updatedatabase.pl: At least one authorised value has an icon defined (imageurl) updatedatabase.pl: The system preference AuthorisedValueImages or StaffAuthorisedValueImages could be turned off if you are not aware of this feature. I went looking for the two system preferences mentioned and couldn't find them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Doug Dearden from comment #15)
I did an upgrade to 16.05.05.000 and got these errors that seem to be related (maybe only the second one):
updatedatabase.pl: At least one authorised value has an icon defined (imageurl)
updatedatabase.pl: The system preference AuthorisedValueImages or StaffAuthorisedValueImages could be turned off if you are not aware of this feature.
I went looking for the two system preferences mentioned and couldn't find them.
Yes the output is confusing I agree. Actually we decided to display the warning on bug 16041 but the decided to remove the 2 prefs from 16167. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8219 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org