[Bug 41771] New: Diff in syspref descriptions after Bug 30331
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41771 Bug ID: 41771 Summary: Diff in syspref descriptions after Bug 30331 Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org There is a diff in syspref's description for existing installs: # Failed test 'Comparing AutomaticRenewalPeriodBase' # at t/db_dependent/check_sysprefs.t line 135. # Structures begin differing at: # $got->{explanation} = 'Set whether the renewal date should be counted from the date_due or from the moment the Patron asks for renewal, for automatic renewals' # $expected->{explanation} = 'Set whether the renewal date should be counted from the date_due or from the moment the Patron asks for renewal, for automatic renewals ' # Failed test 'Comparing ManualRenewalPeriodBase' # at t/db_dependent/check_sysprefs.t line 135. # Structures begin differing at: # $got->{explanation} = 'Set whether the renewal date should be counted from the date_due or from the moment the Patron asks for renewal ' # $expected->{explanation} = 'Set whether the renewal date should be counted from the date_due or from the moment the Patron asks for renewal, for manual renewals ' # Looks like you failed 2 tests of 1753. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41771 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30331 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30331 [Bug 30331] Allow RenewalPeriodBase behavior to differ between manual and automatic renewals -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41771 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- However, the test does not fail for me locally. t/db_dependent/check_sysprefs.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41771 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #1)
However, the test does not fail for me locally.
t/db_dependent/check_sysprefs.t
Not yet, because we don't run it after an upgrade, but we should at some point. It was advertised there: ``` commit 409c804bc199a770ba7bf9f8de9c46165e8ecae1 Bug 41682: Sync DB and sysprefs.sql for new and upgraded installs Later: * Run the tests on upgraded installs on CI ``` -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41771 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- *** This bug has been marked as a duplicate of bug 41800 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org