https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 52458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52458&action=edit Bug 16752 - Remove the use of event attributes from some acquisitions templates - Transfer order This patch removes the use of 'onclick' from the acquisitions transfer order process. The patch also modifies the style of some links and buttons to conform with current guidelines. - Locate an open basket with items in it - Click the 'Transfer' link for a title in the basket - In the pop-up window: - Confirm that the 'Cancel' button at the bottom of the window is a Bootstrap-style button. - Search for a vendor; Confirm that the 'Choose' link is a Bootstrap-style button. - Choose a vendor; Confirm that the 'Choose' link on the following page is a Bootstrap-style button. - Confirm that clicking the 'Choose' button transfers the item to the correct basket. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 52460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52460&action=edit Bug 16752 - Remove the use of event attributes from some acquisitions templates - Funds This patch modifies the funds administration page and other files related to the process of searching for and selecting fund owners and users in order to remove the use of event attributes like 'onclick.' Also changed in this patch: I have revised the way the "select owner" and "select user" controls look. They are now links with Font Awesome icons. - Go to Administration -> Funds and open a fund for editing. - Test the process of adding and updating an owner: - Click the 'Select owner' link. - Search for and select an owner in the pop-up window. - Save the fund and verify that the owner was saved correctly. - Perform the same test with the 'Remove owner' link. - Use the same process to test the addition and removal of users. - Confirm that the 'Remove' link works correctly before and after submitting the form to save changes to the fund. This patch changes a file which is used by both the funds template and the template used when setting a guarantor on a patron. To test the changes in that context: - Open a 'child' type patron record. - Under 'Guarantor information,' test the process of setting and removing a guarantor to confirm that data is saved correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Comment on attachment 52458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52458 Bug 16752 - Remove the use of event attributes from some acquisitions templates - Transfer order Hi Owen

--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/transferorder.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/transferorder.tt

+ $(doocument).ready(function(){ + $(".confirm_transfer").on("click",function(){ + return confirm( _("Transfer order to this basket?") ); + }); + }); //]]>

I think there is a typo in your first patch "doocument" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Héctor Eduardo Castro Avalos from comment #4)

I think there is a typo in your first patch "doocument"

Don't be afraid to mark something as "Failed QA." You don't have to be QA manager to do it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52458|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53569&action=edit Bug 16752 - Remove the use of event attributes from some acquisitions templates - Transfer order This patch removes the use of 'onclick' from the acquisitions transfer order process. The patch also modifies the style of some links and buttons to conform with current guidelines. - Locate an open basket with items in it - Click the 'Transfer' link for a title in the basket - In the pop-up window: - Confirm that the 'Cancel' button at the bottom of the window is a Bootstrap-style button. - Search for a vendor; Confirm that the 'Choose' link is a Bootstrap-style button. - Choose a vendor; Confirm that the 'Choose' link on the following page is a Bootstrap-style button. - Confirm that clicking the 'Choose' button transfers the item to the correct basket. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52459|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54737&action=edit [SIGNED-OFF] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Uncertain prices This patch modifies the acquisitions uncertain prices template to remove event attributes onclick and onchange. Also changed on the uncertain prices page: Added a label to the orders filter, removed redundant form submit function. - Locate a vendor which has orders with uncertain prices - Click the 'Uncertain prices' tab in the left-hand sidebar - Enter invalid data in the "price" field for any order. Confirm that an error is triggered when the field loses focus. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53569|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54739&action=edit [SIGNED-OFF] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Transfer order This patch removes the use of 'onclick' from the acquisitions transfer order process. The patch also modifies the style of some links and buttons to conform with current guidelines. - Locate an open basket with items in it - Click the 'Transfer' link for a title in the basket - In the pop-up window: - Confirm that the 'Cancel' button at the bottom of the window is a Bootstrap-style button. - Search for a vendor; Confirm that the 'Choose' link is a Bootstrap-style button. - Choose a vendor; Confirm that the 'Choose' link on the following page is a Bootstrap-style button. - Confirm that clicking the 'Choose' button transfers the item to the correct basket. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54936&action=edit Bug 16752 - Remove the use of event attributes from some acquisitions templates - Transfer order This patch removes the use of 'onclick' from the acquisitions transfer order process. The patch also modifies the style of some links and buttons to conform with current guidelines. - Locate an open basket with items in it - Click the 'Transfer' link for a title in the basket - In the pop-up window: - Confirm that the 'Cancel' button at the bottom of the window is a Bootstrap-style button. - Search for a vendor; Confirm that the 'Choose' link is a Bootstrap-style button. - Choose a vendor; Confirm that the 'Choose' link on the following page is a Bootstrap-style button. - Confirm that clicking the 'Choose' button transfers the item to the correct basket. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.