https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi David, it's been a long time since I visited this code :) Patch works, you can also use a longer code in font entry, eg. <font type="Arial" name="Arial">/usr/...</font> also an old bug resurfaces, if you select oblique title in the layout, ERROR in koha-conf.xml -- missing <font type="ArialO">/path/to/font.ttf</font> See Bug 8375#c83 But it works :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 --- Comment #4 from Chris Nighswonger <cnighswonger@foundations.edu> --- The concept looks sound. I have no way of testing at the moment. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Chris Nighswonger from comment #3)

(In reply to David Cook from comment #0)

...

The label maker font list is hard-coded to 12 arbitrary choices.

FTR: These are not arbitrary. Rather they are 12 of the 14 basic fonts spec'd in the Adobe PDF standard. 13 of them are commonly found on postscript printers. Hence their hard-coding and inclusion as default fonts.

I'm creating this comment because some of this is arcane knowledge but important to inform future changes.

Thanks for the clarification, Chris! My apologies for calling them arbitrary. It might be worthwhile encoding that information in comments in the code even, as I could see this knowledge getting lost here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to David Cook from comment #5)

Yikes... can you tell me more about re-creating that one? I don't really understand from the comments on that bug.

Suppose you select Arial (code A) in a layout, and you set the checkbox for 'Oblique title', then C4/Labels/Label.pm will try to find an 'oblique' variant for your selected font by adding an 'O' or 'I' to the code, eg. Times Roman (code T) -> Times Roman Italic (code TI) Arial (code A) -> Arial oblique (code AO) Last code is undefined and you will find a warn in intranet logs, that's all, but the export will work Signed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Chris Nighswonger from comment #10)

An additional improvement would be to have the UI hide the oblique (italic) option if none is available for the font selected.

Good idea :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104505|0 |1 is obsolete| | --- Comment #13 from David Cook <dcook@prosentient.com.au> --- Created attachment 108377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108377&action=edit Bug 25384: Use koha-conf.xml to configure label maker font list This patch fetches the "ttf" element in koha-conf.xml, and looks for entries with a "name" attribute. If it's an existing default font, it will rename that font. If it's a new font, it will add it to the font list in the label creator pages. If you don't change anything in koha-conf.xml, then there is no behaviour change and the existing unit tests will all complete as normal. Test plan: 1) Apply patch 2) Edit koha-conf.xml and add a "name" attribute of "Times New Awesome" next to the font "type" "TR". 3) Edit koha-conf.xml and add the following entry to the "ttf" element: <font type="A" name="Arial">/usr/share/fonts/truetype/liberation/LiberationSans-Regular.ttf</font> 4) Clear memcached (if using memcached) a. e.g. echo 'flush_all' | nc -q 1 memcached 11211 5) Restart Plack (if using Plack) a. e.g. koha-plack --restart kohadev 6) Create or edit a Label maker layout a. e.g. /cgi-bin/koha/labels/label-edit-layout.pl?op=edit&element_id=17 7) Note that "Times-Roman" now says "Times New Awesome" instead 8) Note that there is now an "Arial" option at the bottom of the list 9) Try to export a label batch using a layout using "Arial" 10) Note that the text is output with a font style similar to Arial -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 --- Comment #16 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Fridolin SOMERS from comment #15)

Nice job ;)

Since default font in koha-conf.xml is "DejaVu", shouldn't we define it as default for font names, instead of MS-non-opensource fonts "Times-Roman", ... ?

DejaVu does not appear to be one of the 14 base fonts. Be careful about making this change before understanding how PDFs and these fonts relate. Here are a couple of resources: https://kbpdfstudio.qoppa.com/standard-14-pdf-fonts/ https://www.adobe.com/devnet/font.html Switching to a non-base font could cause problems on some systems. The pdf code in Koha is set to embed fonts which should avoid most potential issues. But we should be aware that defaulting to a non-base font "might" introduce an issue depending on the system used to open the resulting PDF. FTR: This is not an objection to Fridolin's suggestion. I'm all for cutting MS out of the picture altogether whenever possible. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 --- Comment #18 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to David Cook from comment #17)

(In reply to Fridolin SOMERS from comment #15)

...

Nice job ;)

Since default font in koha-conf.xml is "DejaVu", shouldn't we define it as default for font names, instead of MS-non-opensource fonts "Times-Roman", ... ?

I think that would be scope creep here, but I'm not opposed it overall. Except that end-users probably wouldn't understand what "DejaVu" means :/.

We may add a like to wiki https://en.wikipedia.org/wiki/DejaVu_fonts -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Manos PETRIDIS from comment #19)

Could https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 be related to the fonts used? I can't find any reference to fonts in my library's koha-conf.xml

MP

It should look something like this with the FONT_DIR replaced: https://git.koha-community.org/Koha-community/Koha/src/branch/master/etc/koh... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook@prosentient.com.au |cnighswonger@foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108377|0 |1 is obsolete| | --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 160390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160390&action=edit Bug 25384: Use koha-conf.xml to configure label maker font list This patch fetches the "ttf" element in koha-conf.xml, and looks for entries with a "name" attribute. If it's an existing default font, it will rename that font. If it's a new font, it will add it to the font list in the label creator pages. If you don't change anything in koha-conf.xml, then there is no behaviour change and the existing unit tests will all complete as normal. Test plan: 1) Apply patch 2) Edit koha-conf.xml and add a "name" attribute of "Times New Awesome" next to the font "type" "TR". 3) Edit koha-conf.xml and add the following entry to the "ttf" element: <font type="A" name="Arial">/usr/share/fonts/truetype/liberation/LiberationSans-Regular.ttf</font> 4) Clear memcached (if using memcached) a. e.g. echo 'flush_all' | nc -q 1 memcached 11211 5) Restart Plack (if using Plack) a. e.g. koha-plack --restart kohadev 6) Create or edit a Label maker layout a. e.g. /cgi-bin/koha/labels/label-edit-layout.pl?op=edit&element_id=17 7) Note that "Times-Roman" now says "Times New Awesome" instead 8) Note that there is now an "Arial" option at the bottom of the list 9) Try to export a label batch using a layout using "Arial" 10) Note that the text is output with a font style similar to Arial Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |dcook@prosentient.com.au |u | CC| |david@davidnind.com Text to go in the| |This enhancement lets you release notes| |configure the label maker | |font list by editing | |koha-conf.xml. It fetches | |the "ttf" element in | |koha-conf.xml, and looks | |for entries with a "name" | |attribute. | |- If it's an | |existing default font, it | |will rename that font. | |- If | |it's a new font, it will | |add it to the font list in | |the label creator pages. | |- | |If you don't change | |anything in koha-conf.xml, | |then there is no behaviour | |change. | | | |Note: To configure | |the name displayed in the | |label maker, add a name | |element in your | |koha-conf.xml in the <ttf> | |section (for example: | |name="Times New Roman"). To | |add a new font, add an | |entry in the <ttf> section | |(for example: <font | |type="A" | |name="Arial">/usr/share/fon | |ts/truetype/liberation/Libe | |rationSans-Regular.ttf</fon | |t>). --- Comment #24 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. The patches still apply. 2. Everything works as per the test plan. I was not sure about some of the later comments, so please feel free to change the status if any of these need addressing in this bug. I changed the assignee to David Cook, feel free to change it if that is no longer the case. I've had a go at the release notes - not sure that I've have got this right. Feel free to edit it! Just to confirm that I understand this change correctly. Before this patch, you couldn't configure how the font names were displayed (they were hard coded), but you could still add new fonts? This change now lets you configure how the fonts are displayed in the lists, and you can still add new fonts. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement lets you |This enhancement lets you release notes|configure the label maker |configure the label maker |font list by editing |font list and add new |koha-conf.xml. It fetches |fonts. It fetches the <ttf> |the "ttf" element in |section from koha-conf.xml, |koha-conf.xml, and looks |and looks for entries with |for entries with a "name" |a "name" attribute: |attribute. |- For |- If it's an |an existing default font, |existing default font, it |it will rename that font in |will rename that font. |the font list. |- If |- For a new |it's a new font, it will |font, it will add it to the |add it to the font list in |font list in the label |the label creator pages. |creator pages. |- |- If you |If you don't change |don't change anything in |anything in koha-conf.xml, |koha-conf.xml, then there |then there is no behaviour |is no behaviour change. |change. | | |Notes: |Note: To configure |1. To configure the |the name displayed in the |name displayed in the label |label maker, add a name |maker font list, add a name |element in your |element in koha-conf.xml to |koha-conf.xml in the <ttf> |the font in the <ttf> |section (for example: |section (for example: |name="Times New Roman"). To |name="Times New Roman"). |add a new font, add an |2. |entry in the <ttf> section |To add a new font, add an |(for example: <font |entry in the <ttf> section |type="A" |(for example: <font |name="Arial">/usr/share/fon |type="A" |ts/truetype/liberation/Libe |name="Arial">/usr/share/fon |rationSans-Regular.ttf</fon |ts/truetype/liberation/Libe |t>). |rationSans-Regular.ttf</fon | |t>). --- Comment #26 from David Nind <david@davidnind.com> --- (In reply to David Cook from comment #25)

Does that make sense?

Thanks David, it does! Have a good break over January. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 jennifer.meddings@kcpls.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jennifer.meddings@kcpls.org --- Comment #28 from jennifer.meddings@kcpls.org --- Just popping in to say that this feature (customizable font list in the label maker rather than the hardcoded options only) would really be a lifesaver for me! -- You are receiving this mail because: You are watching all bug changes.