https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17590 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Nick Clemens from comment #3)

(In reply to Fridolin Somers from comment #2)

...

Created attachment 120861 [details] [review] [review] Bug 28327: Add unit tests for Koha::Template::Plugin::Koha::CSVDelimiter

Run prove t/Koha_Template_Plugin_Koha.t

Why do you add the 'val' passthrough to the routine?

In case we use it with an existing value from DB. For example in CSV profile we store delimiter (not possible to store \t in DB I bet). So we may need to call this method in the future with a separator value, just to transform 'tabulation' into '\t'. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120859|0 |1 is obsolete| | Attachment #120861|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120867&action=edit Bug 28327: System preference CSVdelimiter special case for tabulation System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch fixed when preference is fetch in template. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120869&action=edit Bug 28327: (QA follow-up) Add POD -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Wait I have more patches ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120867|0 |1 is obsolete| | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 120870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120870&action=edit Bug 28327: System preference CSVdelimiter special case for tabulation in templates System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch fixed when preference is fetch in template. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 120872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120872&action=edit Bug 28327: System preference CSVdelimiter special case for tabulation in perl System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch fixed when preference is fetch in perl. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120869|0 |1 is obsolete| | --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 120874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120874&action=edit Bug 28327: (QA follow-up) Add POD -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120876|0 |1 is obsolete| | --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 120877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120877&action=edit Bug 28327: CSVdelimiter special case for tabulation in templates System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch fixed when preference is fetch in template. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 120879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120879&action=edit Bug 28327: CSVdelimiter special case for tabulation in perl System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch fixed when preference is fetch in perl. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 120881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120881&action=edit Bug 28327: (QA follow-up) Add POD -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Fridolin Somers from comment #21)

(In reply to Fridolin Somers from comment #9)

...

Wait I have more patches ;)

Here they are.

Tell me if your OK with semicolon ';' as default value since it is value in installer/data/mysql/mandatory/sysprefs.sql

If a library has the pref not set, this will change behavior - I would move that to its own bug -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120877|0 |1 is obsolete| | --- Comment #24 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 126682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126682&action=edit Bug 28327: CSVdelimiter special case for tabulation in templates System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch fixed when preference is fetch in template. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120879|0 |1 is obsolete| | --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 126684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126684&action=edit Bug 28327: CSVdelimiter special case for tabulation in perl System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch fixed when preference is fetch in perl. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #28 from Fridolin Somers <fridolin.somers@biblibre.com> --- Fixed a typo in "CSVdelimiter special case for tabulation in perl" and rebase on current master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126682|0 |1 is obsolete| | Attachment #126683|0 |1 is obsolete| | Attachment #126684|0 |1 is obsolete| | Attachment #126685|0 |1 is obsolete| | --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126964&action=edit Bug 28327: CSVdelimiter special case for tabulation in templates System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch fixed when preference is fetch in template. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126966&action=edit Bug 28327: CSVdelimiter special case for tabulation in perl System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch fixed when preference is fetch in perl. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It would have been better to have a new method in Koha.Config that could be called from all the other places as well: admin/aqplan.pl:$del = "\t" if $del eq 'tabulation'; misc/cronjobs/overdue_notices.pl: $sep_char = "\t" if ($sep_char eq 'tabulation'); misc/cronjobs/overdue_notices.pl: $delimiter = "\t" if $delimiter eq 'tabulation'; misc/export_borrowers.pl: $separator = "\t" if ($separator eq 'tabulation'); reports/acquisitions_stats.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/bor_issues_top.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/borrowers_out.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/borrowers_stats.pl:$sep = "\t" if ($sep and $sep eq 'tabulation'); reports/cash_register_stats.pl: $delimiter = "\t" if $delimiter eq 'tabulation'; reports/cat_issues_top.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/catalogue_stats.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/guided_reports.pl: $delimiter = "\t" if $delimiter eq 'tabulation'; reports/issues_avg_stats.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/issues_stats.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/orders_by_fund.pl: $sep = "\t" if ($sep eq 'tabulation'); reports/reserves_stats.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/serials_stats.pl:$sep = "\t" if ($sep eq 'tabulation'); t/Koha_Template_Plugin_Koha.t: is($plugin->CSVDelimiter(), "\t", "CSVDelimiter() returns \\t when preference is tabulation"); t/Koha_Template_Plugin_Koha.t: is($plugin->CSVDelimiter('tabulation'), "\t", "CSVDelimiter(arg) returns \\t value when arg is tabulation"); tools/viewlog.pl: $delimiter = "\t" if $delimiter eq 'tabulation'; With this patch we are adding yet one more occurrences... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---

From the third patch:

my $delimiter = C4::Context->preference('CSVDelimiter') || ';'; + $delimiter = "\t" if $delimiter eq 'tabulation'; my $delimiter = C4::Context->preference('CSVDelimiter') || ','; + $delimiter = "\t" if $delimiter eq 'tabulation'; + my $delimiter = C4::Context->preference('CSVDelimiter') || ','; + $delimiter = "\t" if $delimiter eq 'tabulation'; In addition to last comment of Jonathan, if we are adding a function now to control behavior, we should not need to 'fiddle' anymore like in the above lines. Call the function and thats it. Which probably means move the function out of the template plugin, and only leave a wrapper there. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #36 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 131996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131996&action=edit Bug 28327: Add unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #38 from Fridolin Somers <fridolin.somers@biblibre.com> --- I propose to add C4::Context->csv_delimiter. This changes patch a lot so I have squashed all of them before amending. Special thanks to you Nick for your help on this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126965|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126967|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #40 from Fridolin Somers <fridolin.somers@biblibre.com> --- Koha::Config::SysPref is an object representing an existing preference. How whould we call the new method ? Remember sometimes the separator value is already existing, we don't need the preference, just transform tabulation. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131997|0 |1 is obsolete| | --- Comment #43 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 136379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136379&action=edit Bug 28327: Unify CSV delimiter special behavior for tabulation System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch adds C4::Context->csv_delimiter to add a uniq metod dealing with this behavior. Also create Koha::Template::Plugin::Koha->CSVDelimiter for calls from Toolkit Templates. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' 4) Check with another delimiter -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136379|0 |1 is obsolete| | --- Comment #45 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 136381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136381&action=edit Bug 28327: Unify CSV delimiter special behavior for tabulation System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch adds C4::Context->csv_delimiter to add a uniq metod dealing with this behavior. Also create Koha::Template::Plugin::Koha->CSVDelimiter for calls from Toolkit Templates. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' 4) Check with another delimiter -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #47 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Nick Clemens from comment #46)

(In reply to Fridolin Somers from comment #45)

...

Created attachment 136381 [details] [review] [review] Bug 28327: Unify CSV delimiter special behavior for tabulation

It looks like you default to ';' but the majority of code you change defaulted to ',' - can you explain what made you choose seimcolon? I would think comma makes a better default

Mmm it is the default value in installer/data/mysql/mandatory/sysprefs.sql. Actual fallback values is often comma indeed :

git grep "CSVDelimiter') ||" | grep -v misc/translator/ koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/acqui/lateorders.tt:[%- SET delimiter = Koha.Preference('CSVDelimiter') || ',' -%] koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/catalogue/itemsearch.tt:[%- SET delimiter = Koha.Preference('CSVDelimiter') || ',' -%] misc/cronjobs/fines.pl:my $delim = "\t"; # ? C4::Context->preference('CSVDelimiter') || "\t"; misc/cronjobs/overdue_notices.pl: my $sep_char = C4::Context->preference('CSVDelimiter') || ';'; misc/cronjobs/overdue_notices.pl: my $delimiter = C4::Context->preference('CSVDelimiter') || ';'; misc/export_borrowers.pl: $separator = C4::Context->preference('CSVDelimiter') || ','; reports/bor_issues_top.pl:our $sep = $input->param("sep") || C4::Context->preference('CSVDelimiter') || ','; reports/cash_register_stats.pl: my $delimiter = C4::Context->preference('CSVDelimiter') || ','; reports/guided_reports.pl: my $delimiter = C4::Context->preference('CSVDelimiter') || ','; tools/viewlog.pl: my $delimiter = C4::Context->preference('CSVDelimiter') || ',';

May we change installer ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136380|0 |1 is obsolete| | --- Comment #49 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 136473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136473&action=edit Bug 28327: Add unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #51 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 136475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136475&action=edit Bug 28327: (follow-up) Comma as default CSV delimiter Looks like most of existing code wants comma as default value. Also impact installer/data/mysql/mandatory/sysprefs.sql. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136474|0 |1 is obsolete| | --- Comment #54 from David Nind <david@davidnind.com> --- Created attachment 136536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136536&action=edit Bug 28327: Unify CSV delimiter special behavior for tabulation System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch adds C4::Context->csv_delimiter to add a uniq metod dealing with this behavior. Also create Koha::Template::Plugin::Koha->CSVDelimiter for calls from Toolkit Templates. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' 4) Check with another delimiter Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the CSV export release notes| |so that data is correctly | |exported with a tab (\t) as | |the separator when this | |format is selected. This | |was incorrectly using the | |word 'tabulation' as the | |separator. (The default | |export format is set using | |the CSVdelimiter system | |preference.) In addition, | |the code where this is used | |was simplified (including | |several of the default | |reports, item search | |export, and the log | |viewer), and the default | |for CSVdelimiter was set to | |the comma separator. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136535|0 |1 is obsolete| | Attachment #136536|0 |1 is obsolete| | Attachment #136537|0 |1 is obsolete| | --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139479&action=edit Bug 28327: Add unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139513|0 |1 is obsolete| | --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139514&action=edit Bug 28327: Add unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139516&action=edit Bug 28327: (follow-up) Comma as default CSV delimiter Looks like most of existing code wants comma as default value. Also impact installer/data/mysql/mandatory/sysprefs.sql. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #62 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #64 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #65 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11 |22.11.00,22.05.06,21.11.12 released in| | --- Comment #67 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed the Versions from the comments. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34845 [Bug 34845] GetBasketGroupAsCSV.t is failing if the DB has been upgraded -- You are receiving this mail because: You are watching all bug changes.