https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101836|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 101849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101849&action=edit Bug 24988: Default to autorenew_checkouts for new patrons To recreate: 1 - Create a new patron on the staff interface 2 - Note that 'Allow auto-renewal of items' defaults to 'no' 3 - Apply patch 4 - Create another patron 5 - 'Allow auto-renewal of items' defaults to 'yes' Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 --- Comment #3 from Devinim <kohadevinim@devinim.com.tr> --- You are faster than us Nick! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kohadevinim@devinim.com.tr |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101863|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101888&action=edit Bug 24988: Default to autorenew_checkouts for new patrons To recreate: 1 - Create a new patron on the staff interface 2 - Note that 'Allow auto-renewal of items' defaults to 'no' 3 - Apply patch 4 - Create another patron 5 - 'Allow auto-renewal of items' defaults to 'yes' Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24476 CC| |dcook@prosentient.com.au Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 [Bug 24476] Allow patrons to opt-out of auto-renewal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I do not really understand why autorenewal should default to Yes. Suppose that you have set Autorenewal off for all your circ rules. And now you see allow auto-renewal popping up everywhere.. This is quite confusing. Imo we need more checks than just default to Yes. Who opens a bug report like 'auto_renewal should not default to Yes' ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #8)

I do not really understand why autorenewal should default to Yes.

I suspect most people would be in favour of autorenewal (I know I am as a library patron - very handy functionality), and it's more likely there would be a minority of people wanting to refuse it. Hence default to yes.

Suppose that you have set Autorenewal off for all your circ rules. And now you see allow auto-renewal popping up everywhere.. This is quite confusing. Imo we need more checks than just default to Yes.

As I noted on bug 24476, I don't think it's quite that simple. Even if all the autorenewals are turned off in the circ rules, you might have current checkouts that are still marked as autorenewal (which I think still get processed as autorenewals although I should double-check that), and you can choose to make an item an "Automatic renewal" by going into "Checkout settings" when checking out an item. I do agree though that it's complicated. On the surface, it seems silly to allow a patron to control an autorenewal setting if the library doesn't actually use autorenewals, but I think they're conceptually two different things. One is marking an item as an autorenewal, and the other is the patron allowing items to be autorenewed. (Of course, I wonder why a patron should be able to turn off autorenewal, but I don't really like how autorenewal has been implemented overall and how it prevents manual renewals. But that's another matter...) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #11)

(In reply to Marcel de Rooy from comment #8)

...

Who opens a bug report like 'auto_renewal should not default to Yes' ?

Does this seem like a productive question?

Heh. Thats a good point :) I am glad though that Nick already picked this up! Thanks for your feedback. Sometimes we should save our comment on Bugzilla a day or so, and decide not to submit it? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just got into this conversation... but why is this resolved fixed now? The bug report made sense to me? (must be missing something here) -- You are receiving this mail because: You are watching all bug changes.