[Bug 35096] New: ILL request manage page explodes if it belongs to a batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 Bug ID: 35096 Summary: ILL request manage page explodes if it belongs to a batch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com CC: katrin.fischer@bsz-bw.de, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com, tomascohen@gmail.com Depends on: 35094 To reproduce, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 9) You should now be seeing 'View ILL requests for batch <batch_name>' with the request you just added. 10) Click the request id (or the 'Manage request' button) 11) Notice it explodes Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35094 [Bug 35094] ILL new request is broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157339&action=edit Bug 35096: Fix batch accessor in ILL request page Test plan, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 9) You should now be seeing 'View ILL requests for batch <batch_name>' with the request you just added. 10) Click the request id (or the 'Manage request' button) 11) Notice you can view the request correctly, the batch it belongs to shows correctly and is clickable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35098 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098 [Bug 35098] ILL batch is not displayed in ILL table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157339|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 157365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157365&action=edit Bug 35096: Fix batch accessor in ILL request page Test plan, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 9) You should now be seeing 'View ILL requests for batch <batch_name>' with the request you just added. 10) Click the request id (or the 'Manage request' button) 11) Notice you can view the request correctly, the batch it belongs to shows correctly and is clickable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157365|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157420&action=edit Bug 35096: Fix batch accessor in ILL request page Test plan, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 9) You should now be seeing 'View ILL requests for batch <batch_name>' with the request you just added. 10) Click the request id (or the 'Manage request' button) 11) Notice you can view the request correctly, the batch it belongs to shows correctly and is clickable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another trivial fix to a major bug. QA scripts happy and code change is clear. Passing QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 Bug 35096 depends on bug 35094, which changed state. Bug 35094 Summary: ILL new request is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35094 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35096 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35094 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org