[Bug 31819] New: Formatting of item form in acq when ordering is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Bug ID: 31819 Summary: Formatting of item form in acq when ordering is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 30952 When creating a new order with items, the item form formatting is broken. Also the statistics fields at the bottom of the form are misaligned. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... and the item list needs the page-section class. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- https://snipboard.io/2k6ImK.jpg https://snipboard.io/c8AEjz.jpg -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 143137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143137&action=edit Bug 31819: Fix formatting of item form in acq when ordering To test: 1. Apply patch and regenerate CSS ( yarn build ) 2. Add to order from an empty record to an order, make sure the page looks good. 3. Add to order from an existing record to an order, make sure the page looks good. 4. In neworderempty.pl add some new items to the order by clicking 'Add item'. The item lists table should now appear, confirm it looks right. 5. Save the form, ensuring everthing still works as it should. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Some comments: 1. The forms seem to be aligned to the centre of the screen, rather than left aligned. 2. Form input field widths: I think these look odd being almost all the same width, particularly on the accounting details form for fields with numbers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143641&action=edit Original -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm.. we're going in the right direction, but it still feels a bit weird.. not sure flex 25% is the way to go.. as David points out.. on a wide screen it shifts the content to look 'centered' which feels a bit strange.. I think I'd rather see a more fixed width for all the labels... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143669&action=edit Bug 31819: [alternate] Formatting of item form in acq when ordering is broken I propose that we add CSS to the page to fix this since it's fairly specific to the way this page is broken. To test, apply the patch and view a basket in Acquisitions. - Click "Add to basket" and choose "From a new (empty) record." - Confirm that the item form layout looks correct. - Perform the same test when adding to a basket from an existing record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143680&action=edit Bug 31819: [alternate] Formatting of item form in acq when ordering is broken I propose that we add CSS to the page to fix this since it's fairly specific to the way this page is broken. To test, apply the patch and view a basket in Acquisitions. - Click "Add to basket" and choose "From a new (empty) record." - Confirm that the item form layout looks correct. - Perform the same test when adding to a basket from an existing record. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143681&action=edit Bug 31819: (QA follow-up) Fix alignment of Statistic fields at end of form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143669|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143683&action=edit Bug 31819: (QA follow-up) Add page section to list of items In order to test, you need to add items on order and add at least one to make the list appear above the item section -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143680|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143691&action=edit Bug 31819: [alternate] Formatting of item form in acq when ordering is broken I propose that we add CSS to the page to fix this since it's fairly specific to the way this page is broken. To test, apply the patch and view a basket in Acquisitions. - Click "Add to basket" and choose "From a new (empty) record." - Confirm that the item form layout looks correct. - Perform the same test when adding to a basket from an existing record. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143681|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143692&action=edit Bug 31819: (QA follow-up) Fix alignment of Statistic fields at end of form Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143683|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143693&action=edit Bug 31819: (QA follow-up) Add page section to list of items In order to test, you need to add items on order and add at least one to make the list appear above the item section Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Well.. these patches fix some things and improve some others.. I still think the page looks a bit weird but I can't really fail it for that. We can continue to refine next cycle. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Note that it's still messy when receiving - https://snipboard.io/FxMiK9.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32189 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #16)
Note that it's still messy when receiving - https://snipboard.io/FxMiK9.jpg
Filed separately as: Bug 32189 - When items are created on receive, item form layout is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819 Bug 31819 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org