https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #2 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Our patrons would love this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Here's what I tried today: https://zivotdesign.com/p/view.php?p=16143692116112 Using https://github.com/lindell/JsBarcode I think we'd have to create a system preference for defining what card type to use (CODE39, Codabar, UPC, etc). The selection could also be used to set the default in the patron card creator. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27825 [Bug 27825] Add preference for choosing the default format for patron barcodes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #6 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- +1 - really interested in this development. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Martin Renvoize from comment #7)

Is this something you're still experimenting with Owen?

I started working on Bug 27825 - Add preference for choosing the default format for patron barcodes - and got stalled. I don't recall what the sticking point was or if I just got redirected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Going to mark this one as a duplicate of bug 26692... *** This bug has been marked as a duplicate of bug 26692 *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- https://codelabs.developers.google.com/add-to-wallet-android#0 is interesting too -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- See Bug 25332 for talk about adding a library card to a smart phone wallet -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau@gmail.com --- Comment #14 from David Cook <dcook@prosentient.com.au> --- *** Bug 37118 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- (In reply to Roman Dolny from comment #15)

It would by nice to have a "Barcode" tab in OPAC accout with QR image generated from cardnumber.

I've accomplished something like this with a Koha plugin as I note on bug 37118. I'll have to look at sharing that plugin publicly... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #18 from Sam Lau <samalau@gmail.com> --- Created attachment 167970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167970&action=edit Bug 26777: Add JsBarcode library to Koha Adds necessary JS code to utilize JsBarcode -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #20 from Sam Lau <samalau@gmail.com> --- Created attachment 167972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167972&action=edit Bug 26777: Add new patron page 'My Virtual Card' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167976&action=edit Bug 26777: (follow-up) Adjust script, template, and CSS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |samalau@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #25 from Sam Lau <samalau@gmail.com> --- Created attachment 168030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168030&action=edit Bug 26777: (Follow-up) Allow ability to select diffferent barcode types -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #28 from Sam Lau <samalau@gmail.com> --- Created attachment 168166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168166&action=edit Bug 26777: Add barcode generator file and initial styling -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #30 from Sam Lau <samalau@gmail.com> --- Created attachment 168168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168168&action=edit Bug 26777: (follow-up) Adjust script, template, and CSS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #32 from Sam Lau <samalau@gmail.com> --- Created attachment 168170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168170&action=edit Bug 26777: Add bwip-js library to Koha bwip-js is the chosen library for generating and displaying barcodes in the OPAC. It allows for many different barcode types and customizable settings. This patch created a new directory and file for the js library code to live as well as updating the about.tt to give credit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #34 from Sam Lau <samalau@gmail.com> --- Created attachment 168172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168172&action=edit Bug 26777: Allow ability to select diffferent barcode types These cumalation of patches introduce a new patron page on the OPAC: "My virtual card." This page and its contents are reliant on the system preferences 'OPACVirtualCard' and 'OPACVirtualCardBarcode'. OPACVirutalCard determines whether the virtual card page is even displayed on the OPAC whereas OPACVirtualCardBarcode selects the type of barcode to display on this page (if page is displayed). Currently, the virtual card page consits of a patron image (if available), the patron's barcode, and the library name. A potential follow up would be to allow customization of this page. The barcode generation is handled by a new library bwip-js. To test: 1) Apply patch, updatedatabase, restart_all, build yarn 2) In system preferences, search for 'OPACVirtualCard'. Both this and the barcode sys. pref should show up with the same search. Notice they are dependent on one another. The default for the first pref should be "Don't allow". Leave this as is for now. 3) Leave the preference page open and log into the OPAC. Visit the user page. Notice that the navbar on the left consiting of 'Summary', 'Charges', etc. looks the same. 4) Go back to the sys. pref page and set the OPACVirtualCard to "Allow" 5) Also in the sys. prefs, make a search for "patron images" and set 'OPACpatronimages' to "Show" and 'patronimages' to allow. 6) Visit the patron's page that you used to sign in to the OPAC. Add a patron image if there is not one already. 7) Now, edit their details and change their card number to '00012345678905' 8) Venture back to the OPAC patron page. Refresh this and you should see a new "My Virtual Card" page at the bottom. 9) Click this page and you should see a new virtual card for you patron, consiting of their image, a barcode, and their library. 10) Open the dev tools for your browser and switch to vieiwing in mobile mode. Make sure the card looks good. This would likely be the most common use case. 11) Switch back to a system preference page and try playing around with the 'OPACVirtualCardBarcode'. Note that these changes affect the type of barcode that is display in the virtual card page. If you selected a barcode format that is incompatible, an error message should display in the virtual card page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168166|0 |1 is obsolete| | --- Comment #36 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 168290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168290&action=edit Bug 26777: Add barcode generator file and initial styling Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168168|0 |1 is obsolete| | --- Comment #38 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 168292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168292&action=edit Bug 26777: (follow-up) Adjust script, template, and CSS Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168170|0 |1 is obsolete| | --- Comment #40 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 168294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168294&action=edit Bug 26777: Add bwip-js library to Koha bwip-js is the chosen library for generating and displaying barcodes in the OPAC. It allows for many different barcode types and customizable settings. This patch created a new directory and file for the js library code to live as well as updating the about.tt to give credit. Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168172|0 |1 is obsolete| | --- Comment #42 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 168296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168296&action=edit Bug 26777: Allow ability to select diffferent barcode types These cumalation of patches introduce a new patron page on the OPAC: "My virtual card." This page and its contents are reliant on the system preferences 'OPACVirtualCard' and 'OPACVirtualCardBarcode'. OPACVirutalCard determines whether the virtual card page is even displayed on the OPAC whereas OPACVirtualCardBarcode selects the type of barcode to display on this page (if page is displayed). Currently, the virtual card page consits of a patron image (if available), the patron's barcode, and the library name. A potential follow up would be to allow customization of this page. The barcode generation is handled by a new library bwip-js. To test: 1) Apply patch, updatedatabase, restart_all, build yarn 2) In system preferences, search for 'OPACVirtualCard'. Both this and the barcode sys. pref should show up with the same search. Notice they are dependent on one another. The default for the first pref should be "Don't allow". Leave this as is for now. 3) Leave the preference page open and log into the OPAC. Visit the user page. Notice that the navbar on the left consiting of 'Summary', 'Charges', etc. looks the same. 4) Go back to the sys. pref page and set the OPACVirtualCard to "Allow" 5) Also in the sys. prefs, make a search for "patron images" and set 'OPACpatronimages' to "Show" and 'patronimages' to allow. 6) Visit the patron's page that you used to sign in to the OPAC. Add a patron image if there is not one already. 7) Now, edit their details and change their card number to '00012345678905' 8) Venture back to the OPAC patron page. Refresh this and you should see a new "My Virtual Card" page at the bottom. 9) Click this page and you should see a new virtual card for you patron, consiting of their image, a barcode, and their library. 10) Open the dev tools for your browser and switch to vieiwing in mobile mode. Make sure the card looks good. This would likely be the most common use case. 11) Switch back to a system preference page and try playing around with the 'OPACVirtualCardBarcode'. Note that these changes affect the type of barcode that is display in the virtual card page. If you selected a barcode format that is incompatible, an error message should display in the virtual card page. Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- *** Bug 26692 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168289|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169742&action=edit Bug 26777: Added new sys pref 'OPACVirtualCard' Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168291|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169744&action=edit Bug 26777: Add new patron page 'My Virtual Card' Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168293|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169746&action=edit Bug 26777: (follow-up) Fix file permssions and tidy Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168295|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169748&action=edit Bug 26777: Add new system preference 'OPACVirtualCardBarcode' Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35402 --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This needs a rebase, probably because of bug 35402. Please fix, it will appear back on top of my queue then. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169743|0 |1 is obsolete| | --- Comment #56 from Sam Lau <samalau@gmail.com> --- Created attachment 170668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170668&action=edit Bug 26777: Add barcode generator file and initial styling Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169745|0 |1 is obsolete| | --- Comment #58 from Sam Lau <samalau@gmail.com> --- Created attachment 170670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170670&action=edit Bug 26777: (follow-up) Adjust script, template, and CSS Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169747|0 |1 is obsolete| | --- Comment #60 from Sam Lau <samalau@gmail.com> --- Created attachment 170672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170672&action=edit Bug 26777: Add bwip-js library to Koha bwip-js is the chosen library for generating and displaying barcodes in the OPAC. It allows for many different barcode types and customizable settings. This patch created a new directory and file for the js library code to live as well as updating the about.tt to give credit. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169749|0 |1 is obsolete| | --- Comment #62 from Sam Lau <samalau@gmail.com> --- Created attachment 170674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170674&action=edit Bug 26777: Allow ability to select diffferent barcode types These cumalation of patches introduce a new patron page on the OPAC: "My virtual card." This page and its contents are reliant on the system preferences 'OPACVirtualCard' and 'OPACVirtualCardBarcode'. OPACVirutalCard determines whether the virtual card page is even displayed on the OPAC whereas OPACVirtualCardBarcode selects the type of barcode to display on this page (if page is displayed). Currently, the virtual card page consits of a patron image (if available), the patron's barcode, and the library name. A potential follow up would be to allow customization of this page. The barcode generation is handled by a new library bwip-js. To test: 1) Apply patch, updatedatabase, restart_all, build yarn 2) In system preferences, search for 'OPACVirtualCard'. Both this and the barcode sys. pref should show up with the same search. Notice they are dependent on one another. The default for the first pref should be "Don't allow". Leave this as is for now. 3) Leave the preference page open and log into the OPAC. Visit the user page. Notice that the navbar on the left consiting of 'Summary', 'Charges', etc. looks the same. 4) Go back to the sys. pref page and set the OPACVirtualCard to "Allow" 5) Also in the sys. prefs, make a search for "patron images" and set 'OPACpatronimages' to "Show" and 'patronimages' to allow. 6) Visit the patron's page that you used to sign in to the OPAC. Add a patron image if there is not one already. 7) Now, edit their details and change their card number to '00012345678905' 8) Venture back to the OPAC patron page. Refresh this and you should see a new "My Virtual Card" page at the bottom. 9) Click this page and you should see a new virtual card for you patron, consiting of their image, a barcode, and their library. 10) Open the dev tools for your browser and switch to vieiwing in mobile mode. Make sure the card looks good. This would likely be the most common use case. 11) Switch back to a system preference page and try playing around with the 'OPACVirtualCardBarcode'. Note that these changes affect the type of barcode that is display in the virtual card page. If you selected a barcode format that is incompatible, an error message should display in the virtual card page. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #65 from David Cook <dcook@prosentient.com.au> --- I wanted to thoroughly test this but ran out of time chasing a different bug... Just wanted to point out that you almost never want to use innerHTML() for setting a value. It's a good way to accidentally introduce a XSS vulnerability. Look at OWASP documents for preventing Cross-Site Scripting (XSS). In this case, I think that you're mostly, as it seems unlikely someone could slip XSS in through the SVG. I'm more worried about the error message, which appears to be broken anyway... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #66 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #63)

3) Translatability

This is untranslatable: + document.getElementById('barcode-container').innerHTML = `<p><strong>Error: </strong>${errorMessage}</p>`;

Also, strings should always be enclosed using double quotes. That's so that languages using single quotes like French don't break the JS by accident. See: JS2: Enabling translation of language strings in embedded JavaScript

So this was using a template literal, which I thought the translations could use? Personally, I quite like template literals, but using innerHTML here was a good way to potentially introduce XSS via the errorMessage... (although it would need to come from the third party Javascript in this case which is probably unlikely but still better to be safe than sorry...)

I attached a follow-up patch.

The follow-up patch accidentally broke the errorMessage display, since it retained the template literal syntax for errorMessage. See bug 37742. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #67)

(In reply to David Cook from comment #66)

...

The follow-up patch accidentally broke the errorMessage display, since it retained the template literal syntax for errorMessage. See bug 37742.

Btw, while I fix this in bug 37742, I don't think that we should actually show the error message to patrons. If we're going to show an error message, it would probably be better to say "Failed to generate barcode" or something like that.

A user doesn't need to see "Code 39 must contain only digits, capital letters, spaces and the symbols -.$/+%"

Sorry for breaking it. :( I did check for JS errors, and didn't see any, but that was not enough. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38791 [Bug 38791] Update virtual card templates to follow template standards -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Aude Charillon contact| | CC| |aude.charillon@openfifth.co | |.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1027 -- You are receiving this mail because: You are watching all bug changes.