[Bug 9044] New: Allow to select items on catalogue/detail.pl and trigger actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Priority: P5 - low Change sponsored?: --- Bug ID: 9044 CC: m.de.rooy@rijksmuseum.nl Assignee: julian.maurice@biblibre.com Summary: Allow to select items on catalogue/detail.pl and trigger actions Severity: enhancement Classification: Unclassified OS: All Reporter: julian.maurice@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Cataloging Product: Koha Some libraries with a high number of items per record sometimes want to modify a batch of items (not all items of this record at once). So this development add a checkboxes column for selecting items and trigger actions on them (currently only batch deletion and batch modification). With bug 9034, this will allow filtering -> selecting -> batch processing items of a record quite quickly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13344&action=edit Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification These actions replace the two menu entries corresponding to the same action. Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13344|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13513&action=edit Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification These actions replace the two menu entries corresponding to the same action. Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13513|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13933&action=edit Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification These actions replace the two menu entries corresponding to the same action. Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Please resolve merge conflict on template. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13933|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 14737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14737&action=edit [SIGNED-OFF] Bug 9044: Provide item selection in record detail page (staff client) Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m, oleonard@myacpl.org --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Owen, Could I have your opinion on this patch please? Do you think it is a good idea to remove actions for items (delete and edit) from the toolbar? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #6)
Do you think it is a good idea to remove actions for items (delete and edit) from the toolbar?
I don't think it's a good idea. I think there's no reason not to remove an option which may be in use by Koha users, and for those who want to quickly edit or delete all items it is fewer clicks than manually selecting from the table of holdings. Other minor changes I would like to see: - Adding a blank option to the "action" menu so that (at least in English) "Delete selected items" isn't the default. - Add a "for" attribute to the "Action" label to make it clickable. - Add a label to the "Open in new window" text to make it clickable. Those could be handled in a follow-up, but I wouldn't like to see this pushed with the toolbar button options missing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Julian, could you take care of Owen's comments please? Thx! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16612&action=edit Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14737|0 |1 is obsolete| | --- Comment #10 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16707&action=edit [SIGNED-OFF] Bug 9044: Provide item selection in record detail page (staff client) Rebased -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16612|0 |1 is obsolete| | --- Comment #11 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16708&action=edit Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Rebased -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Pierre Angot et Leila Arkab <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16711&action=edit Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Signed-off-by: Pierre Angot et Leila Arkab <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16708|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, testing this I have am a little worried about a few things in this approach: 1) These patches remove the batch edit and delete options from the Edit menu, but the system preference added is by default off. So we actually take away a feature with the update. 2) The interface seems not quite right to me. Instead of having to select an option from a pull down and then click on go, I think having 2 links instead would save one click and be less fiddly. 3) The first column has the little arrow for sorting, but sorting doesn't work, whether you have seleted checkboxes or not. Also if you activate the filters, it has an added search box that doesn't make sense for this column. Failing for 1) and 3). My personal opinion is that it would be nice to deal with it like with the "activate filters" option. So it's not a "all or nothing" option using the system preference as only switch, but also something people can choose to activate easily on demand. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 5) Oh, before I forget: I had added the bug number to the database update when fixing the conflicts. Please add it when you do a follow-up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19060&action=edit Bug 9044: QA followup 1/ Remove filter and sort for the checkboxes column. 2/ Enable the pref by default. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #14)
Hm, testing this I have am a little worried about a few things in this approach:
1) These patches remove the batch edit and delete options from the Edit menu, but the system preference added is by default off. So we actually take away a feature with the update.
2) The interface seems not quite right to me. Instead of having to select an option from a pull down and then click on go, I think having 2 links instead would save one click and be less fiddly.
3) The first column has the little arrow for sorting, but sorting doesn't work, whether you have seleted checkboxes or not. Also if you activate the filters, it has an added search box that doesn't make sense for this column.
Failing for 1) and 3).
1 and 3 fixed with the qa followup. For 2, the idea is to add others actions in this drop-down list. So it will be difficult to deal with more than 2 links. Back to Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What other actions do you have in mind? I think unless we really have another idea there would be no reason to overcomplicate the interface. Maybe we could ask Owen nicely to take a look. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #18)
What other actions do you have in mind?
No one for now :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think change the display when we actually have more options :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19344&action=edit Bug 9044: Change dropdown list into links list -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> --- Note that links are rebuild each time a checkbox is changed, so actions links point to valid URL and can be opened in a new window if your browser permit it (right click -> open in a new window) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Applying: Bug 9044: Provide item selection in record detail page (staff client) Applying: Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Applying: Bug 9044: QA followup fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9044: QA followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16707|0 |1 is obsolete| | --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19913&action=edit [SIGNED-OFF] Bug 9044: Provide item selection in record detail page (staff client) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16711|0 |1 is obsolete| | --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19914&action=edit [SIGNED-OFF] Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Signed-off-by: Pierre Angot et Leila Arkab <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19060|0 |1 is obsolete| | --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19915&action=edit [SIGNED-OFF] Bug 9044: QA followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19344|0 |1 is obsolete| | --- Comment #27 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19916&action=edit [SIGNED-OFF] Bug 9044: Change dropdown list into links list -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19916|[SIGNED-OFF] Bug 9044: |Bug 9044: Change dropdown description|Change dropdown list into |list into links list |links list | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #28 from Julian Maurice <julian.maurice@biblibre.com> --- All patches rebased on master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #29 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 9044: Provide item selection in record detail page (staff client) Using index info to reconstruct a base tree... M catalogue/detail.pl M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging catalogue/detail.pl Patch failed at 0001 Bug 9044: Provide item selection in record detail page (staff client) The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19913|0 |1 is obsolete| | --- Comment #30 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21324&action=edit [SIGNED-OFF] Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification These actions replace the two menu entries corresponding to the same action. Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19914|0 |1 is obsolete| | --- Comment #31 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21325&action=edit [SIGNED-OFF] Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Signed-off-by: Pierre Angot et Leila Arkab <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19915|0 |1 is obsolete| | --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21326&action=edit [SIGNED-OFF] Bug 9044: QA followup 1/ Remove filter and sort for the checkboxes column. 2/ Enable the pref by default. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19916|0 |1 is obsolete| | --- Comment #33 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21327&action=edit Bug 9044: Change dropdown list into links list -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #34 from Julian Maurice <julian.maurice@biblibre.com> --- All patches rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-24 last check this| | --- Comment #35 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21324|0 |1 is obsolete| | --- Comment #36 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21561&action=edit [SIGNED-OFF] Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification These actions replace the two menu entries corresponding to the same action. Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21325|0 |1 is obsolete| | --- Comment #37 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21562&action=edit [SIGNED-OFF] Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Signed-off-by: Pierre Angot et Leila Arkab <tredok.pierre@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21326|0 |1 is obsolete| | --- Comment #38 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21563&action=edit [SIGNED-OFF] Bug 9044: QA followup 1/ Remove filter and sort for the checkboxes column. 2/ Enable the pref by default. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21327|0 |1 is obsolete| | --- Comment #39 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21564&action=edit [SIGNED-OFF] Bug 9044: Change dropdown list into links list Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> That's the one I sign. Comment: At first I don't know where to find links, until I selected an item. Works as described. No koha-qa errors. Solved merge conflict on updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21591&action=edit Screnshot, search filters for materials and barcode are broken. I think this is very close to ready, but there is a problem with the search filters (see screenshot). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I verified the search filters show correctly for all columns on master. Apart from that I found no problems - also tested with SeparateHoldings and SeparateHoldingsBranch. Please provide a follow-up! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #42 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21634&action=edit Bug 9044: Set the number of filters according to number of columns -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #43 from Julian Maurice <julian.maurice@biblibre.com> --- Simple patch, easy to signoff :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21634|0 |1 is obsolete| | --- Comment #44 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21683&action=edit [SIGNED-OFF] Bug 9044: Set the number of filters according to number of columns Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Filters now shows correctly. No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21561|0 |1 is obsolete| | Attachment #21562|0 |1 is obsolete| | Attachment #21563|0 |1 is obsolete| | Attachment #21564|0 |1 is obsolete| | Attachment #21683|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21745&action=edit [PASSED QA] Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification These actions replace the two menu entries corresponding to the same action. Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Further testing notes on last patch. http://bugs.koha-community.org/show_bug.cgi?id=9055 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21746&action=edit [PASSED QA] Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Signed-off-by: Pierre Angot et Leila Arkab <tredok.pierre@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21747&action=edit [PASSED QA] Bug 9044: QA followup 1/ Remove filter and sort for the checkboxes column. 2/ Enable the pref by default. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21748&action=edit [PASSED QA] Bug 9044: Change dropdown list into links list Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> That's the one I sign. Comment: At first I don't know where to find links, until I selected an item. Works as described. No koha-qa errors. Solved merge conflict on updatedatabase.pl Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21749&action=edit [PASSED QA] Bug 9044: Set the number of filters according to number of columns Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Filters now shows correctly. No errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. This feature is a little controversial as it removes the batch edit/delete options from the menu and moves them to the item table, additionally controlled by a system preference. Maybe later on, we can think about the UI a bit more, but it works nicely. Tested with. - SeparateHoldings and SeparateHoldingsBranch activated/deactivated. - Search filters. - None, both, or one of the permissions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_14_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #50 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks Julian! I also pushed a follow-up that adds the toolbar menu items back. From the commit message: My rationale: the question of the best UI for selecting items for batch operations is not yet settled. Adding the ability to select items from the bib details page is indeed useful, but as currently implemented, it can hide the availability of the batch edit/deletion operations if no item is yet selected. Although having both the toolbar items and the links that display when an item is selected is a bit redundant, for now I think we can live with that until we get more eyes on the UI. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11475 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org