[Bug 29104] New: Add new columns to table_borrowers column configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Bug ID: 29104 Summary: Add new columns to table_borrowers column configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: bibliwho@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The present options under columns_settings.pl for the table_borrowers table are name, cardnumber, date_of_birth, category, library, address, & phone. It would be helpful to have the dateexpiry column available for display as well. Others may have prefer additional columns as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add new columns to |Add dateexpiry column to |table_borrowers column |circulation patron search |configuration |results Severity|trivial |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 125249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125249&action=edit Bug 29104: Add date expiry column to patron search borrower table Test plan: 1. Apply patch 2. The new dateexpiry column will be hidden by default, go to table settings and expose it (table_borrowers) 3. Do a patron search that will return multiple patrons, you should see the date expiry column 4. Make the date displays correctly right with different dateformats 5. Make sure that the column, and other columns in that table, can be correctly hidden via table settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Hi, Looks great. Just a few thoughts :
3. Do a patron search that will return multiple patrons, you should see the date expiry column You should tell to use the "Check out" form. To not mistake with "Search patrons" form.
Column name is 'Date expiry'. We see in patrons module the name 'Expires on'. I propose we use the same name. There is an issue, column sorting is not on date (if you don't use the ISO format). This is because formatting is done in perl code : https://git.koha-community.org/Koha-community/Koha/src/commit/870e3e8e161f6d... See the FIXME. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15812 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oh see that this will be obsolete if Bug 15812 is pushed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 --- Comment #4 from Cab Vinton <bibliwho@gmail.com> --- Unable to test on sandbox.bywatersolutions.com. Tested on biblibre.eu sandbox. Patch failed to apply: Bug 29104 - Add dateexpiry column to circulation patron search results 125249 - Bug 29104: Add date expiry column to patron search borrower table Applying: Bug 29104: Add date expiry column to patron search borrower table Apply? [(y)es, (n)o, (i)nteractive] C4::Installer::run_atomic_updates(): DBI Exception: DBD::mysql::db do failed: Duplicate column name 'ft_local_float_group' at koha/installer/data/mysql/updatedatabase.pl line 24298 DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_28854.perl [04:23:38] DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/Bug-9525-Add_ft_local_float_group_column.perl [04:23:38] ERROR - C4::Installer::run_atomic_updates(): DBI Exception: DBD::mysql::db do failed: Duplicate column name 'ft_local_float_group' at koha/installer/data/mysql/updatedatabase.pl line 24298 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org