https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87225&action=edit Bug 22611: Correction for typo in Koha::EDI A typo in Koha::EDI leads to 'The method is not tested' errors to be thrown when the codepath is taken and can lead to subsequent data corruption. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87225|0 |1 is obsolete| | CC| |colin.campbell@ptfs-europe. | |com --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 87271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87271&action=edit patch to make test consistent with initial copy In addition to the typo, the patch used a different call to for subsequent copies to the initial copy. That could create confusion in the future -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87271|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87326&action=edit Bug 19380: Use Koha::Item::get_transfer instead of GetTransfers Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Attachment #87326|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87225|0 |1 is obsolete| | --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- Comment on attachment 87225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87225 Bug 22611: Correction for typo in Koha::EDI Sorry I'm making a lot of noise >.< -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87327|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87333&action=edit Bug 22611: Correction for call to get create_item in EDI.pm There was a typo in the addition of a call to effective_create_items causing processing to abort after adding a single copy. This patch reverts to using the C4::Context call as used for the first copy created, the intended call to effective_create_items is a wrapper around that as the field in the basket is guaranteed to be null (its not set when we call AddBasket). Being consistent and explicit in what we call should guard against future changes in dependencies exposing the logic flaw Added some comments to make logical flow of code clearer Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |master, 18.11.05 released in| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes.