[Bug 13050] New: Follow-up for bug 12371
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 Bug ID: 13050 Summary: Follow-up for bug 12371 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 32080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32080&action=edit Bug 13050: Follow-up for bug 12371 This patch simplifies the SQL query in Letters.pm for table borrower_modifications. It also addresses the only case this query is used in opac-memberentry. An unused variable in Letters.pm is removed. Test plan: Enable selfregistration on opac. Set verification by email to required in prefs too. Self-register two new users. Check the email notices generated. Verify the new users with the tokens in their notice. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12371 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Follow-up for bug 12371 |Follow-up for bug 12371 on | |self-registration | |verification notice -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32080|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32750&action=edit Bug 13050: Follow-up for bug 12371 This patch simplifies the SQL query in Letters.pm for table borrower_modifications. It also addresses the only case this query is used in opac-memberentry. An unused variable in Letters.pm is removed. Test plan: Enable selfregistration on opac. Set verification by email to required in prefs too. Self-register two new users. Check the email notices generated. Verify the new users with the tokens in their notice. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Much cleaner SQL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32750|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32772&action=edit [PASSED QA] Bug 13050: Follow-up for bug 12371 This patch simplifies the SQL query in Letters.pm for table borrower_modifications. It also addresses the only case this query is used in opac-memberentry. An unused variable in Letters.pm is removed. Test plan: Enable selfregistration on opac. Set verification by email to required in prefs too. Self-register two new users. Check the email notices generated. Verify the new users with the tokens in their notice. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Much cleaner SQL Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Cleaner and works as described, no regressions found. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org