[Bug 19831] New: Turn on EnhancedMessagingPreferences by default for new installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Bug ID: 19831 Summary: Turn on EnhancedMessagingPreferences by default for new installations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com I think we should not hide the different messaging options for new installations and turn on EnhancedMessagingPreferences by default on installation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Charlotte Cordwell <charlotte.cordwell123@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 --- Comment #1 from Charlotte Cordwell <charlotte.cordwell123@gmail.com> --- Created attachment 70536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70536&action=edit Bug 19832:Turn on EnhancedMessagingPreferences by default for new installations 1)Create a new installation 2)On staff go adminisation --> and search EnchancedMessagingPreferences 3)Check that it is automaticaly on allow. If it is the it has worked. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |charlotte.cordwell123@gmail |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70536|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 70553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70553&action=edit Bug 19832: Turn on EnhancedMessagingPreferences by default for new installations Test plan: 1) Create a new installation 2) On staff go adminisation --> and search EnchancedMessagingPreferences 3) Check that it is automaticaly on allow. If it is the it has worked. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 --- Comment #3 from Charlotte Cordwell <charlotte.cordwell123@gmail.com> --- Created attachment 70569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70569&action=edit Bug 19831:Turn on EnhancedMessagingPreferences by default for new installations 1)Create a new installation 2)On staff go adminisation --> and search EnchancedMessagingPreferences 3)Check that it is automaticaly on allow. If it is the it has worked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Charlotte Cordwell from comment #3)
Created attachment 70569 [details] [review] Bug 19831:Turn on EnhancedMessagingPreferences by default for new installations 1)Create a new installation 2)On staff go adminisation --> and search EnchancedMessagingPreferences 3)Check that it is automaticaly on allow. If it is the it has worked.
Why did you submit the patch again ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70553|0 |1 is obsolete| | Attachment #70569|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 70621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70621&action=edit Bug 19831: Turn on EnhancedMessagingPreferences by default for new installations Test plan: 1) Create a new installation 2) On staff go adminisation --> and search EnchancedMessagingPreferences 3) Check that it is automaticaly on allow. If it is the it has worked. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4)
(In reply to Charlotte Cordwell from comment #3)
Created attachment 70569 [details] [review] [review] Bug 19831:Turn on EnhancedMessagingPreferences by default for new installations 1)Create a new installation 2)On staff go adminisation --> and search EnchancedMessagingPreferences 3)Check that it is automaticaly on allow. If it is the it has worked.
Why did you submit the patch again ?
Oh I see. Wrong bugnumber. I corrected the signed patch, because resubmitting the original one would result in loosing the signoff. (As well as additional editing; your test plan is on one line.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- As EnhancedMessagingPreferencesOPAC is turned on by default, it will affect the OPAC too, is it wanted? I would say yes, but I prefer someone else to confirm. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7)
As EnhancedMessagingPreferencesOPAC is turned on by default, it will affect the OPAC too, is it wanted? I would say yes, but I prefer someone else to confirm.
Yes, I think that is a logical step. To compare, the dbrev initialized the opac pref with the same value as the staff counterpart. A new install now does the same, while enabling them is probably preferred. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05 Thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Enhancement, not backported for 17.11. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org