[Bug 11207] New: Impossibility to remove a sms number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Bug ID: 11207 Summary: Impossibility to remove a sms number Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To reproduce: 1/ edit a patron 2/ set a sms alert number 3/ save 4/ edit the patron 5/ try to remove the sms alert number -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22748&action=edit Bug 11207: No way to remove a sms alert number Test plan: 1/ edit a patron 2/ set a sms alert number 3/ save 4/ edit the patron 5/ set the sms alert number to a blank value 6/ save 7/ the sms number is now an empty string -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Note: I don't understand the other test $input->param('SMSnumber') ne $newdata{'mobile'} -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22748|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 22935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22935&action=edit [SIGNED-OFF] Bug 11207: No way to remove a sms alert number Test plan: 1/ edit a patron 2/ set a sms alert number 3/ save 4/ edit the patron 5/ set the sms alert number to a blank value 6/ save 7/ the sms number is now an empty string Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but I can't reproduce the problem on current master. I have - activated the SMS functionality by giving a 'fake' SMSSendDriver of TEST - activated EnhancedMessagingPreferences - created a new patron, set sms number to 'test' - edited the patron and deleted 'test' - after saving it's gone and deleted from the database -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Katrin, I forgot something: If you edit the patron, the mobile number (other phone) has to be empty. If you fill it, you can delete the sms number. The bug is always reproducible on editing the step 5 (messaging pref) only: /members/memberentry.pl?op=modify&borrowernumber=XXXX&step=5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I created a new patron so I am sure mobile was empty and I think I used the link on the page to only edit the prefs and not the 'full' patron - but I will give it another try. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22935|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23056&action=edit [PASSED QA] Bug 11207: No way to remove a sms alert number Test plan: 1/ edit a patron 2/ set a sms alert number 3/ save 4/ edit the patron 5/ set the sms alert number to a blank value 6/ save 7/ the sms number is now an empty string Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Test plan used: - Activate the SMS functionality by giving a 'fake' SMSSendDriver of TEST - Activate EnhancedMessagingPreferences - Create a new patron, set Other phone to 'test' - Notice that Other phone was copied to sms number - Edit messaging preference section using the edit link below on the details tab and delete SMS number - Verify it's not possible to unset the SMS number - Apply patch - Repeat deleting - this time it works -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org