[Bug 26585] New: Cataloguing interface throws JS errors on load
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26585 Bug ID: 26585 Summary: Cataloguing interface throws JS errors on load Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Browser compatibility Assignee: alexbuckley@catalyst.net.nz Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Bug 8643 introduced the 'mandatory' default parameter into addbiblio.tt function AreFieldsNotOk (mandatory = true) { This works fine in Chrome and Firefox, but Internet Explorer 11 does not allow default parameters and errors with: Expected ')' See https://stackoverflow.com/questions/42768964/proper-way-to-define-default-va... We should not use default parameters which error in IE, and instead set a default value for mandatory inside the function body. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26585 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Alex, not opposed to a fix, but we have recently decided to no longer officially support IE as even Microsoft seems to be pushing for Edge in older Windows versions (from what I understood from discussion, see bug 26305) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26585 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Katrin, thank you very much for noting that - I wasn't aware that decision had been made. It does make a lot of sense to stop supporting IE at this point, given Microsoft is. I think I'll close this ticket off. Just because we believe if libraries do want to continue using Koha in IE then any fixes to do so should really be customisations rather than asking the community to maintain them. Thanks again Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26585 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Alex Buckley from comment #2)
Hi Katrin, thank you very much for noting that - I wasn't aware that decision had been made. It does make a lot of sense to stop supporting IE at this point, given Microsoft is.
I think I'll close this ticket off. Just because we believe if libraries do want to continue using Koha in IE then any fixes to do so should really be customisations rather than asking the community to maintain them.
Thanks again Alex
Sounds good! At some point, I'm going to finish off Bug 26305, which might help make the collective understanding of not supporting IE anymore more consistent. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org