[Bug 9034] New: Add sorting and filtering on items table (catalogue/detail.pl)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Priority: P5 - low Change sponsored?: --- Bug ID: 9034 CC: m.de.rooy@rijksmuseum.nl Assignee: julian.maurice@biblibre.com Summary: Add sorting and filtering on items table (catalogue/detail.pl) Severity: enhancement Classification: Unclassified OS: All Reporter: julian.maurice@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Cataloging Product: Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13310&action=edit Bug 9034: Add sorting and filtering on items table (catalogue/detail.pl) This patch introduces a new javascript plugin for dataTables (columnFilter). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- After applying this patch the detail page has a horizontal scroll bar if my browser windows is below 1800px. Is there a way to accomplish the goal of this patch without compromising the compactness and flexibility of the current layout? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13338&action=edit Bug 9034: Add CSS rule to reduce width of items table -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- I tested it with a browser window width reduced to 1280px -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13310|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13345&action=edit [SIGNED-OFF] Bug 9034: Add sorting and filtering on items table (catalogue/detail.pl) This patch introduces a new javascript plugin for dataTables (columnFilter). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13338|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13346&action=edit [SIGNED-OFF] Bug 9034: Add CSS rule to reduce width of items table Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Tested, looks good. I don't know if everyone is going to want the column filters. Maybe there should be a threshold number of items a bib needs for it to kick in? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13368&action=edit Bug 9034 [Follow-up] Add sorting and filtering on items table (catalogue/detail.pl) This follow-up to the original patch offers an alternative method to handle the width of the table and form fields: - Reduce the font size of the filter input fields - Make the filter inputs' width 100% instead of fixed - Add "'bAutoWidth': false" to the datatables initialization to prevent the table width from being set to the browser window width on load. This allows the browser to be re-sized and have the table re-flow with it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- I offer an alternative to the "CSS rule" patch for consideration. I agree with Kyle in thinking that probably not everyone is going to want column filters. My first thought was also to define a threshold to control it. Was this feature requested based on a collection with a large number of items per bib? Perhaps if we understood the motivation for wanting this feature we could better understand how to make it work for everyone. -- You are receiving this mail because: You are watching all bug changes.
- Make the filter inputs' width 100% instead of fixed I always had problems with this (input overflow the cell), but if it works i
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- prefer this solution ;-) The initial need was only to filter on "serial info" column for biblios linked to a subscription (so a large number of items), and then go to batch modification/deletion. I separated this into two bugs: this one and bug 9044 which allow to select items and go to batch modification/deletion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13345|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 14491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14491&action=edit [SIGNED-OFF] Bug 9034: Add sorting and filtering on items table (catalogue/detail.pl) Rebased on master Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13346|0 |1 is obsolete| | --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 14492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14492&action=edit [SIGNED-OFF] Bug 9034: Add CSS rule to reduce width of items table Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13368|0 |1 is obsolete| | --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 14493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14493&action=edit [SIGNED-OFF] Bug 9034 [Follow-up] Add sorting and filtering on items table (catalogue/detail.pl) Rebased on master and signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 14494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14494&action=edit Bug 9034: Filters are disabled by default A small link above the table allow to enable this feature. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- The last patch disable the filtering feature and provide a link to enable it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14494|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14743&action=edit [SIGNED-OFF] Bug 9034: Filters are disabled by default A small link above the table allow to enable this feature. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Medium patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: To test it, go on a catalogue detail page and play with the items list. This patch adds datatable on the items table and an elegant filter method. Code is clean and the 2 datatable features (sort + filter) work great. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14491|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15137&action=edit Bug 9034: Add sorting and filtering on items table (catalogue/detail.pl) This patch introduces a new javascript plugin for dataTables (columnFilter). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14492|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15138&action=edit Bug 9034: Add CSS rule to reduce width of items table Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14493|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15139&action=edit Bug 9034 [Follow-up] Add sorting and filtering on items table (catalogue/detail.pl) This follow-up to the original patch offers an alternative method to handle the width of the table and form fields: - Reduce the font size of the filter input fields - Make the filter inputs' width 100% instead of fixed - Add "'bAutoWidth': false" to the datatables initialization to prevent the table width from being set to the browser window width on load. This allows the browser to be re-sized and have the table re-flow with it. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14743|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15140&action=edit Bug 9034: Filters are disabled by default A small link above the table allow to enable this feature. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Replace single quote strings with double quote strings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9034 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org