[Bug 24549] New: Cookies for last patron link are always set - even if showLastPatron is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Bug ID: 24549 Summary: Cookies for last patron link are always set - even if showLastPatron is turned off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Noticed this while updating the cookie documentation - the cookies relating to the showLastPatron feature are always set, even if the feature itself is turned off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20312 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 [Bug 20312] Add a link towards the last consulted patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98759&action=edit Bug 24549: Do not set "last patron" cookie if showLastPatron is disabled If the showLastPatron syspref is disabled, we should not store the 3 cookies we use for this feature. Test plan: 0/ Do not apply this patch 1/ Turn off showLastPatron 2/ Search for a patron, click on a result 3/ Open the cookie list of your browser => You see 3 cookies named lastborrowercard, lastborrowername, lastborrowernumber 4/ Remove them 5/ Apply the patch 6/ Reload the patron detail page => The 3 cookies are not created 7/ Turn the pref on 8/ Reload the patron detail page => The 3 cookies are created 9/ Eat one of them. QA note: it's a bit dirty, we should do that JS side, but staff-global.js is too widely used to make the change easy. Any other suggestions welcomed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98759|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 98991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98991&action=edit Bug 24549: Do not set "last patron" cookie if showLastPatron is disabled If the showLastPatron syspref is disabled, we should not store the 3 cookies we use for this feature. Test plan: 0/ Do not apply this patch 1/ Turn off showLastPatron 2/ Search for a patron, click on a result 3/ Open the cookie list of your browser => You see 3 cookies named lastborrowercard, lastborrowername, lastborrowernumber 4/ Remove them 5/ Apply the patch 6/ Reload the patron detail page => The 3 cookies are not created 7/ Turn the pref on 8/ Reload the patron detail page => The 3 cookies are created 9/ Eat one of them. QA note: it's a bit dirty, we should do that JS side, but staff-global.js is too widely used to make the change easy. Any other suggestions welcomed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98991|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99129&action=edit Bug 24549: Do not set "last patron" cookie if showLastPatron is disabled If the showLastPatron syspref is disabled, we should not store the 3 cookies we use for this feature. Test plan: 0/ Do not apply this patch 1/ Turn off showLastPatron 2/ Search for a patron, click on a result 3/ Open the cookie list of your browser => You see 3 cookies named lastborrowercard, lastborrowername, lastborrowernumber 4/ Remove them 5/ Apply the patch 6/ Reload the patron detail page => The 3 cookies are not created 7/ Turn the pref on 8/ Reload the patron detail page => The 3 cookies are created 9/ Eat one of them. QA note: it's a bit dirty, we should do that JS side, but staff-global.js is too widely used to make the change easy. Any other suggestions welcomed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.04 released in| | CC| |joy@bywatersolutions.com --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x for 19.11.04 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org