http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |colin.campbell@ptfs-europe. | |com Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 19500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19500&action=edit Proposed patch Fairly trivial patch To Test on a system which includes a unique extended patron attribute Copy or create a patron duplicating the value of the unique attribute without this patch The error message appears as recorded in the bug With this patch the attribute and its value appears instead of 1 e.g. The attribute value MAGICCODE/BOB2 is already is use by another patron record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19500|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19503&action=edit [SIGNED-OFF] Bug 10507 Fix namespace collision in patron entry If a warning about a duplicated patron attribute is returned the value was being passed back for display in the warning message with the same name as the variable in errors as the message is displayed in the context of errors the error value 1 was being displayed not the value duplicated as intended. Pass the value to the template with a unique name Signed-off-by: Owen Leonard <oleonard@myacpl.org> I fixed another tiny typo while signing off: "is already in use" instead of "is already is use." -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19503|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19608&action=edit Bug 10507 Fix namespace collision in patron entry If a warning about a duplicated patron attribute is returned the value was being passed back for display in the warning message with the same name as the variable in errors as the message is displayed in the context of errors the error value 1 was being displayed not the value duplicated as intended. Pass the value to the template with a unique name Signed-off-by: Owen Leonard <oleonard@myacpl.org> I fixed another tiny typo while signing off: "is already in use" instead of "is already is use." Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #7 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.18 -- You are receiving this mail because: You are watching all bug changes.