[Bug 13455] New: Members/AddEnrolmentFeeIfNeeded.t requires sample data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Bug ID: 13455 Summary: Members/AddEnrolmentFeeIfNeeded.t requires sample data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: gmcharlt@gmail.com While trying to debug, I found prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t failed if sample data wasn't in the database. This should be fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 34370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34370&action=edit Bug 13455: Members/AddEnrolmentFeeIfNeeded.t requires sample data TEST PLAN --------- 1) Make sure there are no 'J', 'K', nor 'YA' patron category codes. 2) Make sure there are no 'CPL' nor 'MPL' branch codes. 3) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- dies horribly 4) apply patch 5) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- passes 6) Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 36008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36008&action=edit Bug 13455: Members/AddEnrolmentFeeIfNeeded.t requires sample data TEST PLAN --------- 1) Make sure there are no 'J', 'K', nor 'YA' patron category codes. 2) Make sure there are no 'CPL' nor 'MPL' branch codes. 3) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- dies horribly 4) apply patch 5) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- passes 6) Run koha qa test tools Signed-off-by: Magnus Enger <magnus@enger.priv.no> For me, the tests fail because I have a Norweian setup with different categories etc. After applying the patch the tests pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |magnus@enger.priv.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34370|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- I still completely disagree with this kind of patch, see my comments on bug 13457. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |In Discussion --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Moving this to "In Discussion". -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org